usb: acpi: Switch to use acpi_evaluate_dsm_typed()

PATCH RESEND New Andy Shevchenko 1 participant 1 message Mar 10, 2023 USB

Share & tools

Andy Shevchenko

author

2023-03-10 16:45 UTC #0 lore raw

PATCH RESEND 1/1 usb: acpi: Switch to use acpi_evaluate_dsm_typed()

The acpi_evaluate_dsm_typed() provides a way to check the type of the object evaluated by _DSM call. Use it instead of open coded variant.

Signed-off-by Andy Shevchenko <[email protected]>

---
resend, v1: resent after v6.3-rc1 (Greg)

 drivers/usb/core/usb-acpi.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

drivers/usb/core/usb-acpi.c +4 -8

index 533baa85083c..a34b22537d7c 100644
@@ -81,15 +81,11 @@ int usb_acpi_port_lpm_incapable(struct usb_device *hdev, int index)
 		return -ENODEV;
 	}
 
-	obj = acpi_evaluate_dsm(port_handle, &guid, 0,
-				USB_DSM_DISABLE_U1_U2_FOR_PORT, NULL);
-
-	if (!obj)
-		return -ENODEV;
-
-	if (obj->type != ACPI_TYPE_INTEGER) {
+	obj = acpi_evaluate_dsm_typed(port_handle, &guid, 0,
+				      USB_DSM_DISABLE_U1_U2_FOR_PORT, NULL,
+				      ACPI_TYPE_INTEGER);
+	if (!obj) {
 		dev_dbg(&hdev->dev, "evaluate port-%d _DSM failed\n", port1);
-		ACPI_FREE(obj);
 		return -EINVAL;
 	}

Signature · 1 line

2.39.1