Using MAP_SHARE_VALIDATE in mmap without fd
Subsystems (2)
PATCH 1/1 Using MAP_SHARE_VALIDATE in mmap without fd
Hey,
I have a rather simple question about the MAP_SHARED_VALIDATE flag in mmap.
When used without a file pointer, EINVAL is returned. Is there a reason for this?
I researched a bit but could not find anything. I attached a simple patch that adds MAP_SHARE_VALIDATE to the flags switch and checks for invalid flags.
--- mm/mmap.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
mm/mmap.c +7 -2
@@ -1196,6 +1196,7 @@ unsigned long do_mmap(struct file *file, unsigned long addr, {struct mm_struct *mm = current->mm;vm_flags_t vm_flags; +unsigned long flags_mask;int pkey =0 ;validate_mm (mm);
@@ -1266,14 +1267,14 @@ unsigned long do_mmap(struct file *file, unsigned long addr,if (mlock_future_check (mm, vm_flags, len))return -EAGAIN ; + flags_mask =LEGACY_MAP_MASK ;if (file) {struct inode *inode =file_inode (file); -unsigned long flags_mask;if (!file_mmap_ok (file, inode, pgoff, len))return -EOVERFLOW ; - flags_mask =LEGACY_MAP_MASK | file->f_op->mmap_supported_flags; + flags_mask |= file->f_op->mmap_supported_flags;switch (flags &MAP_TYPE ) {case MAP_SHARED :
@@ -1327,6 +1328,10 @@ unsigned long do_mmap(struct file *file, unsigned long addr, } }else {switch (flags &MAP_TYPE ) { +case MAP_SHARED_VALIDATE : +if (flags & ~flags_mask) +return -EOPNOTSUPP ; + fallthrough;case MAP_SHARED :if (vm_flags & (VM_GROWSDOWN |VM_GROWSUP ))return -EINVAL ;
Signature · 1 line
2.39.2
Quoted 3 lines · Nils Hartmann
Hey,
I have a rather simple question about theMAP_SHARED_VALIDATEflag in mmap. When used without a file pointer, EINVAL is returned. Is there a reason for this?
You mean, using it with shared anonymous memory? (MAP_SHARED|MAP_ANON)
I assume you mean "file descriptor" not "file pointer".
Quoted 2 lines
I researched a bit but could not find anything. I attached a simple patch that adds
MAP_SHARE_VALIDATEto the flags switch and checks for invalid flags.
The only reason MAP_SHARED_VALIDATE was introduced was due to MAP_SYNC, only required for DAX. DAX does not apply to shared anonymous memory.
I guess nobody cared/cares.
Question is if we want to update the implementation (there has to be a good reason IMHO) or simply update the man page, stating that MAP_SHARED_VALIDATE is not supported for MAP_ANON.
Quoted 45 lines
Signed-off-by Nils Hartmann <[email protected]>--- mm/mmap.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)mm/mmap.c +7
-2@@ -1196,6 +1196,7 @@ unsigned long do_mmap(struct file *file, unsigned long addr, {struct mm_struct *mm = current->mm;vm_flags_t vm_flags; +unsigned long flags_mask;int pkey =0 ;validate_mm (mm);@@ -1266,14 +1267,14 @@ unsigned long do_mmap(struct file *file, unsigned long addr,if (mlock_future_check (mm, vm_flags, len))return -EAGAIN ; + flags_mask =LEGACY_MAP_MASK ;if (file) {struct inode *inode =file_inode (file); -unsigned long flags_mask;if (!file_mmap_ok (file, inode, pgoff, len))return -EOVERFLOW ; - flags_mask =LEGACY_MAP_MASK | file->f_op->mmap_supported_flags; + flags_mask |= file->f_op->mmap_supported_flags;switch (flags &MAP_TYPE ) {case MAP_SHARED :@@ -1327,6 +1328,10 @@ unsigned long do_mmap(struct file *file, unsigned long addr, } }else {switch (flags &MAP_TYPE ) { +case MAP_SHARED_VALIDATE : +if (flags & ~flags_mask) +return -EOPNOTSUPP ; + fallthrough;case MAP_SHARED :if (vm_flags & (VM_GROWSDOWN |VM_GROWSUP ))return -EINVAL ;
Signature · 3 lines
Thanks, David / dhildenb
Quoted 6 lines · David Hildenbrand
Quoted 2 lines · Nils Hartmann
Hey,
When used without a file pointer, EINVAL is returned. Is there a reason for this?You mean, using it with shared anonymous memory? (MAP_SHARED|MAP_ANON) I assume you mean "file descriptor" not "file pointer".
Yup thats what I meant.
Quoted 2 lines
The only reason
MAP_SHARED_VALIDATEwas introduced was due toMAP_SYNC, only required for DAX. DAX does not apply to shared anonymous memory.
Yeah I heard about it being introduced with MAP_SYNC. But since the manpage from mmap specifically says:
'MAP_SHARED_VALIDATE provides the same behaviour as MAP_SHARED', I didn't think it would make a difference
Quoted 4 lines
I guess nobody cared/cares.
Question is if we want to update the implementation (there has to be a good reason IMHO) or simply update the man page, stating thatMAP_SHARED_VALIDATEis not supported forMAP_ANON.
The only reason I can come up with, is naming consistency. But it's really a non-issue und updating the man page is definitly the saner option.
Quoted 5 lines
--
Thanks,David / dhildenb
Best Regards,
Nils