Skip to contentSkip to conversation

mm/slub: fix help comment of SLUB_DEBUG

PATCH In review Vernon Yang 2 participants 2 messages Mar 14, 2023 – Mar 17, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mm/slub: fix help comment of SLUB_DEBUG

Since commit ab4d5ed5eeda ("slub: Enable sysfs support for !CONFIG_SLUB_DEBUG"), disabling SLUB_DEBUG also disables SLUB sysfs support that is not true anymore, so fix it correctly.

---
 mm/Kconfig.debug | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
mm/Kconfig.debug +2 -3
index c3547a373c9c..9a90a88ce053 100644
@@ -60,9 +60,8 @@ config SLUB_DEBUG
 	select STACKDEPOT if STACKTRACE_SUPPORT
 	help
 	  SLUB has extensive debug support features. Disabling these can
-	  result in significant savings in code size. This also disables
-	  SLUB sysfs support. /sys/slab will not exist and there will be
-	  no support for cache validation etc.
+	  result in significant savings in code size, the /sys/kernel/slab
+	  will exist but will not provide e.g. cache validation.
 
 config SLUB_DEBUG_ON
 	bool "SLUB debugging on by default"
Signature · 1 line
2.34.1
#1 lore raw
Quoted 5 lines · Vernon Yang

Since commit ab4d5ed5eeda ("slub: Enable sysfs support for !CONFIG_SLUB_DEBUG"), disabling SLUB_DEBUG also disables SLUB sysfs support that is not true anymore, so fix it correctly.

Thanks, slightly reworded and pushed to slab/for-6.4/trivial

Quoted 20 lines
---
 mm/Kconfig.debug | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
mm/Kconfig.debug +2 -3
index c3547a373c9c..9a90a88ce053 100644
@@ -60,9 +60,8 @@ config SLUB_DEBUG
 	select STACKDEPOT if STACKTRACE_SUPPORT
 	help
 	  SLUB has extensive debug support features. Disabling these can
-	  result in significant savings in code size. This also disables
-	  SLUB sysfs support. /sys/slab will not exist and there will be
-	  no support for cache validation etc.
+	  result in significant savings in code size, the /sys/kernel/slab
+	  will exist but will not provide e.g. cache validation.
 
 config SLUB_DEBUG_ON
 	bool "SLUB debugging on by default"