hwmon: (adm1266) Set `can_sleep` flag for GPIO chip
PATCH 1/2 hwmon: (adm1266) Set `can_sleep` flag for GPIO chip
The adm1266 driver uses I2C bus access in its GPIO chip set and get implementation. This means these functions can sleep and the GPIO chip should set the can_sleep property to true.
This will ensure that a warning is printed when trying to set or get the GPIO value from a context that potentially can't sleep.
--- drivers/hwmon/pmbus/adm1266.c | 1 + 1 file changed, 1 insertion(+)
drivers/hwmon/pmbus/adm1266.c +1 -0
@@ -301,6 +301,7 @@ static int adm1266_config_gpio(struct adm1266_data *data) data->gc.label = name; data->gc.parent = &data->client->dev; data->gc.owner =THIS_MODULE ; + data->gc.can_sleep = true; data->gc.base =-1 ; data->gc.names = data->gpio_names; data->gc.ngpio =ARRAY_SIZE (data->gpio_names);
Signature · 1 line
2.30.2
PATCH 2/2 hwmon: (ltc2992) Set `can_sleep` flag for GPIO chip
The ltc2992 drivers uses a mutex and I2C bus access in its GPIO chip set and get implementation. This means these functions can sleep and the GPIO chip should set the can_sleep property to true.
This will ensure that a warning is printed when trying to set or get the GPIO value from a context that potentially can't sleep.
--- drivers/hwmon/ltc2992.c | 1 + 1 file changed, 1 insertion(+)
drivers/hwmon/ltc2992.c +1 -0
@@ -323,6 +323,7 @@ static int ltc2992_config_gpio(struct ltc2992_state *st) st->gc.label = name; st->gc.parent = &st->client->dev; st->gc.owner =THIS_MODULE ; + st->gc.can_sleep = true; st->gc.base =-1 ; st->gc.names = st->gpio_names; st->gc.ngpio =ARRAY_SIZE (st->gpio_names);
Signature · 1 line
2.30.2
Re: [PATCH 2/2] hwmon: (ltc2992) Set `can_sleep` flag for GPIO chip
Quoted 9 lines · Lars-Peter Clausen
The ltc2992 drivers uses a mutex and I2C bus access in its GPIO chip
setandgetimplementation. This means these functions can sleep and the GPIO chip should set thecan_sleepproperty to true.This will ensure that a warning is printed when trying to set or get the GPIO value from a context that potentially can't sleep.
Fixes 9ca26df1ba25 ("hwmon: (ltc2992) Add support for GPIOs.")Signed-off-by Lars-Peter Clausen <[email protected]>
Applied.
Thanks,
Guenter
Quoted 16 lines
--- drivers/hwmon/ltc2992.c | 1 + 1 file changed, 1 insertion(+)drivers/hwmon/ltc2992.c +1
-0@@ -323,6 +323,7 @@ static int ltc2992_config_gpio(struct ltc2992_state *st) st->gc.label = name; st->gc.parent = &st->client->dev; st->gc.owner =THIS_MODULE ; + st->gc.can_sleep = true; st->gc.base =-1 ; st->gc.names = st->gpio_names; st->gc.ngpio =ARRAY_SIZE (st->gpio_names);
Quoted 9 lines · Lars-Peter Clausen
The adm1266 driver uses I2C bus access in its GPIO chip
setandgetimplementation. This means these functions can sleep and the GPIO chip should set thecan_sleepproperty to true.This will ensure that a warning is printed when trying to set or get the GPIO value from a context that potentially can't sleep.
Fixes d98dfad35c38 ("hwmon: (pmbus/adm1266) Add support for GPIOs")Signed-off-by Lars-Peter Clausen <[email protected]>
Applied.
Thanks,
Guenter
Quoted 16 lines
--- drivers/hwmon/pmbus/adm1266.c | 1 + 1 file changed, 1 insertion(+)drivers/hwmon/pmbus/adm1266.c +1
-0@@ -301,6 +301,7 @@ static int adm1266_config_gpio(struct adm1266_data *data) data->gc.label = name; data->gc.parent = &data->client->dev; data->gc.owner =THIS_MODULE ; + data->gc.can_sleep = true; data->gc.base =-1 ; data->gc.names = data->gpio_names; data->gc.ngpio =ARRAY_SIZE (data->gpio_names);