xfs_repair: fix incorrect dabtree hashval comparison
PATCH 1/1 xfs_repair: fix incorrect dabtree hashval comparison
From: Darrick J. Wong <[email protected]>
If an xattr structure contains enough names with the same hash value to fill multiple xattr leaf blocks with names all hashing to the same value, then the dabtree nodes will contain consecutive entries with the same hash value.
This causes false corruption reports in xfs_repair because it's not expecting such a huge same-hashing structure. Fix that.
--- repair/da_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
repair/da_util.c +1 -1
@@ -330,7 +330,7 @@ _("%s block used/count inconsistency - %d/%hu\n"),/* * hash values monotonically increasing ??? */ -if (cursor->level[this_level].hashval >= +if (cursor->level[this_level].hashval >be32_to_cpu (nodehdr.btree[entry].hashval)) { do_warn( _("%s block hashvalue inconsistency, expected > %u / saw %u\n"),
Quoted 11 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
If an xattr structure contains enough names with the same hash value to fill multiple xattr leaf blocks with names all hashing to the same value, then the dabtree nodes will contain consecutive entries with the same hash value.
This causes false corruption reports in
xfs_repairbecause it's not expecting such a huge same-hashing structure. Fix that.Signed-off-by Darrick J. Wong <[email protected]>
Looks good. Will test.
Quoted 17 lines
--- repair/da_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)repair/da_util.c +1
-1@@ -330,7 +330,7 @@ _("%s block used/count inconsistency - %d/%hu\n"),/* * hash values monotonically increasing ??? */ -if (cursor->level[this_level].hashval >= +if (cursor->level[this_level].hashval >be32_to_cpu (nodehdr.btree[entry].hashval)) { do_warn( _("%s block hashvalue inconsistency, expected > %u / saw %u\n"),
Signature · 1 line
Carlos Maiolino