5.4.237-rc2 review

This is the start of the stable review cycle for the 5.4.237 release. There are 55 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat, 18 Mar 2023 08:33:04 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.237-rc2.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <[email protected]>

    Linux 5.4.237-rc2

Stefan Haberland <[email protected]>
s390/dasd: add missing discipline function

Masahiro Yamada <[email protected]>
UML: define RUNTIME_DISCARD_EXIT

Tom Saeger <[email protected]>
sh: define RUNTIME_DISCARD_EXIT

Masahiro Yamada <[email protected]>
s390: define RUNTIME_DISCARD_EXIT to fix link error with GNU ld < 2.36

Michael Ellerman <[email protected]>
powerpc/vmlinux.lds: Don't discard .rela* for relocatable builds

Michael Ellerman <[email protected]>
powerpc/vmlinux.lds: Define RUNTIME_DISCARD_EXIT

Masahiro Yamada <[email protected]>
arch: fix broken BuildID for arm64 and riscv

H.J. Lu <[email protected]>
x86, vmlinux.lds: Add RUNTIME_DISCARD_EXIT to generic DISCARDS

John Harrison <[email protected]>
drm/i915: Don't use BAR mappings for ring buffers with LLC

Corey Minyard <[email protected]>
ipmi:watchdog: Set panic count to proper value on a panic

Yejune Deng <[email protected]>
ipmi/watchdog: replace atomic_add() and atomic_sub()

Paul Elder <[email protected]>
media: ov5640: Fix analogue gain control

Alvaro Karsz <[email protected]>
PCI: Add SolidRun vendor ID

Nathan Chancellor <[email protected]>
macintosh: windfarm: Use unsigned type for 1-bit bitfields

Edward Humes <[email protected]>
alpha: fix R_ALPHA_LITERAL reloc for large modules

xurui <[email protected]>
MIPS: Fix a compilation issue

Dmitry Baryshkov <[email protected]>
clk: qcom: mmcc-apq8084: remove spdm clocks

Jan Kara <[email protected]>
ext4: Fix deadlock during directory rename

Alexandre Ghiti <[email protected]>
riscv: Use READ_ONCE_NOCHECK in imprecise unwinding stack mode

D. Wythe <[email protected]>
net/smc: fix fallback failed while sendmsg with fastopen

Chandrakanth Patil <[email protected]>
scsi: megaraid_sas: Update max supported LD IDs to 240

Lorenz Bauer <[email protected]>
btf: fix resolving BTF_KIND_VAR after ARRAY, STRUCT, UNION, PTR

Florian Westphal <[email protected]>
netfilter: tproxy: fix deadlock due to missing BH disable

Michael Chan <[email protected]>
bnxt_en: Avoid order-5 memory allocation for TPA data

Shigeru Yoshida <[email protected]>
net: caif: Fix use-after-free in cfusbl_device_notify()

Yuiko Oshino <[email protected]>
net: lan78xx: fix accessing the LAN7800's internal phy specific registers from the MAC driver

Lee Jones <[email protected]>
net: usb: lan78xx: Remove lots of set but unused 'ret' variables

Hangbin Liu <[email protected]>
selftests: nft_nat: ensuring the listening side is up before starting the client

Eric Dumazet <[email protected]>
ila: do not generate empty messages in ila_xlat_nl_cmd_get_mapping()

Kang Chen <[email protected]>
nfc: fdp: add null check of devm_kmalloc_array in fdp_nci_i2c_read_device_properties

Dmitry Baryshkov <[email protected]>
drm/msm/a5xx: fix setting of the CP_PREEMPT_ENABLE_LOCAL register

Jan Kara <[email protected]>
ext4: Fix possible corruption when moving a directory

Bart Van Assche <[email protected]>

    scsi: core: Remove the /proc/scsi/${proc_name} directory earlier

Volker Lendecke <[email protected]>
cifs: Fix uninitialized memory read in smb3_qfs_tcon()

Amir Goldstein <[email protected]>
SMB3: Backup intent flag missing from some more ops

Jacob Pan <[email protected]>
iommu/vt-d: Fix PASID directory pointer coherency

Marc Zyngier <[email protected]>
irqdomain: Fix domain registration race

Bixuan Cui <[email protected]>
irqdomain: Change the type of 'size' in __irq_domain_add() to be consistent

Corey Minyard <[email protected]>
ipmi:ssif: Add a timer between request retries

Corey Minyard <[email protected]>
ipmi:ssif: Increase the message retry time

Corey Minyard <[email protected]>
ipmi:ssif: Remove rtc_us_timer

Corey Minyard <[email protected]>
ipmi:ssif: resend_msg() cannot fail

Liguang Zhang <[email protected]>
ipmi:ssif: make ssif_i2c_send() void

Gavrilov Ilia <[email protected]>
iommu/amd: Add a length limitation for the ivrs_acpihid command-line parameter

Kim Phillips <[email protected]>
iommu/amd: Fix ill-formed ivrs_ioapic, ivrs_hpet and ivrs_acpihid options

Suravee Suthikulpanit <[email protected]>
iommu/amd: Add PCI segment support for ivrs_[ioapic/hpet/acpihid] commands

Fedor Pchelkin <[email protected]>
nfc: change order inside nfc_se_io error path

Zhihao Cheng <[email protected]>
ext4: zero i_disksize when initializing the bootloader inode

Ye Bin <[email protected]>
ext4: fix WARNING in ext4_update_inline_data

Ye Bin <[email protected]>
ext4: move where set the MAY_INLINE_DATA flag is set

Darrick J. Wong <[email protected]>
ext4: fix another off-by-one fsmap error on 1k block filesystems

Eric Whitney <[email protected]>
ext4: fix RENAME_WHITEOUT handling for inline directories

Harry Wentland <[email protected]>
drm/connector: print max_requested_bpc in state debugfs

Andrew Cooper <[email protected]>

    x86/CPU/AMD: Disable XSAVES on AMD family 0x17

Theodore Ts'o <[email protected]>
fs: prevent out-of-bounds array speculation when closing a file descriptor

-------------

Diffstat:

 Documentation/admin-guide/kernel-parameters.txt |  51 ++++-
 Makefile                                        |   4 +-
 arch/alpha/kernel/module.c                      |   4 +-
 arch/mips/include/asm/mach-rc32434/pci.h        |   2 +-
 arch/powerpc/kernel/vmlinux.lds.S               |   6 +-
 arch/riscv/kernel/stacktrace.c                  |   2 +-
 arch/s390/kernel/vmlinux.lds.S                  |   2 +
 arch/sh/kernel/vmlinux.lds.S                    |   1 +
 arch/um/kernel/vmlinux.lds.S                    |   2 +-
 arch/x86/kernel/cpu/amd.c                       |   9 +
 arch/x86/kernel/vmlinux.lds.S                   |   2 +
 drivers/char/ipmi/ipmi_ssif.c                   | 146 +++++--------
 drivers/char/ipmi/ipmi_watchdog.c               |   8 +-
 drivers/clk/qcom/mmcc-apq8084.c                 | 271 ------------------------
 drivers/gpu/drm/drm_atomic.c                    |   1 +
 drivers/gpu/drm/i915/gt/intel_ringbuffer.c      |   4 +-
 drivers/gpu/drm/msm/adreno/a5xx_gpu.c           |   4 +-
 drivers/iommu/amd_iommu_init.c                  | 105 ++++++---
 drivers/iommu/intel-pasid.c                     |   7 +
 drivers/macintosh/windfarm_lm75_sensor.c        |   4 +-
 drivers/macintosh/windfarm_smu_sensors.c        |   4 +-
 drivers/media/i2c/ov5640.c                      |   2 +-
 drivers/net/ethernet/broadcom/bnxt/bnxt.c       |  23 +-
 drivers/net/phy/microchip.c                     |  32 +++
 drivers/net/usb/lan78xx.c                       | 189 +++++++----------
 drivers/nfc/fdp/i2c.c                           |   4 +
 drivers/s390/block/dasd_diag.c                  |   7 +-
 drivers/s390/block/dasd_fba.c                   |   7 +-
 drivers/s390/block/dasd_int.h                   |   1 -
 drivers/scsi/hosts.c                            |   2 +
 drivers/scsi/megaraid/megaraid_sas.h            |   2 +
 drivers/scsi/megaraid/megaraid_sas_fp.c         |   2 +-
 fs/cifs/cifsacl.c                               |  14 +-
 fs/cifs/cifsfs.c                                |   2 +-
 fs/cifs/cifsglob.h                              |   6 +-
 fs/cifs/cifsproto.h                             |   8 +
 fs/cifs/connect.c                               |   2 +-
 fs/cifs/dir.c                                   |   5 +-
 fs/cifs/file.c                                  |  10 +-
 fs/cifs/inode.c                                 |   8 +-
 fs/cifs/ioctl.c                                 |   2 +-
 fs/cifs/link.c                                  |  18 +-
 fs/cifs/smb1ops.c                               |  19 +-
 fs/cifs/smb2inode.c                             |   9 +-
 fs/cifs/smb2ops.c                               |  92 +++-----
 fs/cifs/smb2proto.h                             |   2 +-
 fs/ext4/fsmap.c                                 |   2 +
 fs/ext4/inline.c                                |   1 -
 fs/ext4/inode.c                                 |   7 +-
 fs/ext4/ioctl.c                                 |   1 +
 fs/ext4/namei.c                                 |  36 +++-
 fs/ext4/xattr.c                                 |   3 +
 fs/file.c                                       |   1 +
 include/asm-generic/vmlinux.lds.h               |  16 +-
 include/linux/irqdomain.h                       |   2 +-
 include/linux/pci_ids.h                         |   2 +
 include/net/netfilter/nf_tproxy.h               |   7 +
 kernel/bpf/btf.c                                |   1 +
 kernel/irq/irqdomain.c                          |  62 ++++--
 net/caif/caif_usb.c                             |   3 +
 net/ipv4/netfilter/nf_tproxy_ipv4.c             |   2 +-
 net/ipv6/ila/ila_xlat.c                         |   1 +
 net/ipv6/netfilter/nf_tproxy_ipv6.c             |   2 +-
 net/nfc/netlink.c                               |   2 +-
 net/smc/af_smc.c                                |  13 +-
 tools/testing/selftests/netfilter/nft_nat.sh    |   2 +
 66 files changed, 558 insertions(+), 715 deletions(-)

Hello Greg,

CIP configurations built and booted with Linux 5.4.237-rc2 (1baba0e91ac5):
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/pipelines/808352559
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/commits/linux-5.4.y

Kind regards, Chris

On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels, build tested on BMIPS_GENERIC:

Florian

Hi Greg,

No problems detected on x86_64 and aarch64.

Thanks,
Harshit

Build ID for arm64 is back with CONFIG_MODVERSIONS=y Hooray!

Build results:

	total: 159 pass: 159 fail: 0
Qemu test results:
	total: 455 pass: 455 fail: 0

Guenter

Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.

## Build
* kernel: 5.4.237-rc2
* git: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc
* git branch: linux-5.4.y
* git commit: 1baba0e91ac5e439c0e58b2d241a6aac8d50191c
* git describe: v5.4.235-60-g1baba0e91ac5
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.4.y/build/v5.4.235-60-g1baba0e91ac5

## Test Regressions (compared to v5.4.235)

## Metric Regressions (compared to v5.4.235)

## Test Fixes (compared to v5.4.235)

## Metric Fixes (compared to v5.4.235)

## Test result summary
total: 117469, pass: 95900, fail: 2961, skip: 18470, xfail: 138

## Build Summary
* arc: 5 total, 5 passed, 0 failed
* arm: 146 total, 145 passed, 1 failed
* arm64: 46 total, 42 passed, 4 failed
* i386: 28 total, 22 passed, 6 failed
* mips: 30 total, 29 passed, 1 failed
* parisc: 8 total, 8 passed, 0 failed
* powerpc: 33 total, 32 passed, 1 failed
* riscv: 15 total, 12 passed, 3 failed
* s390: 8 total, 8 passed, 0 failed
* sh: 14 total, 12 passed, 2 failed
* sparc: 8 total, 8 passed, 0 failed
* x86_64: 39 total, 37 passed, 2 failed

## Test suites summary
* boot
* fwts
* kselftest-android
* kselftest-arm64
* kselftest-breakpoints
* kselftest-capabilities
* kselftest-cgroup
* kselftest-clone3
* kselftest-core
* kselftest-cpu-hotplug
* kselftest-cpufreq
* kselftest-drivers-dma-buf
* kselftest-efivarfs
* kselftest-filesystems
* kselftest-filesystems-binderfs
* kselftest-firmware
* kselftest-fpu
* kselftest-ftrace
* kselftest-futex
* kselftest-gpio
* kselftest-intel_pstate
* kselftest-ipc
* kselftest-ir
* kselftest-kcmp
* kselftest-kexec
* kselftest-kvm
* kselftest-lib
* kselftest-livepatch
* kselftest-membarrier
* kselftest-memfd
* kselftest-memory-hotplug
* kselftest-mincore
* kselftest-mount
* kselftest-mqueue
* kselftest-net
* kselftest-net-forwarding
* kselftest-net-mptcp
* kselftest-netfilter
* kselftest-nsfs
* kselftest-openat2
* kselftest-pid_namespace
* kselftest-pidfd
* kselftest-proc
* kselftest-pstore
* kselftest-ptrace
* kselftest-rseq
* kselftest-rtc
* kselftest-seccomp
* kselftest-tc-testing
* kselftest-timens
* kselftest-timers
* kselftest-tmpfs
* kselftest-tpm2
* kselftest-user
* kselftest-vm
* kselftest-x86
* kselftest-zram
* kunit
* kvm-unit-tests
* libgpiod
* libhugetlbfs
* log-parser-boot
* log-parser-test
* ltp-cap_bounds
* ltp-commands
* ltp-containers
* ltp-controllers
* ltp-cpuhotplug
* ltp-crypto
* ltp-cve
* ltp-dio
* ltp-fcntl-locktests
* ltp-filecaps
* ltp-fs
* ltp-fs_bind
* ltp-fs_perms_simple
* ltp-fsx
* ltp-hugetlb
* ltp-io
* ltp-ipc
* ltp-math
* ltp-mm
* ltp-nptl
* ltp-open-posix-tests
* ltp-pty
* ltp-sched
* ltp-securebits
* ltp-smoke
* ltp-syscalls
* ltp-tracing
* network-basic-tests
* perf
* rcutorture
* v4l2-compliance
* vdso

--
Linaro LKFT
https://lkft.linaro.org

Hi Greg,

Build test (gcc version 11.3.1 20230311):
mips: 65 configs -> 1 failure
arm: 106 configs -> no failure
arm64: 2 configs -> no failure
x86_64: 4 configs -> no failure alpha allmodconfig -> no failure powerpc allmodconfig -> no failure riscv allmodconfig -> no failure s390 allmodconfig -> no failure xtensa allmodconfig -> no failure

mips build failure:
lasat_defconfig -> failed

arch/mips/lasat/picvue_proc.c:42:44: error: expected ')' before '&' token

   42 | static DECLARE_TASKLET(pvc_display_tasklet, &pvc_display, 0);
      |                                            ^~
      |                                            )
arch/mips/lasat/picvue_proc.c: In function 'pvc_line_proc_write':
arch/mips/lasat/picvue_proc.c:87:27: error: 'pvc_display_tasklet' undeclared (first use in this function)
   87 |         tasklet_schedule(&pvc_display_tasklet);
      |                           ^~~~~~~~~~~~~~~~~~~

arch/mips/lasat/picvue_proc.c:87:27: note: each undeclared identifier is reported only once for each function it appears in At top level:
arch/mips/lasat/picvue_proc.c:33:13: error: 'pvc_display' defined but not used [-Werror=unused-function]
33 | static void pvc_display(unsigned long data)

      |             ^~~~~~~~~~~

Boot test:
x86_64: Booted on qemu. No regression. [1]

Boot Regression on test laptop.

[    3.473713] BUG: kernel NULL pointer dereference, address: 000000000000007c
[    3.473720] #PF: supervisor read access in kernel mode
[    3.473722] #PF: error_code(0x0000) - not-present page
[    3.473723] PGD 0 P4D 0 
[    3.473727] Oops: 0000 [#1] SMP NOPTI
[    3.473730] CPU: 0 PID: 114 Comm: systemd-udevd Not tainted 5.4.237-rc2-1baba0e91ac5+ #1
[    3.473732] Hardware name: LENOVO 4287CTO/4287CTO, BIOS 8DET68WW (1.38 ) 04/11/2013
[    3.473798] RIP: 0010:intel_context_unpin+0xe/0x120 [i915]
[    3.473804] Code: 60 00 e9 44 ff ff ff be 02 00 00 00 e8 8b 8d d3 fa eb ae 41 bd fc ff ff ff eb b2 90 66 66 66 66 90 41 55 48 8d 57 7c 41 54 55 <8b> 47 7c 48 89 fd 83 f8 01 74 0f 8d 48 ff f0 0f b1 0a 75 f2 5d 41
[    3.473808] RSP: 0018:ffff9d6900167a58 EFLAGS: 00010246
[    3.473811] RAX: ffff8898905c9400 RBX: ffff889787fea000 RCX: ffff8898905c94c0
[    3.473814] RDX: 000000000000007c RSI: ffff8898905caac0 RDI: 0000000000000000
[    3.473817] RBP: ffff889787fea000 R08: ffff889891f86160 R09: ffff8898960af4b8
[    3.473820] R10: ffff88978757a0c0 R11: 00000000030c44f5 R12: 00000000fffffffa
[    3.473823] R13: ffff8898913feb80 R14: ffffffffc04e4bf0 R15: ffff889891f877c8
[    3.473827] FS:  00007f5b0f8648c0(0000) GS:ffff889896000000(0000) knlGS:0000000000000000
[    3.473830] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[    3.473833] CR2: 000000000000007c CR3: 000000021100c005 CR4: 00000000000606f0
[    3.473836] Call Trace:
[    3.473893]  intel_engine_cleanup_common+0xb7/0x1f0 [i915]
[    3.473947]  intel_ring_submission_init+0x60/0x110 [i915]
[    3.473999]  intel_engines_init+0x44/0xa0 [i915]
[    3.474056]  i915_gem_init+0x1f7/0x7e0 [i915]
[    3.474118]  ? intel_modeset_init+0x101e/0x1c70 [i915]
[    3.474167]  i915_driver_probe+0xc43/0x14f0 [i915]
[    3.474175]  ? __kernfs_new_node+0x156/0x1b0
[    3.474180]  ? kfree+0xb3/0x230
[    3.474229]  ? i915_pci_probe+0x3f/0x150 [i915]
[    3.474234]  local_pci_probe+0x42/0x80
[    3.474240]  ? _cond_resched+0x16/0x40
[    3.474245]  pci_device_probe+0xfd/0x1b0
[    3.474251]  really_probe+0x160/0x400
[    3.474255]  driver_probe_device+0xb6/0x100
[    3.474259]  device_driver_attach+0xa1/0xb0
[    3.474263]  __driver_attach+0x9b/0x140
[    3.474267]  ? device_driver_attach+0xb0/0xb0
[    3.474271]  bus_for_each_dev+0x78/0xc0
[    3.474275]  bus_add_driver+0x136/0x200
[    3.474279]  driver_register+0x8f/0xe0
[    3.474283]  ? 0xffffffffc06ec000
[    3.474288]  do_one_initcall+0x46/0x200
[    3.474292]  ? _cond_resched+0x16/0x40
[    3.474297]  ? kmem_cache_alloc_trace+0x19d/0x220
[    3.474302]  ? do_init_module+0x23/0x250
[    3.474305]  do_init_module+0x4c/0x250
[    3.474310]  __do_sys_finit_module+0xac/0x110
[    3.474315]  do_syscall_64+0x52/0x160
[    3.474320]  entry_SYSCALL_64_after_hwframe+0x5c/0xc1
[    3.474324] Modules linked in: i915(+) ahci crc32c_intel libahci libata psmouse i2c_i801 scsi_mod i2c_algo_bit lpc_ich ehci_pci ehci_hcd sdhci_pci drm_kms_helper cqhci sdhci usbcore usb_common mmc_core e1000e(+) drm ptp pps_core video
[    3.474342] CR2: 000000000000007c
[    3.474346] ---[ end trace c956347dbb581033 ]---

[1]. https://openqa.qa.codethink.co.uk/tests/3131

Regards
Sudip