dt-bindings: leds: add "usbport" trigger
Subsystems (2)
PATCH v2 1/1 dt-bindings: leds: add "usbport" trigger
From: Rafał Miłecki <[email protected]>
Linux's "usbport" trigger is a bit specific one. It allows LED to follow state of multiple USB ports which have to be selected additionally (there isn't a single trigger for each port).
Default list of USB ports to monitor can be specified using "trigger-sources" DT property. Theoretically it should be possible for Linux to deduce applicable trigger based on the references nodes in the "trigger-sources". It hasn't been implemented however (probably due to laziness).
Milk spilled - we already have DT files specifying "usbport" manually - allow that value in the binding. This fixes validation of in-kernel and external DT files.
--- Documentation/devicetree/bindings/leds/common.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/leds/common.yaml +2 -0
@@ -125,6 +125,8 @@ properties: - usb-gadget # LED indicates USB host activity - usb-host + # LED indicates USB port state + - usbport # LED is triggered by CPU activity - pattern: "^cpu[0-9]*$" # LED is triggered by Bluetooth activity
Signature · 1 line
2.34.1
Quoted 12 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
Linux's "usbport" trigger is a bit specific one. It allows LED to follow state of multiple USB ports which have to be selected additionally (there isn't a single trigger for each port).
Default list of USB ports to monitor can be specified using "trigger-sources" DT property. Theoretically it should be possible for Linux to deduce applicable trigger based on the references nodes in the "trigger-sources". It hasn't been implemented however (probably due to laziness).
Quoted 8 lines
Milk spilled - we already have DT files specifying "usbport" manually - allow that value in the binding. This fixes validation of in-kernel and external DT files.
Signed-off-by Rafał Miłecki <[email protected]>--- Documentation/devicetree/bindings/leds/common.yaml | 2 ++ 1 file changed, 2 insertions(+)
Applied, thanks
--
Lee Jones [李琼斯]
Hi Lee,
Quoted 18 lines · Lee Jones
Quoted 16 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
Linux's "usbport" trigger is a bit specific one. It allows LED to follow state of multiple USB ports which have to be selected additionally (there isn't a single trigger for each port).
Default list of USB ports to monitor can be specified using "trigger-sources" DT property. Theoretically it should be possible for Linux to deduce applicable trigger based on the references nodes in the "trigger-sources". It hasn't been implemented however (probably due to laziness).
Milk spilled - we already have DT files specifying "usbport" manually - allow that value in the binding. This fixes validation of in-kernel and external DT files.
Quoted 6 lines
Quoted 4 lines
Signed-off-by Rafał Miłecki <[email protected]>--- Documentation/devicetree/bindings/leds/common.yaml | 2 ++ 1 file changed, 2 insertions(+)Applied, thanks
it seems this PATCH got lost somewhere. Can you check it, please?
Signature · 1 line
Rafał Miłecki
Lee Jones
maintainerQuoted 21 lines · Rafał Miłecki
Hi Lee,
Quoted 18 lines · Lee Jones
Quoted 16 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
Linux's "usbport" trigger is a bit specific one. It allows LED to follow state of multiple USB ports which have to be selected additionally (there isn't a single trigger for each port).
Default list of USB ports to monitor can be specified using "trigger-sources" DT property. Theoretically it should be possible for Linux to deduce applicable trigger based on the references nodes in the "trigger-sources". It hasn't been implemented however (probably due to laziness).
Milk spilled - we already have DT files specifying "usbport" manually - allow that value in the binding. This fixes validation of in-kernel and external DT files.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Signed-off-by Rafał Miłecki <[email protected]>--- Documentation/devicetree/bindings/leds/common.yaml | 2 ++ 1 file changed, 2 insertions(+)Applied, thanks
it seems this PATCH got lost somewhere. Can you check it, please?
What makes you think that?
Signature · 1 line
Lee Jones [李琼斯]
Quoted 25 lines · Lee Jones
Quoted 24 lines · Rafał Miłecki
Quoted 23 lines · Lee Jones
Quoted 20 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
Linux's "usbport" trigger is a bit specific one. It allows LED to follow state of multiple USB ports which have to be selected additionally (there isn't a single trigger for each port).
Default list of USB ports to monitor can be specified using "trigger-sources" DT property. Theoretically it should be possible for Linux to deduce applicable trigger based on the references nodes in the "trigger-sources". It hasn't been implemented however (probably due to laziness).
Milk spilled - we already have DT files specifying "usbport" manually - allow that value in the binding. This fixes validation of in-kernel and external DT files.
Signed-off-by Rafał Miłecki <[email protected]>--- Documentation/devicetree/bindings/leds/common.yaml | 2 ++ 1 file changed, 2 insertions(+)
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Applied, thanks
it seems this PATCH got lost somewhere. Can you check it, please?
What makes you think that?
I have no idea. It seems all good. Sorry for the noise, brain fart.
Signature · 1 line
Rafał Miłecki