Skip to contentSkip to conversation

Staging: octeon: Fix line ending with '('

PATCH Superseded Sumitra Sharma 2 participants 3 messages Mar 16, 2023 – Mar 17, 2023 Staging

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 Staging: octeon: Fix line ending with '('

Since, the coding-style limit the code within 80 columns per line. This causes splitting the function header into two lines and results the first line ending with a '('. This causes the checkpatch error.

Place the function parameters immediately after '(' in a single line to align the function header.

---
v2: Change patch subject and description

v3: Change patch description, noted by Deepak R Varma <[email protected]>

drivers/staging/octeon/octeon-stubs.h | 4 +---

 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/octeon/octeon-stubs.h +1 -3
index 7a02e59e283f..3e7b92cd2e35 100644
@@ -1372,9 +1372,7 @@ static inline void cvmx_fau_async_fetch_and_add32(uint64_t scraddr,
 						  int32_t value)
 { }
 
-static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(
-	int interface,
-	int port)
+static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(int interface, int port)
 {
 	union cvmx_gmxx_rxx_rx_inbnd r;
 
Signature · 1 line
2.25.1
#1 lore raw
Quoted 3 lines · Sumitra Sharma

Since, the coding-style limit the code within 80 columns per line. This causes splitting the function header into two lines and results the first line ending with a '('. This causes the checkpatch error.

This should all be in the past tense: limited, caused, resulted, etc.

julia

Quoted 34 lines

Place the function parameters immediately after '(' in a single line to align the function header.

---
v2: Change patch subject and description

v3: Change patch description, noted by Deepak R Varma <[email protected]>

drivers/staging/octeon/octeon-stubs.h | 4 +---

 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/octeon/octeon-stubs.h +1 -4
index 7a02e59e283f..3e7b92cd2e35 100644
@@ -1372,9 +1372,7 @@ static inline void cvmx_fau_async_fetch_and_add32(uint64_t scraddr,
 						  int32_t value)
 { }
 
-static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(
-	int interface,
-	int port)
+static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(int interface, int port)
 {
 	union cvmx_gmxx_rxx_rx_inbnd r;
 
--

2.25.1

#2 lore raw
Quoted 10 lines · Julia Lawall
Quoted 3 lines · Sumitra Sharma

Since, the coding-style limit the code within 80 columns per line. This causes splitting the function header into two lines and results the first line ending with a '('. This causes the checkpatch error.

This should all be in the past tense: limited, caused, resulted, etc.

Thank you julia for the help.

Regards,

Sumitra

Quoted 36 lines

julia

Quoted 34 lines

Place the function parameters immediately after '(' in a single line to align the function header.

---
v2: Change patch subject and description

v3: Change patch description, noted by Deepak R Varma <[email protected]>

drivers/staging/octeon/octeon-stubs.h | 4 +---

 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/octeon/octeon-stubs.h +1 -4
index 7a02e59e283f..3e7b92cd2e35 100644
@@ -1372,9 +1372,7 @@ static inline void cvmx_fau_async_fetch_and_add32(uint64_t scraddr,
 						  int32_t value)
 { }
 
-static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(
-	int interface,
-	int port)
+static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(int interface, int port)
 {
 	union cvmx_gmxx_rxx_rx_inbnd r;
 
--

2.25.1