Skip to contentSkip to conversation

drm/kmb: remove unused set_test_mode_src_osc_freq_target_low,hi_bits functions

PATCH In review Tom Rix 2 participants 2 messages Mar 18, 2023 – Apr 7, 2023

Subsystems (2)
lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 drm/kmb: remove unused set_test_mode_src_osc_freq_target_low,hi_bits functions

clang with W=1 reports
drivers/gpu/drm/kmb/kmb_dsi.c:822:2: error: unused function
'set_test_mode_src_osc_freq_target_low_bits' [-Werror,-Wunused-function]
set_test_mode_src_osc_freq_target_low_bits(struct kmb_dsi *kmb_dsi, ^
drivers/gpu/drm/kmb/kmb_dsi.c:834:2: error: unused function
'set_test_mode_src_osc_freq_target_hi_bits' [-Werror,-Wunused-function]
set_test_mode_src_osc_freq_target_hi_bits(struct kmb_dsi *kmb_dsi, ^
These static functions are not used, so remove them.

---
 drivers/gpu/drm/kmb/kmb_dsi.c | 28 ----------------------------
 1 file changed, 28 deletions(-)
drivers/gpu/drm/kmb/kmb_dsi.c +0 -28
index cf7cf0b07541..ed99b14375aa 100644
@@ -818,34 +818,6 @@ static void test_mode_send(struct kmb_dsi *kmb_dsi, u32 dphy_no,
 	}
 }
 
-static inline void
-	set_test_mode_src_osc_freq_target_low_bits(struct kmb_dsi *kmb_dsi,
-						   u32 dphy_no,
-						   u32 freq)
-{
-	/* Typical rise/fall time=166, refer Table 1207 databook,
-	 * sr_osc_freq_target[7:0]
-	 */
-	test_mode_send(kmb_dsi, dphy_no, TEST_CODE_SLEW_RATE_DDL_CYCLES,
-		       (freq & 0x7f));
-}
-
-static inline void
-	set_test_mode_src_osc_freq_target_hi_bits(struct kmb_dsi *kmb_dsi,
-						  u32 dphy_no,
-						  u32 freq)
-{
-	u32 data;
-
-	/* Flag this as high nibble */
-	data = ((freq >> 6) & 0x1f) | (1 << 7);
-
-	/* Typical rise/fall time=166, refer Table 1207 databook,
-	 * sr_osc_freq_target[11:7]
-	 */
-	test_mode_send(kmb_dsi, dphy_no, TEST_CODE_SLEW_RATE_DDL_CYCLES, data);
-}
-
 static void mipi_tx_get_vco_params(struct vco_params *vco)
 {
 	int i;
Signature · 1 line
2.27.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 12 lines · Tom Rix

clang with W=1 reports
drivers/gpu/drm/kmb/kmb_dsi.c:822:2: error: unused function
'set_test_mode_src_osc_freq_target_low_bits' [-Werror,-Wunused-function]
set_test_mode_src_osc_freq_target_low_bits(struct kmb_dsi *kmb_dsi, ^
drivers/gpu/drm/kmb/kmb_dsi.c:834:2: error: unused function
'set_test_mode_src_osc_freq_target_hi_bits' [-Werror,-Wunused-function]
set_test_mode_src_osc_freq_target_hi_bits(struct kmb_dsi *kmb_dsi, ^
These static functions are not used, so remove them.

Quoted 1 line

Thanks for the patch!

Quoted 46 lines
---
 drivers/gpu/drm/kmb/kmb_dsi.c | 28 ----------------------------
 1 file changed, 28 deletions(-)
drivers/gpu/drm/kmb/kmb_dsi.c +0 -29
index cf7cf0b07541..ed99b14375aa 100644
@@ -818,34 +818,6 @@ static void test_mode_send(struct kmb_dsi *kmb_dsi, u32 dphy_no,
        }
 }
 
-static inline void
-       set_test_mode_src_osc_freq_target_low_bits(struct kmb_dsi *kmb_dsi,
-                                                  u32 dphy_no,
-                                                  u32 freq)
-{
-       /* Typical rise/fall time=166, refer Table 1207 databook,
-        * sr_osc_freq_target[7:0]
-        */
-       test_mode_send(kmb_dsi, dphy_no, TEST_CODE_SLEW_RATE_DDL_CYCLES,
-                      (freq & 0x7f));
-}
-
-static inline void
-       set_test_mode_src_osc_freq_target_hi_bits(struct kmb_dsi *kmb_dsi,
-                                                 u32 dphy_no,
-                                                 u32 freq)
-{
-       u32 data;
-
-       /* Flag this as high nibble */
-       data = ((freq >> 6) & 0x1f) | (1 << 7);
-
-       /* Typical rise/fall time=166, refer Table 1207 databook,
-        * sr_osc_freq_target[11:7]
-        */
-       test_mode_send(kmb_dsi, dphy_no, TEST_CODE_SLEW_RATE_DDL_CYCLES, data);
-}
-
 static void mipi_tx_get_vco_params(struct vco_params *vco)
 {
        int i;
--

2.27.0

Signature · 2 lines
Thanks,
~Nick Desaulniers