Skip to contentSkip to conversation

dt-bindings: mmc: fujitsu: Add Socionext Synquacer

PATCH In review Rob Herring 4 participants 4 messages Mar 19, 2023 – Mar 23, 2023

Subsystems (2)
Device tree bindings MMC, SD and SDIO
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH v2 1/1 dt-bindings: mmc: fujitsu: Add Socionext Synquacer

Add support for Socionext Synquacer SDHCI. This binding has been in use for some time.

The interrupts were not documented. The driver only uses the first interrupt, but the DT and example have 2 interrupts. The 2nd one is unknown. "dma-coherent" was also not documented, but is used on Synquacer.

Signed-off-by Rob Herring <[email protected]>

---
v2:
- Rebase on conversion done by Kunihiko

---
 .../bindings/mmc/fujitsu,sdhci-fujitsu.yaml       | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml +12 -3
index 73d747e917f3..430b62899397 100644
@@ -14,9 +14,13 @@ allOf:
 
 properties:
   compatible:
-    enum:
-      - fujitsu,mb86s70-sdhci-3.0
-      - socionext,f-sdh30-e51-mmc
+    oneOf:
+      - items:
+          - const: socionext,synquacer-sdhci
+          - const: fujitsu,mb86s70-sdhci-3.0
+      - enum:
+          - fujitsu,mb86s70-sdhci-3.0
+          - socionext,f-sdh30-e51-mmc
 
   reg:
     maxItems: 1

@@ -29,6 +33,11 @@ properties:
       - const: iface
       - const: core
 
+  dma-coherent: true
+
+  interrupts:
+    maxItems: 2
+
   resets:
     maxItems: 1
Signature · 1 line
2.39.2
Reviewed-by on v2 1/1
#1 lore raw
Quoted 8 lines · Rob Herring

Add support for Socionext Synquacer SDHCI. This binding has been in use for some time.

The interrupts were not documented. The driver only uses the first interrupt, but the DT and example have 2 interrupts. The 2nd one is unknown. "dma-coherent" was also not documented, but is used on Synquacer.

Signed-off-by Rob Herring <[email protected]>
Reviewed-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

Reviewed-by on v2 1/1
#2 lore raw
In reply to Rob Herring

Hi Rob,

Quoted 7 lines · Rob Herring

Add support for Socionext Synquacer SDHCI. This binding has been in use for
some time.

The interrupts were not documented. The driver only uses the first interrupt, but the DT and example have 2 interrupts. The 2nd one is unknown. "dma-coherent" was also not documented, but is used on Synquacer.

Surely "interrupts" is needed. The 2nd interrupt seems to come from the card, though, the driver isn't supported it.

Reviewed-by Kunihiko Hayashi <[email protected]>

Thank you,

Quoted 34 lines
Signed-off-by Rob Herring <[email protected]>

---
v2:
- Rebase on conversion done by Kunihiko

---
  .../bindings/mmc/fujitsu,sdhci-fujitsu.yaml       | 15 ++++++++++++---
  1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml b/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml index 73d747e917f3..430b62899397 100644

Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml +7 -3
@@ -14,9 +14,13 @@ allOf:
 
  properties:
    compatible:
-    enum:
-      - fujitsu,mb86s70-sdhci-3.0
-      - socionext,f-sdh30-e51-mmc
+    oneOf:
+      - items:
+          - const: socionext,synquacer-sdhci
+          - const: fujitsu,mb86s70-sdhci-3.0
+      - enum:
+          - fujitsu,mb86s70-sdhci-3.0
+          - socionext,f-sdh30-e51-mmc
 
    reg:
      maxItems: 1

@@ -29,6 +33,11 @@ properties:
        - const: iface

Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml properties: · line 43

Quoted 10 lines
Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml +5 -0
        - const: core
 
+  dma-coherent: true
+
+  interrupts:
+    maxItems: 2
+
    resets:
      maxItems: 1

---
Best Regards
Kunihiko Hayashi

#3 lore raw
In reply to Rob Herring
Quoted 9 lines · Rob Herring

Add support for Socionext Synquacer SDHCI. This binding has been in use for some time.

The interrupts were not documented. The driver only uses the first interrupt, but the DT and example have 2 interrupts. The 2nd one is unknown. "dma-coherent" was also not documented, but is used on Synquacer.

Signed-off-by Rob Herring <[email protected]>

Applied for next, thanks!

Kind regards
Uffe

Quoted 43 lines

---
v2:
- Rebase on conversion done by Kunihiko

---
 .../bindings/mmc/fujitsu,sdhci-fujitsu.yaml       | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml +12 -4
index 73d747e917f3..430b62899397 100644
@@ -14,9 +14,13 @@ allOf:
 
 properties:
   compatible:
-    enum:
-      - fujitsu,mb86s70-sdhci-3.0
-      - socionext,f-sdh30-e51-mmc
+    oneOf:
+      - items:
+          - const: socionext,synquacer-sdhci
+          - const: fujitsu,mb86s70-sdhci-3.0
+      - enum:
+          - fujitsu,mb86s70-sdhci-3.0
+          - socionext,f-sdh30-e51-mmc
 
   reg:
     maxItems: 1

@@ -29,6 +33,11 @@ properties:
       - const: iface
       - const: core
 
+  dma-coherent: true
+
+  interrupts:
+    maxItems: 2
+
   resets:
     maxItems: 1
 
--

2.39.2