Skip to contentSkip to conversation

m68k: Kconfig.machine: remove obsolete configs ROMBASE and ROMSIZE

PATCH In review Lukas Bulwahn 3 participants 3 messages Mar 20, 2023 – Mar 21, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 m68k: Kconfig.machine: remove obsolete configs ROMBASE and ROMSIZE

The configs ROMBASE and ROMSIZE were used in arch/m68k/68360/head-ram.S, which was removed with commit a3595962d824 ("m68knommu: remove obsolete 68360 support").

Remove the obsolete configs ROMBASE and ROMSIZE.

---
 arch/m68k/Kconfig.machine | 17 -----------------
 1 file changed, 17 deletions(-)
arch/m68k/Kconfig.machine +0 -17
index e2f961208f18..255d50574065 100644
@@ -439,15 +439,6 @@ config ROM
 	  that can be stored in flash, with possibly the text, and data
 	  regions being copied out to RAM at startup.
 
-config ROMBASE
-	hex "Address of the base of ROM device"
-	default "0"
-	depends on ROM
-	help
-	  Define the address that the ROM region starts at. Some platforms
-	  use this to set their chip select region accordingly for the boot
-	  device.
-
 config ROMVEC
 	hex "Address of the base of the ROM vectors"
 	default "0"
@@ -465,14 +456,6 @@ config ROMSTART
 	  Define the start address of the system image in ROM. Commonly this
 	  is strait after the ROM vectors.
 
-config ROMSIZE
-	hex "Size of the ROM device"
-	default "0x100000"
-	depends on ROM
-	help
-	  Size of the ROM device. On some platforms this is used to setup
-	  the chip select that controls the boot ROM device.
-
 choice
 	prompt "Kernel executes from"
 	help
Signature · 1 line
2.17.1
maintainer Reviewed-by on v1 1/1
#1 lore raw

CC Greg

Quoted 7 lines · Lukas Bulwahn

The configs ROMBASE and ROMSIZE were used in arch/m68k/68360/head-ram.S, which was removed with commit a3595962d824 ("m68knommu: remove obsolete 68360 support").

Remove the obsolete configs ROMBASE and ROMSIZE.

Fixes a3595962d82495f5 ("m68knommu: remove obsolete 68360 support")
Quoted 23 lines
arch/m68k/Kconfig.machine +0 -10
@@ -439,15 +439,6 @@ config ROM
          that can be stored in flash, with possibly the text, and data
          regions being copied out to RAM at startup.
 
-config ROMBASE
-       hex "Address of the base of ROM device"
-       default "0"
-       depends on ROM
-       help
-         Define the address that the ROM region starts at. Some platforms
-         use this to set their chip select region accordingly for the boot
-         device.
-
 config ROMVEC
        hex "Address of the base of the ROM vectors"
        default "0"
@@ -465,14 +456,6 @@ config ROMSTART
          Define the start address of the system image in ROM. Commonly this
          is strait after the ROM vectors.
 
-config ROMSIZE

arch/m68k/Kconfig.machine config ROMSTART · line 461

Quoted 10 lines
arch/m68k/Kconfig.machine +0 -7
-       hex "Size of the ROM device"
-       default "0x100000"
-       depends on ROM
-       help
-         Size of the ROM device. On some platforms this is used to setup
-         the chip select that controls the boot ROM device.
-
 choice
        prompt "Kernel executes from"
        help

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#2 lore raw
In reply to Lukas Bulwahn

Hi Lukas,

Quoted 7 lines · Lukas Bulwahn

The configs ROMBASE and ROMSIZE were used in arch/m68k/68360/head-ram.S, which was removed with commit a3595962d824 ("m68knommu: remove obsolete 68360 support").

Remove the obsolete configs ROMBASE and ROMSIZE.

Looks good thanks.

I have pushed this into the m68knommu git tree, for next branch, after adding Geerts Fixes and Reviewed-by tags.

Regards
Greg

Quoted 39 lines
---
  arch/m68k/Kconfig.machine | 17 -----------------
  1 file changed, 17 deletions(-)
arch/m68k/Kconfig.machine +0 -17
index e2f961208f18..255d50574065 100644
@@ -439,15 +439,6 @@ config ROM
  	  that can be stored in flash, with possibly the text, and data
  	  regions being copied out to RAM at startup.
 
-config ROMBASE
-	hex "Address of the base of ROM device"
-	default "0"
-	depends on ROM
-	help
-	  Define the address that the ROM region starts at. Some platforms
-	  use this to set their chip select region accordingly for the boot
-	  device.
-
  config ROMVEC
  	hex "Address of the base of the ROM vectors"
  	default "0"
@@ -465,14 +456,6 @@ config ROMSTART
  	  Define the start address of the system image in ROM. Commonly this
  	  is strait after the ROM vectors.
 
-config ROMSIZE
-	hex "Size of the ROM device"
-	default "0x100000"
-	depends on ROM
-	help
-	  Size of the ROM device. On some platforms this is used to setup
-	  the chip select that controls the boot ROM device.
-
  choice
  	prompt "Kernel executes from"
  	help