dmaengine: dw-edma: remove unused readq_ch and writeq_ch functions
Subsystems (2)
PATCH 1/1 dmaengine: dw-edma: remove unused readq_ch and writeq_ch functions
clang with W=1 reports drivers/dma/dw-edma/dw-edma-v0-core.c:162:20: error:
unused function 'writeq_ch' [-Werror,-Wunused-function]
static inline void writeq_ch(struct dw_edma *dw, enum dw_edma_dir dir, u16 ch,
^
drivers/dma/dw-edma/dw-edma-v0-core.c:185:19: error:
unused function 'readq_ch' [-Werror,-Wunused-function]
static inline u64 readq_ch(struct dw_edma *dw, enum dw_edma_dir dir, u16 ch,
^These functions and their wrapping macros are not used, so remove them.
Signed-off-by Tom Rix <[email protected]>
--- drivers/dma/dw-edma/dw-edma-v0-core.c | 56 --------------------------- 1 file changed, 56 deletions(-)
drivers/dma/dw-edma/dw-edma-v0-core.c +0 -56
@@ -159,62 +159,6 @@ static inline u32 readl_ch(struct dw_edma *dw, enum dw_edma_dir dir, u16 ch,#define GET_CH_32 (dw, dir, ch, name) \ readl_ch(dw, dir, ch, &(__dw_ch_regs(dw, dir, ch)->name)) -static inline void writeq_ch (struct dw_edma *dw,enum dw_edma_dir dir,u16 ch, -u64 value,void __iomem *addr) -{ -if (dw->chip->mf ==EDMA_MF_EDMA_LEGACY ) { -u32 viewport_sel; -unsigned long flags; - -raw_spin_lock_irqsave (&dw->lock, flags); - - viewport_sel =FIELD_PREP (EDMA_V0_VIEWPORT_MASK , ch); -if (dir ==EDMA_DIR_READ ) - viewport_sel |=BIT (31 ); - -writel (viewport_sel, - &(__dw_regs (dw)->type.legacy.viewport_sel)); -writeq (value, addr); - -raw_spin_unlock_irqrestore (&dw->lock, flags); - }else { -writeq (value, addr); - } -} - -static inline u64 readq_ch (struct dw_edma *dw,enum dw_edma_dir dir,u16 ch, -const void __iomem *addr) -{ -u64 value; - -if (dw->chip->mf ==EDMA_MF_EDMA_LEGACY ) { -u32 viewport_sel; -unsigned long flags; - -raw_spin_lock_irqsave (&dw->lock, flags); - - viewport_sel =FIELD_PREP (EDMA_V0_VIEWPORT_MASK , ch); -if (dir ==EDMA_DIR_READ ) - viewport_sel |=BIT (31 ); - -writel (viewport_sel, - &(__dw_regs (dw)->type.legacy.viewport_sel)); - value =readq (addr); - -raw_spin_unlock_irqrestore (&dw->lock, flags); - }else { - value =readq (addr); - } - -return value; -} - -#define SET_CH_64 (dw, dir, ch, name, value) \ - writeq_ch(dw, dir, ch, value, &(__dw_ch_regs(dw, dir, ch)->name)) - -#define GET_CH_64 (dw, dir, ch, name) \ - readq_ch(dw, dir, ch, &(__dw_ch_regs(dw, dir, ch)->name)) -/* eDMA management callbacks */ void dw_edma_v0_core_off (struct dw_edma *dw) {
Signature · 1 line
2.27.0
Quoted 10 lines · Tom Rix
clang with W=1 reports
drivers/dma/dw-edma/dw-edma-v0-core.c:162:20: error:
unused function 'writeq_ch' [-Werror,-Wunused-function]
static inline void writeq_ch(structdw_edma*dw, enumdw_edma_dirdir, u16 ch,^ drivers/dma/dw-edma/dw-edma-v0-core.c:185:19: error: unused function 'readq_ch' [-Werror,-Wunused-function] static inline u64 readq_ch(struct dw_edma *dw, enum dw_edma_dir dir, u16 ch, ^These functions and their wrapping macros are not used, so remove them.
Applied, thanks
Signature · 1 line
~Vinod