i915/i915_power: Also show requested and actual freq's
PATCH 1/1 i915/i915_power: Also show requested and actual freq's
When power limits are in effect, in addition to measured power it is also important to see the requested and actual freq's and see how they change with set power limits. Add this to the test output.
--- tests/i915/i915_power.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)
tests/i915/i915_power.c +10 -1
@@ -5,6 +5,7 @@#include "igt.h" #include "i915/gem.h" +#include "igt_sysfs.h" #include "igt_power.h" IGT_TEST_DESCRIPTION ("i915 power measurement tests" );
@@ -27,9 +28,13 @@ static void sanity(int i915)double idle, busy;igt_spin_t *spin;uint64_t ahnd; +int dir, req, act;#define DURATION_SEC 2 + dir =igt_sysfs_gt_open (i915,0 ); +igt_assert_lt (0 , dir); +/* Idle power */ igt_require (!igt_power_open (i915, &pwr,"gpu" ));gem_quiescent_gpu (i915);
@@ -44,12 +49,16 @@ static void sanity(int i915)/* Wait till at least one spinner starts */ igt_spin_busywait_until_started (spin); busy =measure_power (&pwr,DURATION_SEC ); + req =igt_sysfs_get_u32 (dir,"rps_cur_freq_mhz" ); + act =igt_sysfs_get_u32 (dir,"rps_act_freq_mhz" );igt_free_spins (i915);put_ahnd (ahnd);intel_ctx_destroy (i915, ctx);igt_power_close (&pwr); +close (dir); -igt_info ("Measured power: idle: %g mW, busy: %g mW\n" , idle, busy); +igt_info ("Measured power: idle: %g mW, busy: %g mW, req MHz: %d, act MHz: %d\n" , + idle, busy, req, act);igt_assert (idle >=0 && busy >0 && busy > idle); }
Signature · 1 line
2.38.0
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for i915/i915_power: Also show requested and actual freq's
== Series Details ==
== Series Details ==
Series: i915/i915_power: Also show requested and actual freq's
URL : https://patchwork.freedesktop.org/series/115428/
State : success
== Summary ==
CI Bug Log - changes from IGT_7209 -> IGTPW_8648
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/index.html
Participating hosts (35 -> 35)
------------------------------
Additional (1): fi-kbl-soraka
Missing (1): bat-dg1-6
Known issues
------------
Here are the changes found in IGTPW_8648 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/fi-kbl-soraka/igt@[email protected]
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/fi-kbl-soraka/igt@[email protected]
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][3] ([i915#1886])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@migrate:
- bat-adlp-9: [PASS][4] -> [DMESG-FAIL][5] ([i915#7699])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/bat-adlp-9/igt@i915_selftest@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/bat-adlp-9/igt@i915_selftest@[email protected]
* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][6] ([fdo#109271]) +16 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/fi-kbl-soraka/igt@[email protected]
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-rpls-1: NOTRUN -> [SKIP][7] ([i915#7828])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/bat-rpls-1/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-rpls-1: NOTRUN -> [SKIP][8] ([i915#1845])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/bat-rpls-1/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@migrate:
- bat-atsm-1: [DMESG-FAIL][9] ([i915#7699]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/bat-atsm-1/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/bat-atsm-1/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@reset:
- bat-rpls-1: [ABORT][11] ([i915#4983]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/bat-rpls-1/igt@i915_selftest@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/bat-rpls-1/igt@i915_selftest@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7209 -> IGTPW_8648
CI-20190529: 20190529
CI_DRM_12884: 1d4054731cfcb1cb9810d309b70535ae0b90ecf0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8648: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/index.html
IGT_7209: 9cd6680468031caae6b6c3626d7a461a9f09ba11 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/index.html
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for i915/i915_power: Also show requested and actual freq's
In reply to Ashutosh Dixit== Series Details ==
== Series Details ==
Series: i915/i915_power: Also show requested and actual freq's
URL : https://patchwork.freedesktop.org/series/115428/
State : success
== Summary ==
CI Bug Log - changes from IGT_7209_full -> IGTPW_8648_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/index.html
Participating hosts (7 -> 8)
------------------------------
Additional (1): shard-rkl0
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_8648_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@kms_ccs@pipe-d-crc-primary-rotation-180-4_tiled_dg2_rc_ccs_cc:
- {shard-rkl}: [SKIP][1] ([i915#4098]) -> [SKIP][2] +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-rkl-1/igt@kms_ccs@pipe-d-crc-primary-rotation-180-4_tiled_dg2_rc_ccs_cc.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-rkl-6/igt@kms_ccs@pipe-d-crc-primary-rotation-180-4_tiled_dg2_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_rc_ccs:
- {shard-rkl}: [SKIP][3] ([i915#1845] / [i915#4098]) -> [SKIP][4] +8 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-rkl-5/igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_rc_ccs.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-rkl-6/igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_rc_ccs.html
* igt@kms_plane@plane-panning-bottom-right-suspend:
- {shard-tglu}: NOTRUN -> [SKIP][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-tglu-9/igt@[email protected]
Known issues
------------
Here are the changes found in IGTPW_8648_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [PASS][6] -> [FAIL][7] ([i915#2842])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-apl1/igt@gem_exec_fair@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-apl6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-glk: [PASS][8] -> [FAIL][9] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-glk5/igt@gem_exec_fair@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-glk6/igt@gem_exec_fair@[email protected]
* igt@gem_lmem_swapping@heavy-multi:
- shard-apl: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#4613])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-apl1/igt@[email protected]
* igt@gem_userptr_blits@vma-merge:
- shard-apl: NOTRUN -> [FAIL][11] ([i915#3318])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-apl1/igt@[email protected]
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][12] -> [ABORT][13] ([i915#180]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-apl3/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-apl2/igt@[email protected]
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#3886]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-apl2/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_ccs:
- shard-apl: NOTRUN -> [SKIP][15] ([fdo#109271]) +47 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-apl3/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_ccs.html
* igt@kms_content_protection@legacy@pipe-a-dp-1:
- shard-apl: NOTRUN -> [TIMEOUT][16] ([i915#7173])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-apl6/igt@kms_content_protection@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [PASS][17] -> [FAIL][18] ([i915#2346])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-glk6/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-glk2/igt@[email protected]
* igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][19] -> [FAIL][20] ([i915#2122])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-glk1/igt@kms_flip@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-glk1/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@c-dp1:
- shard-apl: [PASS][21] -> [FAIL][22] ([i915#79])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-apl6/igt@kms_flip@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-apl3/igt@kms_flip@[email protected]
* igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1:
- shard-apl: [PASS][23] -> [FAIL][24] ([i915#1188])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-apl2/igt@kms_hdr@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-apl4/igt@kms_hdr@[email protected]
* igt@kms_plane_alpha_blend@constant-alpha-max@pipe-c-dp-1:
- shard-apl: NOTRUN -> [FAIL][25] ([i915#4573]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-apl4/igt@kms_plane_alpha_blend@[email protected]
* igt@kms_psr2_su@page_flip-nv12:
- shard-apl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#658])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-apl2/igt@kms_psr2_su@page_flip-nv12.html
#### Possible fixes ####
* igt@drm_fdinfo@virtual-idle:
- {shard-rkl}: [FAIL][27] ([i915#7742]) -> [PASS][28] +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-rkl-4/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-rkl-3/igt@[email protected]
* igt@fbdev@unaligned-read:
- {shard-rkl}: [SKIP][29] ([i915#2582]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-rkl-5/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-rkl-3/igt@[email protected]
* igt@feature_discovery@psr2:
- {shard-rkl}: [SKIP][31] ([i915#658]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-rkl-2/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-rkl-6/igt@[email protected]
* igt@gem_bad_reloc@negative-reloc:
- {shard-rkl}: [SKIP][33] ([i915#3281]) -> [PASS][34] +9 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-rkl-1/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-rkl-5/igt@[email protected]
* igt@gem_ctx_persistence@hang:
- {shard-rkl}: [SKIP][35] ([i915#6252]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-rkl-5/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-rkl-1/igt@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][37] ([i915#2846]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-glk2/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-glk4/igt@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][39] ([i915#2842]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-glk9/igt@gem_exec_fair@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-glk3/igt@gem_exec_fair@[email protected]
- {shard-rkl}: [FAIL][41] ([i915#2842]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-rkl-2/igt@gem_exec_fair@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-rkl-4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [FAIL][43] ([i915#2842]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-apl3/igt@gem_exec_fair@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-apl7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_whisper@basic-fds-priority-all:
- {shard-tglu}: [INCOMPLETE][45] ([i915#6755]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-tglu-3/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-tglu-2/igt@[email protected]
* igt@gem_partial_pwrite_pread@reads-uncached:
- {shard-rkl}: [SKIP][47] ([i915#3282]) -> [PASS][48] +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-rkl-3/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-rkl-5/igt@[email protected]
* igt@gen9_exec_parse@bb-start-out:
- {shard-rkl}: [SKIP][49] ([i915#2527]) -> [PASS][50] +3 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-rkl-4/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-rkl-5/igt@[email protected]
* igt@i915_pm_rpm@cursor-dpms:
- {shard-tglu}: [SKIP][51] ([i915#1849]) -> [PASS][52] +19 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-tglu-9/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-tglu-6/igt@[email protected]
- {shard-rkl}: [SKIP][53] ([i915#1849]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-rkl-5/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-rkl-6/igt@[email protected]
* igt@i915_pm_rpm@i2c:
- {shard-tglu}: [SKIP][55] ([i915#3547]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-tglu-9/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-tglu-4/igt@[email protected]
* igt@i915_pm_rpm@modeset-lpsp:
- {shard-tglu}: [SKIP][57] ([i915#1397]) -> [PASS][58] +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-tglu-10/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-tglu-2/igt@[email protected]
* igt@i915_pm_rpm@pm-tiling:
- {shard-rkl}: [SKIP][59] ([fdo#109308]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-rkl-4/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-rkl-6/igt@[email protected]
* igt@kms_atomic@atomic_plane_damage:
- {shard-rkl}: [SKIP][61] ([i915#4098]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-rkl-2/igt@kms_atomic@atomic_plane_damage.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-rkl-6/igt@kms_atomic@atomic_plane_damage.html
* igt@kms_big_fb@y-tiled-addfb-size-offset-overflow:
- {shard-rkl}: [SKIP][63] ([i915#1845] / [i915#4098]) -> [PASS][64] +18 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-rkl-2/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-rkl-6/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- {shard-tglu}: [SKIP][65] ([i915#1845]) -> [PASS][66] +50 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-tglu-10/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-tglu-4/igt@[email protected]
* igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs:
- {shard-tglu}: [SKIP][67] ([i915#1845] / [i915#7651]) -> [PASS][68] +21 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-tglu-9/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-tglu-3/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-apl: [FAIL][69] ([i915#2346]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-apl6/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-apl4/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-badstride:
- {shard-rkl}: [SKIP][71] ([i915#1849] / [i915#4098]) -> [PASS][72] +13 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-rkl-1/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-rkl-6/igt@[email protected]
* igt@kms_psr@cursor_render:
- {shard-rkl}: [SKIP][73] ([i915#1072]) -> [PASS][74] +3 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-rkl-4/igt@kms_psr@cursor_render.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-rkl-6/igt@kms_psr@cursor_render.html
* igt@kms_pwrite_crc:
- {shard-tglu}: [SKIP][75] ([fdo#109274] / [i915#1845]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-tglu-9/igt@kms_pwrite_crc.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-tglu-4/igt@kms_pwrite_crc.html
* igt@perf_pmu@idle@rcs0:
- {shard-rkl}: [FAIL][77] ([i915#4349]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-rkl-6/igt@perf_pmu@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-rkl-6/igt@perf_pmu@[email protected]
* igt@perf_pmu@render-node-busy-idle@vcs0:
- {shard-dg1}: [FAIL][79] ([i915#4349]) -> [PASS][80] +5 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-dg1-18/igt@perf_pmu@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-dg1-16/igt@perf_pmu@[email protected]
* igt@prime_vgem@basic-fence-flip:
- {shard-tglu}: [SKIP][81] ([fdo#109295]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-tglu-9/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-tglu-3/igt@[email protected]
* igt@prime_vgem@basic-write:
- {shard-rkl}: [SKIP][83] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-rkl-3/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-rkl-5/igt@[email protected]
* igt@sysfs_heartbeat_interval@precise@vecs0:
- {shard-rkl}: [FAIL][85] ([i915#1755]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7209/shard-rkl-4/igt@sysfs_heartbeat_interval@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/shard-rkl-1/igt@sysfs_heartbeat_interval@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3547]: https://gitlab.freedesktop.org/drm/intel/issues/3547
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3639]: https://gitlab.freedesktop.org/drm/intel/issues/3639
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6755]: https://gitlab.freedesktop.org/drm/intel/issues/6755
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7178]: https://gitlab.freedesktop.org/drm/intel/issues/7178
[i915#7330]: https://gitlab.freedesktop.org/drm/intel/issues/7330
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
[i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8152]: https://gitlab.freedesktop.org/drm/intel/issues/8152
[i915#8154]: https://gitlab.freedesktop.org/drm/intel/issues/8154
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8253]: https://gitlab.freedesktop.org/drm/intel/issues/8253
[i915#8282]: https://gitlab.freedesktop.org/drm/intel/issues/8282
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7209 -> IGTPW_8648
CI-20190529: 20190529
CI_DRM_12884: 1d4054731cfcb1cb9810d309b70535ae0b90ecf0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8648: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/index.html
IGT_7209: 9cd6680468031caae6b6c3626d7a461a9f09ba11 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8648/index.html
Quoted 22 lines · Ashutosh Dixit
When power limits are in effect, in addition to measured power it is also important to see the requested and actual freq's and see how they change with set power limits. Add this to the test output.
Signed-off-by Ashutosh Dixit <[email protected]>--- tests/i915/i915_power.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)tests/i915/i915_power.c +1
-0@@ -5,6 +5,7 @@#include "igt.h" #include "i915/gem.h" +#include "igt_sysfs.h" #include "igt_power.h" IGT_TEST_DESCRIPTION ("i915 power measurement tests" );
tests/i915/i915_power.c static void sanity(int i915) · line 37
Quoted 10 lines
tests/i915/i915_power.c +4
-0@@ -27,9 +28,13 @@ static void sanity(int i915)double idle, busy;igt_spin_t *spin;uint64_t ahnd; +int dir, req, act;#define DURATION_SEC 2 + dir =igt_sysfs_gt_open (i915,0 ); +igt_assert_lt (0 , dir); +
can be replaced with for_each_sysfs_gt_dirfd and making the test a dynamic subtest ?
Thanks
Riana Tauro
Quoted 21 lines
tests/i915/i915_power.c +5
-1/* Idle power */ igt_require (!igt_power_open (i915, &pwr,"gpu" ));gem_quiescent_gpu (i915);@@ -44,12 +49,16 @@ static void sanity(int i915)/* Wait till at least one spinner starts */ igt_spin_busywait_until_started (spin); busy =measure_power (&pwr,DURATION_SEC ); + req =igt_sysfs_get_u32 (dir,"rps_cur_freq_mhz" ); + act =igt_sysfs_get_u32 (dir,"rps_act_freq_mhz" );igt_free_spins (i915);put_ahnd (ahnd);intel_ctx_destroy (i915, ctx);igt_power_close (&pwr); +close (dir); -igt_info ("Measured power: idle: %g mW, busy: %g mW\n" , idle, busy); +igt_info ("Measured power: idle: %g mW, busy: %g mW, req MHz: %d, act MHz: %d\n" , + idle, busy, req, act);igt_assert (idle >=0 && busy >0 && busy > idle); }
Hi,
Quoted 12 lines · Riana Tauro
Quoted 9 lines · Ashutosh Dixit
When power limits are in effect, in addition to measured power it is also important to see the requested and actual freq's and see how they change with set power limits. Add this to the test output.
Signed-off-by Ashutosh Dixit <[email protected]>--- tests/i915/i915_power.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)
Quoted 8 lines
tests/i915/i915_power.c line 7
Quoted 8 lines
tests/i915/i915_power.c +1
-0@@ -5,6 +5,7 @@#include "igt.h" #include "i915/gem.h" +#include "igt_sysfs.h"
Please keep it in alphabetical order.
Quoted 14 lines
tests/i915/i915_power.c static void sanity(int i915) · line 35
Quoted 11 lines
tests/i915/i915_power.c +4
-0#include "igt_power.h" IGT_TEST_DESCRIPTION ("i915 power measurement tests" );@@ -27,9 +28,13 @@ static void sanity(int i915)double idle, busy;igt_spin_t *spin;uint64_t ahnd; +int dir, req, act;#define DURATION_SEC 2 + dir =igt_sysfs_gt_open (i915,0 ); +igt_assert_lt (0 , dir); +can be replaced with
for_each_sysfs_gt_dirfdand making the test a dynamic subtest ?
Quoted 3 lines
Thanks
Riana Tauro
I would prefer to keep it simple and have it as first step, then make it dynamic subtest with macro.
Regards,
Kamil
Quoted 19 lines
Quoted 19 lines
tests/i915/i915_power.c +5
-1/* Idle power */ igt_require (!igt_power_open (i915, &pwr,"gpu" ));gem_quiescent_gpu (i915);@@ -44,12 +49,16 @@ static void sanity(int i915)/* Wait till at least one spinner starts */ igt_spin_busywait_until_started (spin); busy =measure_power (&pwr,DURATION_SEC ); + req =igt_sysfs_get_u32 (dir,"rps_cur_freq_mhz" ); + act =igt_sysfs_get_u32 (dir,"rps_act_freq_mhz" );igt_free_spins (i915);put_ahnd (ahnd);intel_ctx_destroy (i915, ctx);igt_power_close (&pwr); +close (dir); -igt_info ("Measured power: idle: %g mW, busy: %g mW\n" , idle, busy); +igt_info ("Measured power: idle: %g mW, busy: %g mW, req MHz: %d, act MHz: %d\n" , + idle, busy, req, act);igt_assert (idle >=0 && busy >0 && busy > idle); }
Quoted 1 line · Kamil Konieczny
Hi Riana/Kamil,
Quoted 39 lines · Riana Tauro
Quoted 12 lines · Ashutosh Dixit
Quoted 9 lines
When power limits are in effect, in addition to measured power it is also important to see the requested and actual freq's and see how they change with set power limits. Add this to the test output.
Signed-off-by Ashutosh Dixit <[email protected]>--- tests/i915/i915_power.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)Quoted 8 lines
tests/i915/i915_power.c line 7
Quoted 8 lines
tests/i915/i915_power.c +1
-0@@ -5,6 +5,7 @@#include "igt.h" #include "i915/gem.h" +#include "igt_sysfs.h" Please keep it in alphabetical order.
Quoted 14 lines
tests/i915/i915_power.c static void sanity(int i915) · line 35
Quoted 11 lines
tests/i915/i915_power.c +4
-0#include "igt_power.h" IGT_TEST_DESCRIPTION ("i915 power measurement tests" );@@ -27,9 +28,13 @@ static void sanity(int i915)double idle, busy;igt_spin_t *spin;uint64_t ahnd; +int dir, req, act;#define DURATION_SEC 2 + dir =igt_sysfs_gt_open (i915,0 ); +igt_assert_lt (0 , dir); +can be replaced with
for_each_sysfs_gt_dirfdand making the test a dynamic subtest ?
Quoted 6 lines
Quoted 3 lines
Thanks
Riana TauroI would prefer to keep it simple and have it as first step, then make it dynamic subtest with macro.
Because the i915_power library only exposes device level (not gt level) power IMO it doesn't make sense to have per gt subtests.
But I agree that because we are scheduling spinners on all engines (and so all gt's) we should display power for all gt's. Specially when on platforms like MTL the render and media gt's have completely different operating freq's.
So I've followed this line or reasoning and posted a v2. I have also include Zbigniew's patch which contains i915_for_each_gt macro there.
Thanks.
--
Ashutosh
Quoted 55 lines · Ashutosh
Quoted 1 line · Kamil Konieczny
Hi Riana/Kamil,
Quoted 39 lines · Riana Tauro
Quoted 12 lines · Ashutosh Dixit
Quoted 9 lines
When power limits are in effect, in addition to measured power it is also important to see the requested and actual freq's and see how they change with set power limits. Add this to the test output.
Signed-off-by Ashutosh Dixit <[email protected]>--- tests/i915/i915_power.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)Quoted 8 lines
tests/i915/i915_power.c line 7
Quoted 8 lines
tests/i915/i915_power.c +1
-0@@ -5,6 +5,7 @@#include "igt.h" #include "i915/gem.h" +#include "igt_sysfs.h" Please keep it in alphabetical order.
Quoted 14 lines
tests/i915/i915_power.c static void sanity(int i915) · line 35
Quoted 11 lines
tests/i915/i915_power.c +4
-0#include "igt_power.h" IGT_TEST_DESCRIPTION ("i915 power measurement tests" );@@ -27,9 +28,13 @@ static void sanity(int i915)double idle, busy;igt_spin_t *spin;uint64_t ahnd; +int dir, req, act;#define DURATION_SEC 2 + dir =igt_sysfs_gt_open (i915,0 ); +igt_assert_lt (0 , dir); +can be replaced with
for_each_sysfs_gt_dirfdand making the test a dynamic subtest ?Quoted 6 lines
Quoted 3 lines
Thanks
Riana TauroI would prefer to keep it simple and have it as first step, then make it dynamic subtest with macro.
Because the
i915_powerlibrary only exposes device level (not gt level) power IMO it doesn't make sense to have per gt subtests.
Quoted 7 lines
But I agree that because we are scheduling spinners on all engines (and so all gt's) we should display power for all gt's. Specially when on platforms like MTL the render and media gt's have completely different operating freq's.
So I've followed this line or reasoning and posted a v2. I have also include Zbigniew's patch which contains
i915_for_each_gtmacro there.
Also, I forgot to mention, I am using this IGT (as mentioned in the commit description) to basically experiment with the PL1 power limit. Set a PL1 limit and see what the measured power and freq's are in response to that PL1 limit.
Quoted 4 lines
Thanks.
--
Ashutosh