Skip to contentSkip to conversation

ASoC: dt-bindings: ak5558: Convert to dtschema

PATCH Superseded Saalim Quadri 3 participants 5 messages Mar 21, 2023 – Mar 23, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: dt-bindings: ak5558: Convert to dtschema

Convert the AK5558 ADC audio codec bindings to DT schema.

---
 .../devicetree/bindings/sound/ak5558.txt      | 24 ---------
 .../devicetree/bindings/sound/ak5558.yaml     | 49 +++++++++++++++++++
 2 files changed, 49 insertions(+), 24 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/ak5558.txt
 create mode 100644 Documentation/devicetree/bindings/sound/ak5558.yaml
Documentation/devicetree/bindings/sound/ak5558.txt deleted +0 -24
deleted file mode 100644
index e28708db6686..000000000000
@@ -1,24 +0,0 @@
-AK5558 8 channel differential 32-bit delta-sigma ADC
-
-This device supports I2C mode only.
-
-Required properties:
-
-- compatible : "asahi-kasei,ak5558" or "asahi-kasei,ak5552".
-- reg : The I2C address of the device.
-
-Optional properties:
-
-- reset-gpios: A GPIO specifier for the power down & reset pin.
-- AVDD-supply: Analog power supply
-- DVDD-supply: Digital power supply
-
-Example:
-
-&i2c {
-	ak5558: adc@10 {
-		compatible = "asahi-kasei,ak5558";
-		reg = <0x10>;
-		reset-gpios = <&gpio1 10 GPIO_ACTIVE_LOW>;
-	};
-};
Documentation/devicetree/bindings/sound/ak5558.yaml new file +49 -0

49 lines not on this page · raw message

Signature · 1 line
2.34.1
#1 lore raw

Documentation/devicetree/bindings/sound/ak5558.yaml

Quoted 45 lines · Saalim Quadri

Convert the AK5558 ADC audio codec bindings to DT schema.

---
 .../devicetree/bindings/sound/ak5558.txt      | 24 ---------
 .../devicetree/bindings/sound/ak5558.yaml     | 49 +++++++++++++++++++
 2 files changed, 49 insertions(+), 24 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/ak5558.txt
 create mode 100644 Documentation/devicetree/bindings/sound/ak5558.yaml
Documentation/devicetree/bindings/sound/ak5558.txt deleted +0 -24
deleted file mode 100644
index e28708db6686..000000000000
@@ -1,24 +0,0 @@
-AK5558 8 channel differential 32-bit delta-sigma ADC
-
-This device supports I2C mode only.
-
-Required properties:
-
-- compatible : "asahi-kasei,ak5558" or "asahi-kasei,ak5552".
-- reg : The I2C address of the device.
-
-Optional properties:
-
-- reset-gpios: A GPIO specifier for the power down & reset pin.
-- AVDD-supply: Analog power supply
-- DVDD-supply: Digital power supply
-
-Example:
-
-&i2c {
-	ak5558: adc@10 {
-		compatible = "asahi-kasei,ak5558";
-		reg = <0x10>;
-		reset-gpios = <&gpio1 10 GPIO_ACTIVE_LOW>;
-	};
-};
Documentation/devicetree/bindings/sound/ak5558.yaml new file +0 -0
new file mode 100644
index 000000000000..90fd734daeec

Missing vendor prefix, so
asahi-kasei,ak5558.yaml

Documentation/devicetree/bindings/sound/ak5558.yaml line 7

Quoted 8 lines
Documentation/devicetree/bindings/sound/ak5558.yaml new file +7 -0
@@ -0,0 +1,49 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/ak5558.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: AK5558 ADC Device Tree Bindings

drop "Device Tree Bindings"

You dropped few pieces of device description. Why? Also ADC is very confusing.

Documentation/devicetree/bindings/sound/ak5558.yaml line 17

Quoted 10 lines
Documentation/devicetree/bindings/sound/ak5558.yaml new file +10 -0
+
+maintainers:
+  - Junichi Wakasugi <[email protected]>
+  - Mihai Serban <[email protected]>
+
+properties:
+  compatible:
+    enum:
+      - asahi-kasei,ak5558
+      - asahi-kasei,ak5552

Keep them ordered by name.

Documentation/devicetree/bindings/sound/ak5558.yaml line 21

Quoted 4 lines
Documentation/devicetree/bindings/sound/ak5558.yaml new file +4 -0
+
+  reg:
+    maxItems: 1
+    description: I2C address of the device.

Drop description, obvious.

Documentation/devicetree/bindings/sound/ak5558.yaml line 31

Quoted 10 lines
Documentation/devicetree/bindings/sound/ak5558.yaml new file +10 -0
+
+  avdd-supply:
+    description: A 1.8V supply that powers up the AVDD pin.
+
+  dvdd-supply:
+    description: A 1.2V supply that powers up the DVDD pin.
+
+  reset-gpios:
+    maxItems: 1
+

Best regards,
Krzysztof

#2 lore raw

PATCH v2 1/1 ASoC: dt-bindings: ak5558: Convert to dtschema

Convert the AK5558 ADC audio codec bindings to DT schema.

---
 .../devicetree/bindings/sound/ak5558.txt      | 24 ----------
 .../bindings/sound/asahi-kasei,ak5558.yaml    | 48 +++++++++++++++++++
 2 files changed, 48 insertions(+), 24 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/ak5558.txt
 create mode 100644 Documentation/devicetree/bindings/sound/asahi-kasei,ak5558.yaml
Documentation/devicetree/bindings/sound/ak5558.txt deleted +0 -24
deleted file mode 100644
index e28708db6686..000000000000
@@ -1,24 +0,0 @@
-AK5558 8 channel differential 32-bit delta-sigma ADC
-
-This device supports I2C mode only.
-
-Required properties:
-
-- compatible : "asahi-kasei,ak5558" or "asahi-kasei,ak5552".
-- reg : The I2C address of the device.
-
-Optional properties:
-
-- reset-gpios: A GPIO specifier for the power down & reset pin.
-- AVDD-supply: Analog power supply
-- DVDD-supply: Digital power supply
-
-Example:
-
-&i2c {
-	ak5558: adc@10 {
-		compatible = "asahi-kasei,ak5558";
-		reg = <0x10>;
-		reset-gpios = <&gpio1 10 GPIO_ACTIVE_LOW>;
-	};
-};
Documentation/devicetree/bindings/sound/asahi-kasei,ak5558.yaml new file +48 -0

48 lines not on this page · raw message

Signature · 1 line
2.34.1
maintainer
#4 lore raw
In reply to Saalim Quadri
Quoted 3 lines · Saalim Quadri

Convert the AK5558 ADC audio codec bindings to DT schema.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: dt-bindings: ak5558: Convert to dtschema

      commit: 829d78e3ea321eb4f4e93bc7b162b8cc6ed91ec7

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark