platform/chrome: cros_ec_typec: Add missing fwnode_handle_put()
A message that is not in the archive (sent off-list or not yet received): [email protected]
Guenter Roeck
Reviewed-byQuoted 7 lines · Liang He
In
cros_typec_init_ports(), we should addfwnode_handle_put()when break out of the iterationdevice_for_each_child_node()as it will automatically increase and decrease the refcounter.Fixes fdc6b21e2444 ("platform/chrome: Add Type C connector class driver")Signed-off-by Liang He <[email protected]>
Quoted 19 lines
--- drivers/platform/chrome/cros_ec_typec.c | 1 + 1 file changed, 1 insertion(+)drivers/platform/chrome/cros_ec_typec.c +1
-1@@ -443,6 +443,7 @@ static int cros_typec_init_ports(struct cros_typec_data *typec)return 0 ; unregister_ports: +fwnode_handle_put (fwnode);cros_unregister_ports (typec);return ret; } --2.25.1
Hi Liang He,
Can you please resend this patch? I don't see it in patchwork or the mailing list any more.
Thanks!
Quoted 26 lines · Liang He
In
cros_typec_init_ports(), we should addfwnode_handle_put()when break out of the iterationdevice_for_each_child_node()as it will automatically increase and decrease the refcounter.Fixes fdc6b21e2444 ("platform/chrome: Add Type C connector class driver")Signed-off-by Liang He <[email protected]>--- drivers/platform/chrome/cros_ec_typec.c | 1 + 1 file changed, 1 insertion(+)drivers/platform/chrome/cros_ec_typec.c +1
-1@@ -443,6 +443,7 @@ static int cros_typec_init_ports(struct cros_typec_data *typec)return 0 ; unregister_ports: +fwnode_handle_put (fwnode);cros_unregister_ports (typec);return ret; } --2.25.1
Quoted 7 lines · Prashant Malani
Hi Liang He,
Can you please resend this patch? I don't see it in patchwork or the mailing list any more.
Thanks!
I will resend now, thanks for your work on my patch.
Liang
Quoted 27 lines · Liang He
Quoted 26 lines
In
cros_typec_init_ports(), we should addfwnode_handle_put()when break out of the iterationdevice_for_each_child_node()as it will automatically increase and decrease the refcounter.Fixes fdc6b21e2444 ("platform/chrome: Add Type C connector class driver")Signed-off-by Liang He <[email protected]>--- drivers/platform/chrome/cros_ec_typec.c | 1 + 1 file changed, 1 insertion(+)drivers/platform/chrome/cros_ec_typec.c +1
-1@@ -443,6 +443,7 @@ static int cros_typec_init_ports(struct cros_typec_data *typec)return 0 ; unregister_ports: +fwnode_handle_put (fwnode);cros_unregister_ports (typec);return ret; } --2.25.1