Skip to contentSkip to conversation

dmaengine: tegra-apb: remove unused tdma_read function

PATCH Applied Tom Rix 3 participants 3 messages Mar 22, 2023 – Mar 31, 2023

Subsystems (3)
Tegra architecture support dmaengine Tegra DMA drivers
lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 dmaengine: tegra-apb: remove unused tdma_read function

clang with W=1 reports drivers/dma/tegra20-apb-dma.c:236:19: error: unused function
'tdma_read' [-Werror,-Wunused-function]
static inline u32 tdma_read(struct tegra_dma *tdma, u32 reg)

                  ^

This function is not used so remove it.

Signed-off-by Tom Rix <[email protected]>
---
 drivers/dma/tegra20-apb-dma.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/dma/tegra20-apb-dma.c +0 -5
index eaafcbe4ca94..cc6b91f48979 100644
@@ -233,11 +233,6 @@ static inline void tdma_write(struct tegra_dma *tdma, u32 reg, u32 val)
 	writel(val, tdma->base_addr + reg);
 }
 
-static inline u32 tdma_read(struct tegra_dma *tdma, u32 reg)
-{
-	return readl(tdma->base_addr + reg);
-}
-
 static inline void tdc_write(struct tegra_dma_channel *tdc,
 			     u32 reg, u32 val)
 {
Signature · 1 line
2.27.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 18 lines · Tom Rix

clang with W=1 reports drivers/dma/tegra20-apb-dma.c:236:19: error: unused function
'tdma_read' [-Werror,-Wunused-function]
static inline u32 tdma_read(struct tegra_dma *tdma, u32 reg)

                   ^

This function is not used so remove it.

Signed-off-by Tom Rix <[email protected]>
---
  drivers/dma/tegra20-apb-dma.c | 5 -----
  1 file changed, 5 deletions(-)
drivers/dma/tegra20-apb-dma.c +0 -0
index eaafcbe4ca94..cc6b91f48979 100644
@@ -233,11 +233,6 @@ static inline void tdma_write(struct tegra_dma *tdma, u32 reg, u32 val)
  	writel(val, tdma->base_addr + reg);

drivers/dma/tegra20-apb-dma.c static inline void tdma_write(struct tegra_dma *tdma, u32 reg, u32 val) · line 238

Quoted 10 lines
drivers/dma/tegra20-apb-dma.c +0 -5
  }
 
-static inline u32 tdma_read(struct tegra_dma *tdma, u32 reg)
-{
-	return readl(tdma->base_addr + reg);
-}
-
  static inline void tdc_write(struct tegra_dma_channel *tdc,
  			     u32 reg, u32 val)
  {

Thanks!

Reviewed-by Jon Hunter <[email protected]>

Jon

Signature · 1 line
nvpublic
maintainer Applied
#2 lore raw
In reply to Tom Rix
Quoted 6 lines · Tom Rix

clang with W=1 reports drivers/dma/tegra20-apb-dma.c:236:19: error: unused function
'tdma_read' [-Werror,-Wunused-function]
static inline u32 tdma_read(struct tegra_dma *tdma, u32 reg)

                  ^

This function is not used so remove it.

Applied, thanks

Signature · 1 line
~Vinod