mm: Be less noisy during memory hotplug
Subsystems (2)
PATCH 1/1 mm: Be less noisy during memory hotplug
Turn a pr_info() into a pr_debug() to prevent dmesg spamming on systems where memory hotplug is a frequent operation.
--- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/page_alloc.c +1 -1
@@ -6959,7 +6959,7 @@ void __ref memmap_init_zone_device(struct zone *zone, compound_nr_pages(altmap, pfns_per_compound)); } -pr_info ("%s initialised %lu pages in %ums\n" , __func__, +pr_debug ("%s initialised %lu pages in %ums\n" , __func__, nr_pages,jiffies_to_msecs (jiffies - start)); }
Signature · 12 lines
2.39.2 Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879
Quoted 5 lines · Tomas Krcka
Turn a
pr_info()into apr_debug()to prevent dmesg spamming on systems where memory hotplug is a frequent operation.Fixes 966cf44f637e ("mm: defer ZONE_DEVICE page initialization to the point where we init pgmap")
Fixes? I suggest top drop that tag here.
Quoted 11 lines
Suggested-by Jan H. Schönherr <[email protected]>Signed-off-by Tomas Krcka <[email protected]>--- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mm/page_alloc.c +0
-0
mm/page_alloc.c void __ref memmap_init_zone_device(struct zone *zone, · line 6965
Quoted 8 lines
mm/page_alloc.c +1
-1@@ -6959,7 +6959,7 @@ void __ref memmap_init_zone_device(struct zone *zone, compound_nr_pages(altmap, pfns_per_compound)); } -pr_info ("%s initialised %lu pages in %ums\n" , __func__, +pr_debug ("%s initialised %lu pages in %ums\n" , __func__, nr_pages,jiffies_to_msecs (jiffies - start)); }
Signature · 3 lines
Thanks, David / dhildenb
PATCH v2 1/1 mm: Be less noisy during memory hotplug
Turn a pr_info() into a pr_debug() to prevent dmesg spamming on systems where memory hotplug is a frequent operation.
--- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/page_alloc.c +1 -1
@@ -6959,7 +6959,7 @@ void __ref memmap_init_zone_device(struct zone *zone, compound_nr_pages(altmap, pfns_per_compound)); } -pr_info ("%s initialised %lu pages in %ums\n" , __func__, +pr_debug ("%s initialised %lu pages in %ums\n" , __func__, nr_pages,jiffies_to_msecs (jiffies - start)); }
Signature · 12 lines
2.39.2 Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879
Quoted 8 lines · Tomas Krcka
Turn a
pr_info()into apr_debug()to prevent dmesg spamming on systems where memory hotplug is a frequent operation.Fixes 966cf44f637e ("mm: defer ZONE_DEVICE page initialization to the point where we init pgmap")Suggested-by Jan H. Schönherr <[email protected]>Signed-off-by Tomas Krcka <[email protected]>
Quoted 6 lines · Pasha Tatashin
Quoted 4 lines · Tomas Krcka
Turn a
pr_info()into apr_debug()to prevent dmesg spamming on systems where memory hotplug is a frequent operation.
Quoted 6 lines
Quoted 4 lines
Fixes 966cf44f637e ("mm: defer ZONE_DEVICE page initialization to the point where we init pgmap")Suggested-by Jan H. Schönherr <[email protected]>Signed-off-by Tomas Krcka <[email protected]>Reviewed-by Pasha Tatashin <[email protected]>
Can you please specify what you mean by frequent hotplug: wow frequent is it and what is the usecase?
Thanks,
Pasha
Quoted 15 lines · Pasha Tatashin
Quoted 8 lines · Pasha Tatashin
Quoted 6 lines · Tomas Krcka
Turn a
pr_info()into apr_debug()to prevent dmesg spamming on systems where memory hotplug is a frequent operation.Fixes 966cf44f637e ("mm: defer ZONE_DEVICE page initialization to the point where we init pgmap")
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Suggested-by Jan H. Schönherr <[email protected]>Signed-off-by Tomas Krcka <[email protected]>Reviewed-by Pasha Tatashin <[email protected]>Can you please specify what you mean by frequent hotplug: wow frequent is it and what is the usecase?
The use case is virtualization environment, case like new virtual machines are spun up and shut down frequently and where the workload of the virtual machines varies widely over time. So specially in case of small virtual machines. We can talk about multiple times per hour, depends on the workload.
Quoted 3 lines
Thanks,
Pasha
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879