transport-pci: msix summary update

PATCH In review Parav Pandit 5 participants 12 messages Mar 24, 2023 – Apr 4, 2023

lore

Share & tools

lore

Parav Pandit

author

2023-03-24 01:36 UTC #0 lore raw

cover transport-pci: msix summary update

Summary for config_msix_vector and queue_msix_vector registers have a confusing text of "for MSI-X".

Rewrite the register summary line.

Patch summary:
patch 1 removes empty line at the end of the file
patch 2 updates configuration vector summary
patch 3 updates queue vector summary

These are only editorial changes to rewrite the summary. Hence it should not require a github issue.

Parav Pandit (3):
transport-pci: Remove empty line at end of file
transport-pci: Improve config msix vector description
transport-pci: Improve queue msix vector register desc

 transport-pci.tex | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Signature · 18 lines

2.26.2


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

Parav Pandit

author

2023-03-24 01:36 UTC #1 lore raw

PATCH 1/3 transport-pci: Remove empty line at end of file

Remove empty line at end of file.

Signed-off-by Parav Pandit <[email protected]>

---
 transport-pci.tex | 1 -
 1 file changed, 1 deletion(-)

transport-pci.tex +0 -1

index 044c085..6e0cb45 100644
@@ -1148,4 +1148,3 @@ \subsubsection{Driver Handling Interrupts}\label{sec:Virtio Transport Options /
         re-examine the configuration space to see what changed.
     \end{itemize}
 \end{itemize}
-

Signature · 18 lines

2.26.2


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

David Edmondson

Reviewed-by on v1 1/3

2023-03-27 14:57 UTC #2 lore raw

Re: [virtio-comment] [PATCH 1/3] transport-pci: Remove empty line at end of file

Quoted 3 lines · Parav Pandit

Remove empty line at end of file.
Signed-off-by Parav Pandit <[email protected]>

Reviewed-by David Edmondson <[email protected]>

Quoted 32 lines

---
 transport-pci.tex | 1 -
 1 file changed, 1 deletion(-)

transport-pci.tex +0 -1

index 044c085..6e0cb45 100644
@@ -1148,4 +1148,3 @@ \subsubsection{Driver Handling Interrupts}\label{sec:Virtio Transport Options /
         re-examine the configuration space to see what changed.
     \end{itemize}
 \end{itemize}
-

Signature · 18 lines

2.26.2


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

Signature · 17 lines

You bring light in.

This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

Michael S. Tsirkin

2023-04-04 07:22 UTC #3 lore raw

[virtio-comment] Re: [PATCH 1/3] transport-pci: Remove empty line at end of file

In reply to Parav Pandit

Quoted 3 lines · Parav Pandit

Remove empty line at end of file.
Signed-off-by Parav Pandit <[email protected]>

Applied this one.

Quoted 15 lines

---
 transport-pci.tex | 1 -
 1 file changed, 1 deletion(-)

transport-pci.tex +0 -1

index 044c085..6e0cb45 100644
@@ -1148,4 +1148,3 @@ \subsubsection{Driver Handling Interrupts}\label{sec:Virtio Transport Options /
         re-examine the configuration space to see what changed.
     \end{itemize}
 \end{itemize}
-

Signature · 1 line

2.26.2

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

Parav Pandit

author

2023-03-24 01:36 UTC #4 lore raw

PATCH 2/3 transport-pci: Improve config msix vector description

In reply to Parav Pandit

config_msix_vector is the register that holds the MSI-X vector number for receiving configuration change related interrupts.

It is not "for MSI-X".

Hence, replace the confusing text with appropriate one.

Reviewed-by Max Gurtovoy <[email protected]>

Signed-off-by Parav Pandit <[email protected]>

---
 transport-pci.tex | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

transport-pci.tex +2 -1

index 6e0cb45..1bc89b4 100644
@@ -343,7 +343,8 @@ \subsubsection{Common configuration structure layout}\label{sec:Virtio Transport
         Driver Feature Bits selected by \field{driver_feature_select}.
 
 \item[\field{config_msix_vector}]
-        The driver sets the Configuration Vector for MSI-X.
+        The driver writes an MSI-X vector number for receiving
+        Configuration change interrupts.
 
 \item[\field{num_queues}]
         The device specifies the maximum number of virtqueues supported here.

Signature · 6 lines

2.26.2


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Parav Pandit

author

2023-03-24 01:36 UTC #5 lore raw

PATCH 3/3 transport-pci: Improve queue msix vector register desc

In reply to Parav Pandit

queue_msix_vector register is for receiving interrupts from the device for the virtqueue.

"for MSI-X" is confusing term.

Also it is the register that driver "writes" to, similar to many other registers such as queue_desc, queue_driver etc.

Hence, replace the verb from use to write.

Signed-off-by Parav Pandit <[email protected]>

Reviewed-by Max Gurtovoy <[email protected]>

---
 transport-pci.tex | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

transport-pci.tex +2 -1

index 1bc89b4..9d492d5 100644
@@ -367,7 +367,8 @@ \subsubsection{Common configuration structure layout}\label{sec:Virtio Transport
         A 0 means the queue is unavailable.
 
 \item[\field{queue_msix_vector}]
-        The driver uses this to specify the queue vector for MSI-X.
+        The driver writes an MSI-X vector number for receiving
+        virtqueue interrupts.
 
 \item[\field{queue_enable}]
         The driver uses this to selectively prevent the device from executing requests from this virtqueue.

Signature · 18 lines

2.26.2


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

Michael S. Tsirkin

2023-04-04 07:21 UTC #6 lore raw

[virtio-comment] Re: [PATCH 3/3] transport-pci: Improve queue msix vector register desc

Quoted 21 lines · Parav Pandit

queue_msix_vector register is for receiving interrupts from the device for the virtqueue.
"for MSI-X" is confusing term.
Also it is the register that driver "writes" to, similar to many other registers such as queue_desc, queue_driver etc.
Hence, replace the verb from use to write.
Signed-off-by Parav Pandit <[email protected]>
Reviewed-by Max Gurtovoy <[email protected]>
---
 transport-pci.tex | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
transport-pci.tex +0 -0
index 1bc89b4..9d492d5 100644

transport-pci.tex \subsubsection{Common configuration structure layout}\label{sec:Virtio Transport · line 371

Quoted 6 lines

transport-pci.tex +2 -1

@@ -367,7 +367,8 @@ \subsubsection{Common configuration structure layout}\label{sec:Virtio Transport
         A 0 means the queue is unavailable.
 
 \item[\field{queue_msix_vector}]
-        The driver uses this to specify the queue vector for MSI-X.
+        The driver writes an MSI-X vector number for receiving
+        virtqueue interrupts.

Ok but "receiving" is confusing here. And the verb writes seems to ask for direction, look at queue_desc as an example.

Following that example:

The driver writes the MSI-X vector number used for virtqueue interrupts here.

would you agree?

Quoted 4 lines

transport-pci.tex +0 -0

 \item[\field{queue_enable}]
         The driver uses this to selectively prevent the device from executing requests from this virtqueue.

Signature · 1 line

2.26.2

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]

Parav Pandit

author

2023-04-04 18:14 UTC #7 lore raw

[virtio-comment] RE: [PATCH 3/3] transport-pci: Improve queue msix vector register desc

Quoted 7 lines

From: Michael S. Tsirkin <[email protected]>
Sent: Tuesday, April 4, 2023 3:21 AM
Ok but "receiving" is confusing here. And the verb writes seems to ask for direction, look at queue_desc as an example.

What is the confusion in receiving?
Driver some reason is configuring queue's vector even if it doesn't want to "receive" interrupts? Do you mean it is more verbose?

Word here "here" isn't necessary when describing the register itself, though it exists at other places.

Quoted 5 lines

Following that example:
The driver writes the MSI-X vector number used for virtqueue
interrupts here.

Since a specific number is used here, article "an" is appropriate one.

Quoted 1 line

would you agree?

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Michael S. Tsirkin

2023-04-04 19:08 UTC #8 lore raw

[virtio-comment] Re: [PATCH 3/3] transport-pci: Improve queue msix vector register desc

Quoted 10 lines · Parav Pandit

Quoted 7 lines
From: Michael S. Tsirkin <[email protected]>
Sent: Tuesday, April 4, 2023 3:21 AM
Ok but "receiving" is confusing here. And the verb writes seems to ask for direction, look at queue_desc as an example.
What is the confusion in receiving?
Driver some reason is configuring queue's vector even if it doesn't want to "receive" interrupts? Do you mean it is more verbose?

I mean driver does not even receive interrupts, APIC does.

Quoted 1 line

Word here "here" isn't necessary when describing the register itself, though it exists at other places.

if nothing else let's be consistent. without here it is not immediately clear weather it's the register that is written to or the value specified is written somewhere else.

Quoted 6 lines

Quoted 5 lines
Following that example:
The driver writes the MSI-X vector number used for virtqueue
interrupts here.
Since a specific number is used here, article "an" is appropriate one.

No because it's the specific value used for interrupts. Again, check other examples.

Quoted 1 line

Quoted 1 line
would you agree?

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Xuan Zhuo

Reviewed-by on the v1 series

2023-03-27 06:10 UTC #9 lore raw

In reply to Parav Pandit

Series:

Reviewed-by Xuan Zhuo <[email protected]>

Quoted 32 lines · Parav Pandit

Summary for config_msix_vector and queue_msix_vector registers have a confusing text of "for MSI-X".
Rewrite the register summary line.
Patch summary:
patch 1 removes empty line at the end of the file
patch 2 updates configuration vector summary
patch 3 updates queue vector summary
These are only editorial changes to rewrite the summary. Hence it should not require a github issue.
Parav Pandit (3):
transport-pci: Remove empty line at end of file
transport-pci: Improve config msix vector description
transport-pci: Improve queue msix vector register desc
 transport-pci.tex | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
--
2.26.2
This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Quoted 9 lines

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Parav Pandit

author

2023-04-03 22:39 UTC #10 lore raw

Hi Cornelia,

Quoted 6 lines

From: Xuan Zhuo <[email protected]>
Sent: Monday, March 27, 2023 2:09 AM
Series:
Reviewed-by Xuan Zhuo <[email protected]>

It is editorial change rewording the text.
Can you please take this short series forward?

Quoted 32 lines · Parav Pandit

Quoted 31 lines
Summary for config_msix_vector and queue_msix_vector registers have a confusing text of "for MSI-X".
Rewrite the register summary line.
Patch summary:
patch 1 removes empty line at the end of the file patch 2 updates configuration vector summary patch 3 updates queue vector summary
These are only editorial changes to rewrite the summary. Hence it should not require a github issue.
Parav Pandit (3):
transport-pci: Remove empty line at end of file
transport-pci: Improve config msix vector description
transport-pci: Improve queue msix vector register desc
 transport-pci.tex | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
--
2.26.2
This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Quoted 11 lines

Quoted 11 lines
Subscribe: [email protected]
Unsubscribe: [email protected] List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License:
https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines:
https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Cornelia Huck

2023-04-04 08:28 UTC #11 lore raw

Quoted 11 lines · Parav Pandit

Hi Cornelia,
Quoted 6 lines
From: Xuan Zhuo <[email protected]>
Sent: Monday, March 27, 2023 2:09 AM
Series:
Reviewed-by Xuan Zhuo <[email protected]>
It is editorial change rewording the text.
Can you please take this short series forward?

Patch 1 (which Michael has already pushed) is editorial; for the other two patches, I'm not that sure, especially as there still seems to be some discussion?

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]