device property: Constify a few fwnode APIs
Subsystems (3)
Andy Shevchenko
reviewerPATCH 1/1 device property: Constify a few fwnode APIs
The fwnode parameter is not altered in the following APIs:
- fwnode_get_next_parent_dev()
- fwnode_is_ancestor_of()
- fwnode_graph_get_endpoint_count()
so constify them.
Reported-by Russell King (Oracle) <[email protected]>
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/base/property.c | 6 +++--- include/linux/property.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)
drivers/base/property.c +3 -3
@@ -648,7 +648,7 @@ EXPORT_SYMBOL_GPL(fwnode_get_next_parent);* * Return: a pointer to the device of the @fwnode's closest ancestor. */ -struct device *fwnode_get_next_parent_dev (struct fwnode_handle *fwnode) +struct device *fwnode_get_next_parent_dev (const struct fwnode_handle *fwnode) {struct fwnode_handle *parent;struct device *dev;
@@ -718,7 +718,7 @@ EXPORT_SYMBOL_GPL(fwnode_get_nth_parent);* * Return: true if @ancestor is an ancestor of @child. Otherwise, returns false. */ -bool fwnode_is_ancestor_of (struct fwnode_handle *ancestor,struct fwnode_handle *child) +bool fwnode_is_ancestor_of (const struct fwnode_handle *ancestor,const struct fwnode_handle *child) {struct fwnode_handle *parent;
@@ -1235,7 +1235,7 @@ EXPORT_SYMBOL_GPL(fwnode_graph_get_endpoint_by_id);* If FWNODE_GRAPH_DEVICE_DISABLED flag is specified, also unconnected endpoints * and endpoints connected to disabled devices are counted. */ -unsigned int fwnode_graph_get_endpoint_count (struct fwnode_handle *fwnode, +unsigned int fwnode_graph_get_endpoint_count (const struct fwnode_handle *fwnode,unsigned long flags) {struct fwnode_handle *ep;
include/linux/property.h +3 -3
@@ -104,11 +104,11 @@ struct fwnode_handle *fwnode_get_next_parent(struct fwnode_handle *fwnode);for (parent =fwnode_get_parent (fwnode); parent; \ parent =fwnode_get_next_parent (parent)) -struct device *fwnode_get_next_parent_dev(struct fwnode_handle *fwnode); +struct device *fwnode_get_next_parent_dev(const struct fwnode_handle *fwnode);unsigned int fwnode_count_parents (const struct fwnode_handle *fwn);struct fwnode_handle *fwnode_get_nth_parent (struct fwnode_handle *fwn,unsigned int depth); -bool fwnode_is_ancestor_of (struct fwnode_handle *ancestor,struct fwnode_handle *child); +bool fwnode_is_ancestor_of (const struct fwnode_handle *ancestor,const struct fwnode_handle *child);struct fwnode_handle *fwnode_get_next_child_node (const struct fwnode_handle *fwnode,struct fwnode_handle *child); struct fwnode_handle *fwnode_get_next_available_child_node(
@@ -432,7 +432,7 @@ static inline bool fwnode_graph_is_endpoint(const struct fwnode_handle *fwnode)struct fwnode_handle *fwnode_graph_get_endpoint_by_id (const struct fwnode_handle *fwnode,u32 port,u32 endpoint,unsigned long flags); -unsigned int fwnode_graph_get_endpoint_count (struct fwnode_handle *fwnode, +unsigned int fwnode_graph_get_endpoint_count (const struct fwnode_handle *fwnode,unsigned long flags);#define fwnode_graph_for_each_endpoint (fwnode, child) \
Signature · 1 line
2.40.0.1.gaa8946217a0b
Quoted 10 lines · Andy Shevchenko
The fwnode parameter is not altered in the following APIs:
-
fwnode_get_next_parent_dev()
-fwnode_is_ancestor_of()
-fwnode_graph_get_endpoint_count()so constify them.
Reported-by Russell King (Oracle) <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>
Thanks, Andy!
Reviewed-by Sakari Ailus <[email protected]>
Signature · 1 line
Sakari Ailus