: staging: wlan-ng: Remove unnecessary Parentheses
PATCH 1/1 : staging: wlan-ng: Remove unnecessary Parentheses
Clean up Checkpatch issues by removing unnecessary Parentheses.
Signed-off-by Dalvin-Ehinoma Noah Aiguobas <[email protected]>
--- drivers/staging/wlan-ng/cfg80211.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/wlan-ng/cfg80211.c +6 -6
@@ -247,7 +247,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,memset (sinfo,0 ,sizeof (*sinfo)); -if (!wlandev || (wlandev->msdstate !=WLAN_MSD_RUNNING )) +if (!wlandev || wlandev->msdstate !=WLAN_MSD_RUNNING )return -EOPNOTSUPP ;/* build request message */
@@ -351,8 +351,8 @@ static int prism2_scan(struct wiphy *wiphy, msg2->bssindex.data = i; result =p80211req_dorequest (wlandev, (u8 *)&msg2); -if ((result !=0 ) || - (msg2->resultcode.data != P80211ENUM_resultcode_success)) { +if (result !=0 || + msg2->resultcode.data != P80211ENUM_resultcode_success) {break ; }
@@ -459,8 +459,8 @@ static int prism2_connect(struct wiphy *wiphy, struct net_device *dev, }/* Set the authorization */ -if ((sme->auth_type ==NL80211_AUTHTYPE_OPEN_SYSTEM ) || - ((sme->auth_type ==NL80211_AUTHTYPE_AUTOMATIC ) && !is_wep)) +if (sme->auth_type ==NL80211_AUTHTYPE_OPEN_SYSTEM || + (sme->auth_type ==NL80211_AUTHTYPE_AUTOMATIC && !is_wep)) msg_join.authtype.data = P80211ENUM_authalg_opensystem;else if ((sme->auth_type ==NL80211_AUTHTYPE_SHARED_KEY ) || ((sme->auth_type ==NL80211_AUTHTYPE_AUTOMATIC ) && is_wep))
@@ -478,7 +478,7 @@ static int prism2_connect(struct wiphy *wiphy, struct net_device *dev, result =prism2_domibset_uint32 (wlandev,DIDMIB_DOT11SMT_PRIVACYTABLE_WEPDEFAULTKEYID , - sme->key_idx); + sme->key_idx);if (result) goto exit;
Signature · 1 line
2.25.1
The subject has an extra : after the "[PATCH]:".
Quoted 2 lines · Dalvin-Ehinoma Noah Aiguobas
Clean up Checkpatch issues by removing unnecessary Parentheses.
Just ignore checkpatch on this. Greg likes parentheses.
drivers/staging/wlan-ng/cfg80211.c static int prism2_connect(struct wiphy *wiphy, struct net_device *dev, · line 481
Quoted 6 lines
drivers/staging/wlan-ng/cfg80211.c +1
-1@@ -478,7 +478,7 @@ static int prism2_connect(struct wiphy *wiphy, struct net_device *dev, result =prism2_domibset_uint32 (wlandev,DIDMIB_DOT11SMT_PRIVACYTABLE_WEPDEFAULTKEYID , - sme->key_idx); + sme->key_idx);
Don't mix unrelated changes into the patch.
regards,
dan carpenter