Skip to contentSkip to conversation

Miscellaneous cleanups and fixes for i.MX media drivers

GIT PULL Laurent Pinchart 2 participants 2 messages Mar 25, 2023 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hi Mauro,

The following changes since commit 71937240a472ee551ac8de0e7429b9d49884a388:

media: ov2685: Select VIDEO_V4L2_SUBDEV_API (2023-03-20 16:32:18 +0100)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux.git tags/media-imx-next-20230325

for you to fetch changes up to 1f1863b6ca3c12c50407e728d12060f81f6c108c:

staging: media: imx: Make imx_media_of_add_csi() static (2023-03-25 20:36:10 +0200)

----------------------------------------------------------------
Miscellaneous cleanups and fixes for i.MX media drivers

----------------------------------------------------------------
Alexander Stein (2):
media: imx: imx7-media-csi: Fix mbus framefmt field init
media: imx: imx7-media-csi: Fail on invalid type in VIDIOC_G_SELECTION

Frieder Schrempf (1):
media: imx: imx7-media-csi: Fix error handling in imx7_csi_async_register()

Laurent Pinchart (4):
staging: media: imx: Drop imx_media_subdev_bound()
staging: media: imx: Drop IMX_MEDIA_GRP_ID_CSI
staging: media: imx: Drop unused helper functions
staging: media: imx: Make imx_media_of_add_csi() static

Martin Kepplinger (2):
media: imx: imx8mq-mipi-csi2: Use V4L2 subdev active state
media: imx: imx8mq-mipi-csi2: Remove unneeded state variable and function

 drivers/media/platform/nxp/imx7-media-csi.c      |  27 ++--
 drivers/staging/media/imx/imx-media-dev-common.c |  14 ---
 drivers/staging/media/imx/imx-media-of.c         |   5 +-
 drivers/staging/media/imx/imx-media-utils.c      |  68 ----------
 drivers/staging/media/imx/imx-media.h            |  13 --
 drivers/staging/media/imx/imx8mq-mipi-csi2.c     | 152 +++++++++--------------
 6 files changed, 77 insertions(+), 202 deletions(-)
Signature · 3 lines
Regards,

Laurent Pinchart
#1 lore raw

Re: [GIT PULL FOR v6.4] Miscellaneous cleanups and fixes for i.MX media (#90678)

From: [email protected]

Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/
Build log: https://builder.linuxtv.org/job/patchwork/292335/
Build time: 00:22:01

gpg: Signature made Sat 25 Mar 2023 06:40:10 PM UTC
gpg:                using EDDSA key C09EF871B3827B413F971CA9CC3F2D800327DE64
gpg:                issuer "[email protected]"
gpg: Can't check signature: No public key

Summary: got 1/9 patches with issues, being 1 at build time, plus one error when buinding PDF document

Error/warnings:

patches/0001-media-imx-imx7-media-csi-Fix-error-handling-in-imx7_.patch:

allyesconfig: return code #0:
../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples ../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:415 ov2680_s_stream() warn: missing error code 'ret' ../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3357 atomisp_cp_dvs_6axis_config() warn: missing unwind goto? ../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3456 atomisp_cp_morph_table() warn: missing unwind goto?

allyesconfig: return code #0:
../drivers/media/i2c/adp1653.c: ../drivers/media/i2c/adp1653.c:444 adp1653_of_init() warn: missing unwind goto? SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures ../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c: ../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:2490 mxc_jpeg_probe() warn: missing unwind goto? ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3293 pvr2_hdw_get_tuner_status() warn: inconsistent indenting ../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2864 em28xx_v4l2_init() parse error: turning off implications after 60 seconds ../drivers/media/i2c/ov5645.c: ../drivers/media/i2c/ov5645.c:687 ov5645_set_power_on() warn: 'ov5645->xclk' from clk_prepare_enable() not released on lines: 687. ../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() parse error: OOM: 3000016Kb sm_state_count = 1974618 ../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() warn: Function too hairy. No more merges. ../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() parse error: __split_smt: function too hairy. Giving up after 56 seconds

Error #512 when building PDF docs