Skip to contentSkip to conversation

uvcvideo fix

GIT PULL Laurent Pinchart 3 participants 4 messages Mar 25, 2023 – Apr 5, 2023 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hi Mauro,

The following changes since commit 71937240a472ee551ac8de0e7429b9d49884a388:

media: ov2685: Select VIDEO_V4L2_SUBDEV_API (2023-03-20 16:32:18 +0100)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux.git tags/media-uvc-next-20230325

for you to fetch changes up to 1681706c6b8a15fbc0d037b97c0f5e9cf9af67cc:

media: uvcvideo: Cancel async worker earlier (2023-03-25 20:59:49 +0200)

----------------------------------------------------------------
media: uvcvideo: Fix crash at disconnect time

----------------------------------------------------------------
Guenter Roeck (1):
media: uvcvideo: Cancel async worker earlier

 drivers/media/usb/uvc/uvc_ctrl.c   | 11 +++++++----
 drivers/media/usb/uvc/uvc_driver.c |  1 +
 drivers/media/usb/uvc/uvcvideo.h   |  1 +
 3 files changed, 9 insertions(+), 4 deletions(-)
Signature · 3 lines
Regards,

Laurent Pinchart
#1 lore raw

Re: [GIT PULL FOR v6.4] uvcvideo fix (#90679)

From: [email protected]

Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/
Build log: https://builder.linuxtv.org/job/patchwork/292337/
Build time: 00:17:32

gpg: Signature made Sat 25 Mar 2023 07:11:00 PM UTC
gpg:                using EDDSA key C09EF871B3827B413F971CA9CC3F2D800327DE64
gpg:                issuer "[email protected]"
gpg: Can't check signature: No public key

Summary: got 1/1 patches with issues, being 1 at build time, plus one error when buinding PDF document

Error/warnings:

patches/0001-media-uvcvideo-Cancel-async-worker-earlier.patch:

allyesconfig: return code #0:
../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples ../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:415 ov2680_s_stream() warn: missing error code 'ret' ../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3357 atomisp_cp_dvs_6axis_config() warn: missing unwind goto? ../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3456 atomisp_cp_morph_table() warn: missing unwind goto?

allyesconfig: return code #0:
../drivers/media/i2c/adp1653.c: ../drivers/media/i2c/adp1653.c:444 adp1653_of_init() warn: missing unwind goto? SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures ../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c: ../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:2490 mxc_jpeg_probe() warn: missing unwind goto? ../drivers/media/i2c/ov5645.c: ../drivers/media/i2c/ov5645.c:687 ov5645_set_power_on() warn: 'ov5645->xclk' from clk_prepare_enable() not released on lines: 687. ../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() parse error: OOM: 3000016Kb sm_state_count = 1975142 ../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() warn: Function too hairy. No more merges. ../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() parse error: __split_smt: function too hairy. Giving up after 54 seconds ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3293 pvr2_hdw_get_tuner_status() warn: inconsistent indenting

Error #512 when building PDF docs

#2 lore raw
In reply to Laurent Pinchart

Hi Mauro, Hi Laurent

Could you wait a bit before you take this one? I think we have found a cleaner way to do this.

Thanks

Quoted 31 lines · Laurent Pinchart

Hi Mauro,

The following changes since commit 71937240a472ee551ac8de0e7429b9d49884a388:

media: ov2685: Select VIDEO_V4L2_SUBDEV_API (2023-03-20 16:32:18 +0100)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux.git tags/media-uvc-next-20230325

for you to fetch changes up to 1681706c6b8a15fbc0d037b97c0f5e9cf9af67cc:

media: uvcvideo: Cancel async worker earlier (2023-03-25 20:59:49 +0200)

----------------------------------------------------------------
media: uvcvideo: Fix crash at disconnect time

----------------------------------------------------------------
Guenter Roeck (1):
media: uvcvideo: Cancel async worker earlier

 drivers/media/usb/uvc/uvc_ctrl.c   | 11 +++++++----
 drivers/media/usb/uvc/uvc_driver.c |  1 +
 drivers/media/usb/uvc/uvcvideo.h   |  1 +
 3 files changed, 9 insertions(+), 4 deletions(-)

--
Regards,

Laurent Pinchart

Signature · 1 line
Ricardo Ribalda
#3 lore raw
Quoted 4 lines · Ricardo Ribalda

Hi Mauro, Hi Laurent

Could you wait a bit before you take this one? I think we have found a cleaner way to do this.

Works for me. I should have time to review the new fix next week.

Quoted 27 lines · Laurent Pinchart
Quoted 26 lines

Hi Mauro,

The following changes since commit 71937240a472ee551ac8de0e7429b9d49884a388:

media: ov2685: Select VIDEO_V4L2_SUBDEV_API (2023-03-20 16:32:18 +0100)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux.git tags/media-uvc-next-20230325

for you to fetch changes up to 1681706c6b8a15fbc0d037b97c0f5e9cf9af67cc:

media: uvcvideo: Cancel async worker earlier (2023-03-25 20:59:49 +0200)

----------------------------------------------------------------
media: uvcvideo: Fix crash at disconnect time

----------------------------------------------------------------
Guenter Roeck (1):
media: uvcvideo: Cancel async worker earlier

 drivers/media/usb/uvc/uvc_ctrl.c   | 11 +++++++----
 drivers/media/usb/uvc/uvc_driver.c |  1 +
 drivers/media/usb/uvc/uvcvideo.h   |  1 +
 3 files changed, 9 insertions(+), 4 deletions(-)
Signature · 3 lines
Regards,

Laurent Pinchart