Skip to contentSkip to conversation

media: Zero-initialize structures passed to subdev pad ops

GIT PULL Laurent Pinchart 2 participants 2 messages Mar 25, 2023 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hi Mauro,

The following changes since commit 71937240a472ee551ac8de0e7429b9d49884a388:

media: ov2685: Select VIDEO_V4L2_SUBDEV_API (2023-03-20 16:32:18 +0100)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux.git tags/media-zero-init-next-20230325

for you to fetch changes up to 4277e6ad4c2980e24dfe6920b9651635434f2a57:

media: Use designated initializers for all subdev pad ops (2023-03-25 22:13:24 +0200)

----------------------------------------------------------------
media: Zero-initialize structures passed to subdev pad ops

----------------------------------------------------------------
Laurent Pinchart (5):
media: Fix indentation issues introduced by subdev-wide state struct
media: imx-jpeg: Fix incorrect indentation
media: Zero-initialize all structures passed to subdev pad operations
media: Prefer designated initializers over memset for subdev pad ops
media: Use designated initializers for all subdev pad ops

 drivers/media/pci/cobalt/cobalt-v4l2.c             | 21 +++++++-----
 drivers/media/pci/intel/ipu3/ipu3-cio2-main.c      |  1 +
 drivers/media/pci/saa7134/saa7134-empress.c        |  4 +--
 drivers/media/platform/atmel/atmel-isi.c           |  4 +--
 drivers/media/platform/intel/pxa_camera.c          |  4 +--
 drivers/media/platform/marvell/mcam-core.c         |  4 +--
 .../media/platform/microchip/microchip-isc-base.c  |  5 +--
 drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c     |  7 ++--
 drivers/media/platform/qcom/camss/camss-video.c    |  5 +--
 drivers/media/platform/renesas/renesas-ceu.c       |  4 +--
 drivers/media/platform/renesas/vsp1/vsp1_drm.c     | 23 +++++++------
 drivers/media/platform/renesas/vsp1/vsp1_entity.c  | 11 +++---
 drivers/media/platform/renesas/vsp1/vsp1_video.c   |  5 +--
 .../platform/rockchip/rkisp1/rkisp1-resizer.c      | 14 ++++----
 .../platform/samsung/exynos4-is/fimc-capture.c     | 18 ++++++----
 .../platform/samsung/exynos4-is/fimc-isp-video.c   | 10 ++++--
 .../media/platform/samsung/exynos4-is/fimc-lite.c  |  9 +++--
 .../platform/samsung/s3c-camif/camif-capture.c     |  5 +--
 .../media/platform/samsung/s3c-camif/camif-core.c  |  5 +--
 drivers/media/platform/ti/am437x/am437x-vpfe.c     | 35 ++++++++++---------
 drivers/media/platform/ti/cal/cal-video.c          | 37 +++++++++++---------
 drivers/media/platform/ti/omap3isp/ispccdc.c       |  5 +--
 drivers/media/platform/ti/omap3isp/ispvideo.c      | 20 ++++++-----
 drivers/media/platform/via/via-camera.c            |  4 +--
 drivers/media/platform/xilinx/xilinx-dma.c         |  5 +--
 drivers/media/test-drivers/vimc/vimc-common.c      |  8 ++---
 drivers/media/usb/dvb-usb/cxusb-analog.c           | 14 ++++----
 drivers/staging/media/atomisp/pci/atomisp_cmd.c    |  8 ++---
 .../media/deprecated/atmel/atmel-isc-base.c        |  9 ++---
 drivers/staging/media/imx/imx-media-capture.c      | 40 ++++++++++++----------
 drivers/staging/media/imx/imx-media-utils.c        |  8 ++---
 drivers/staging/media/omap4iss/iss_video.c         | 16 +++++----
 drivers/staging/media/tegra-video/vi.c             | 10 +++---
 33 files changed, 210 insertions(+), 168 deletions(-)
Signature · 3 lines
Regards,

Laurent Pinchart
#1 lore raw

Re: [GIT PULL FOR v6.4] media: Zero-initialize structures passed to (#90682)

From: [email protected]

Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/
Build log: https://builder.linuxtv.org/job/patchwork/292348/
Build time: 00:19:32

gpg: Signature made Sat 25 Mar 2023 08:26:18 PM UTC
gpg:                using EDDSA key C09EF871B3827B413F971CA9CC3F2D800327DE64
gpg:                issuer "[email protected]"
gpg: Can't check signature: No public key

Summary: got 2/5 patches with issues, being 2 at build time, plus one error when buinding PDF document

Error/warnings:

patches/0001-media-Fix-indentation-issues-introduced-by-subdev-wi.patch:

allyesconfig: return code #0:
../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples ../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:415 ov2680_s_stream() warn: missing error code 'ret' ../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3357 atomisp_cp_dvs_6axis_config() warn: missing unwind goto? ../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3456 atomisp_cp_morph_table() warn: missing unwind goto?

allyesconfig: return code #0:
../drivers/media/i2c/adp1653.c: ../drivers/media/i2c/adp1653.c:444 adp1653_of_init() warn: missing unwind goto? ../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c: ../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:2490 mxc_jpeg_probe() warn: missing unwind goto? SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures ../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() parse error: OOM: 3000020Kb sm_state_count = 1974615 ../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() warn: Function too hairy. No more merges. ../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() parse error: __split_smt: function too hairy. Giving up after 54 seconds ../drivers/media/i2c/ov5645.c: ../drivers/media/i2c/ov5645.c:687 ov5645_set_power_on() warn: 'ov5645->xclk' from clk_prepare_enable() not released on lines: 687. ../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2864 em28xx_v4l2_init() parse error: turning off implications after 60 seconds ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3293 pvr2_hdw_get_tuner_status() warn: inconsistent indenting

patches/0002-media-imx-jpeg-Fix-incorrect-indentation.patch:

allyesconfig: return code #0:
../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c: ../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:2489 mxc_jpeg_probe() warn: missing unwind goto?

Error #512 when building PDF docs