media: Miscellaneous fixes for Renesas drivers
Hi Mauro,
The following changes since commit 71937240a472ee551ac8de0e7429b9d49884a388:
media: ov2685: Select VIDEO_V4L2_SUBDEV_API (2023-03-20 16:32:18 +0100)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux.git tags/media-renesas-next-20230325
for you to fetch changes up to 0b89ff5c03d3a124b5c5a454d6137dd562a36757:
media: rcar_fdp1: Fix refcount leak in probe and remove function (2023-03-25 22:30:21 +0200)
----------------------------------------------------------------
media: Miscellaneous fixes for Renesas drivers
----------------------------------------------------------------
Gaosheng Cui (1):
media: vsp1: Remove unused vsp1_subdev_internal_ops declaration
Laurent Pinchart (1):
media: vsp1: Replace vb2_is_streaming() with vb2_start_streaming_called()
Miaoqian Lin (1):
media: rcar_fdp1: Fix refcount leak in probe and remove function
Tomi Valkeinen (1):
media: vsp1: Add underrun debug print
drivers/media/platform/renesas/rcar_fdp1.c | 11 ++++++++--- drivers/media/platform/renesas/vsp1/vsp1_drm.c | 3 +++ drivers/media/platform/renesas/vsp1/vsp1_drv.c | 11 ++++++++++- drivers/media/platform/renesas/vsp1/vsp1_entity.h | 2 -- drivers/media/platform/renesas/vsp1/vsp1_pipe.h | 2 ++ drivers/media/platform/renesas/vsp1/vsp1_regs.h | 2 ++ drivers/media/platform/renesas/vsp1/vsp1_video.c | 2 +- 7 files changed, 26 insertions(+), 7 deletions(-)
Signature · 3 lines
Regards, Laurent Pinchart
Re: [GIT PULL FOR v6.4] media: Miscellaneous fixes for Renesas drivers (#90683)
From: [email protected]
Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/
Build log: https://builder.linuxtv.org/job/patchwork/292349/
Build time: 00:18:39
gpg: Signature made Sat 25 Mar 2023 08:36:08 PM UTC gpg: using EDDSA key C09EF871B3827B413F971CA9CC3F2D800327DE64 gpg: issuer "[email protected]" gpg: Can't check signature: No public key
Summary: got 3/4 patches with issues, being 1 at build time, plus one error when buinding PDF document
Error/warnings:
patches/0001-media-vsp1-Remove-unused-vsp1_subdev_internal_ops-de.patch:
allyesconfig: return code #0:
../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples ../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:415 ov2680_s_stream() warn: missing error code 'ret' ../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3357 atomisp_cp_dvs_6axis_config() warn: missing unwind goto? ../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3456 atomisp_cp_morph_table() warn: missing unwind goto?
allyesconfig: return code #0:
../drivers/media/i2c/adp1653.c: ../drivers/media/i2c/adp1653.c:444 adp1653_of_init() warn: missing unwind goto? ../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c: ../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:2490 mxc_jpeg_probe() warn: missing unwind goto? ../drivers/media/i2c/ov5645.c: ../drivers/media/i2c/ov5645.c:687 ov5645_set_power_on() warn: 'ov5645->xclk' from clk_prepare_enable() not released on lines: 687. SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures ../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() parse error: OOM: 3000020Kb sm_state_count = 1974803 ../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() warn: Function too hairy. No more merges. ../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() parse error: __split_smt: function too hairy. Giving up after 55 seconds ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3293 pvr2_hdw_get_tuner_status() warn: inconsistent indenting
checkpatch.pl:
$ cat patches/0001-media-vsp1-Remove-unused-vsp1_subdev_internal_ops-de.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:6: ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0efdf0f5eaaf ("[media] v4l: vsp1: Implement and use the subdev pad::init_cfg configuration")'patches/0002-media-vsp1-Replace-vb2_is_streaming-with-vb2_start_s.patch:
checkpatch.pl:
$ cat patches/0002-media-vsp1-Replace-vb2_is_streaming-with-vb2_start_s.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict -:84: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
patches/0003-media-vsp1-Add-underrun-debug-print.patch:
checkpatch.pl:
$ cat patches/0003-media-vsp1-Add-underrun-debug-print.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict -:58: CHECK: Alignment should match open parenthesis
Error #512 when building PDF docs