Skip to contentSkip to conversation

PCI/P2PDMA: Fix the comments on pci_p2pmem_find_many()

PATCH Superseded Cai Huoqing 2 participants 2 messages Mar 27, 2023

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI/P2PDMA: Fix the comments on pci_p2pmem_find_many()

Use pci_p2pdma_map_segment() instead of pci_p2pmem_dma(), because pci_p2pmem_dma() is already removed.

---
 drivers/pci/p2pdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/p2pdma.c +1 -1
index 9e8205572830..4f1798ecf38f 100644
@@ -747,7 +747,7 @@ EXPORT_SYMBOL_GPL(pci_has_p2pmem);
 /**
  * pci_p2pmem_find_many - find a peer-to-peer DMA memory device compatible with
  *	the specified list of clients and shortest distance (as determined
- *	by pci_p2pmem_dma())
+ *	by pci_p2pdma_map_segment())
  * @clients: array of devices to check (NULL-terminated)
  * @num_clients: number of client devices in the list
  *
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 4 lines · Cai Huoqing

Use pci_p2pdma_map_segment() instead of pci_p2pmem_dma(), because pci_p2pmem_dma() is already removed.

Thanks for noticing this!

Quoted 9 lines
---
 drivers/pci/p2pdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/p2pdma.c +0 -0
index 9e8205572830..4f1798ecf38f 100644

drivers/pci/p2pdma.c EXPORT_SYMBOL_GPL(pci_has_p2pmem); · line 750

Quoted 5 lines
drivers/pci/p2pdma.c +1 -1
@@ -747,7 +747,7 @@ EXPORT_SYMBOL_GPL(pci_has_p2pmem);
 /**
  * pci_p2pmem_find_many - find a peer-to-peer DMA memory device compatible with
  *	the specified list of clients and shortest distance (as determined
- *	by pci_p2pmem_dma())
+ *	by pci_p2pdma_map_segment())

Maybe we should just remove the reference to pci_p2pdma_map_segment() completely. I don't see how that function helps the reader any more and is really different section of the API anyway.

Logan