Skip to contentSkip to conversation

sysreset: gpio: fix gpio_reboot_request return value

PATCH In review Jonathan Liu 2 participants 2 messages Mar 28, 2023 – Apr 1, 2023

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 sysreset: gpio: fix gpio_reboot_request return value

It should return -EINPROGRESS if successful otherwise sysreset-uclass will continue to the next sysreset device.

---
 drivers/sysreset/sysreset_gpio.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/sysreset/sysreset_gpio.c +6 -1
index dfca10ccc8..de42b59354 100644
@@ -17,6 +17,7 @@ struct gpio_reboot_priv {
 static int gpio_reboot_request(struct udevice *dev, enum sysreset_t type)
 {
 	struct gpio_reboot_priv *priv = dev_get_priv(dev);
+	int ret;
 
 	/*
 	 * When debug log is enabled please make sure that chars won't end up
@@ -26,7 +27,11 @@ static int gpio_reboot_request(struct udevice *dev, enum sysreset_t type)
 	debug("GPIO reset\n");
 
 	/* Writing 1 respects polarity (active high/low) based on gpio->flags */
-	return dm_gpio_set_value(&priv->gpio, 1);
+	ret = dm_gpio_set_value(&priv->gpio, 1);
+	if (ret < 0)
+		return ret;
+
+	return -EINPROGRESS;
 }
 
 static struct sysreset_ops gpio_reboot_ops = {
Signature · 1 line
2.40.0