Skip to contentSkip to conversation

mm: compaction: move compaction sysctl to its own file

PATCH Superseded [email protected] 2 participants 2 messages Mar 28, 2023

Subsystems (4)

v7 of 8 Superseded Latest is v8 →

lore
Share & tools
lore
#0 lore raw

PATCH v7 1/2 mm: compaction: move compaction sysctl to its own file

From: Minghao Chi <[email protected]>

This moves all compaction sysctls to its own file.

---
 include/linux/compaction.h |  7 ----
 kernel/sysctl.c            | 59 --------------------------
 mm/compaction.c            | 84 ++++++++++++++++++++++++++++++++------
 3 files changed, 72 insertions(+), 78 deletions(-)
include/linux/compaction.h +0 -7
index 52a9ff65faee..a6e512cfb670 100644
@@ -81,13 +81,6 @@ static inline unsigned long compact_gap(unsigned int order)
 }
 
 #ifdef CONFIG_COMPACTION
-extern unsigned int sysctl_compaction_proactiveness;
-extern int sysctl_compaction_handler(struct ctl_table *table, int write,
-			void *buffer, size_t *length, loff_t *ppos);
-extern int compaction_proactiveness_sysctl_handler(struct ctl_table *table,
-		int write, void *buffer, size_t *length, loff_t *ppos);
-extern int sysctl_extfrag_threshold;
-extern int sysctl_compact_unevictable_allowed;
 
 extern unsigned int extfrag_for_order(struct zone *zone, unsigned int order);
 extern int fragmentation_index(struct zone *zone, unsigned int order);
kernel/sysctl.c +0 -59

77 lines not on this page · raw message

mm/compaction.c +72 -12

120 lines not on this page · raw message

Signature · 1 line
2.25.1
#1 lore raw
Quoted 5 lines · On Tue, Mar 28, 2023 at 10:02:04AM +0800, [email protected] wrote:

From: Minghao Chi <[email protected]>

This moves all compaction sysctls to its own file.

Your commit log did not improve as requested sadly. Please look at the other kernel/sysctl.c changes and you can find much better motivations documented before there.

For example a467257ffe4 ("kernel/kexec_core: move kexec_core sysctls into its own file"). You can also now add the defconfig size results you had mentioned last.

Luis