Skip to contentSkip to conversation

media: dvb-usb: dw2102: Fix uninit-value in su3000_read_mac_address

PATCH New Wei Chen 1 participant 1 message Mar 28, 2023 Media (V4L/DVB)

lore
Share & tools
lore

Wei Chen

author
#0 lore raw

PATCH 1/1 media: dvb-usb: dw2102: Fix uninit-value in su3000_read_mac_address

In su3000_read_mac_address, if i2c_transfer fails to execute two messages, array mac address will not be initialized. Without handling such error, later in function dvb_usb_adapter_dvb_init, proposed_mac is accessed before initialization.

Fix this error by returning a negative value if message execution fails.

---
 drivers/media/usb/dvb-usb/dw2102.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/usb/dvb-usb/dw2102.c +1 -1
index 0ca764282c76..8747960e6146 100644
@@ -946,7 +946,7 @@ static int su3000_read_mac_address(struct dvb_usb_device *d, u8 mac[6])
 	for (i = 0; i < 6; i++) {
 		obuf[1] = 0xf0 + i;
 		if (i2c_transfer(&d->i2c_adap, msg, 2) != 2)
-			break;
+			return -1;
 		else
 			mac[i] = ibuf[0];
 	}
Signature · 1 line
2.25.1