scsi: target: core: remove unused prod_len variable
Subsystems (2)
PATCH 1/1 scsi: target: core: remove unused prod_len variable
clang with W=1 reports drivers/target/target_core_spc.c:229:6: error: variable
'prod_len' set but not used [-Werror,-Wunused-but-set-variable]
u32 prod_len;
^This variable is not used so remove it.
Signed-off-by Tom Rix <[email protected]>
--- drivers/target/target_core_spc.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/target/target_core_spc.c +0 -5
@@ -226,7 +226,6 @@ spc_emulate_evpd_83(struct se_cmd *cmd, unsigned char *buf)struct t10_alua_lu_gp_member *lu_gp_mem;struct t10_alua_tg_pt_gp *tg_pt_gp;unsigned char *prod = &dev->t10_wwn.model[0 ]; -u32 prod_len;u32 off =0 ;u16 len =0 , id_len;
@@ -267,10 +266,6 @@ spc_emulate_evpd_83(struct se_cmd *cmd, unsigned char *buf)* T10 Vendor Identifier Page, see spc4r17 section 7.7.3.4 */ id_len =8 ;/* For Vendor field */ - prod_len =4 ;/* For VPD Header */ - prod_len +=8 ;/* For Vendor field */ - prod_len +=strlen (prod); - prod_len++;/* For : */ if (dev->dev_flags &DF_EMULATED_VPD_UNIT_SERIAL ) id_len += sprintf(&buf[off+12], "%s:%s", prod,
Signature · 1 line
2.27.0
Quoted 10 lines · Tom Rix
clang with W=1 reports
drivers/target/target_core_spc.c:229:6: error: variable
'prod_len' set but not used [-Werror,-Wunused-but-set-variable]u32 prod_len; ^This variable is not used so remove it.
Signed-off-by Tom Rix <[email protected]>---
Looks good.
Reviewed-by Chaitanya Kulkarni <[email protected]>
-ck
Martin K. Petersen
AppliedQuoted 8 lines · Tom Rix
clang with W=1 reports
drivers/target/target_core_spc.c:229:6: error: variable
'prod_len' set but not used [-Werror,-Wunused-but-set-variable]u32 prod_len; ^This variable is not used so remove it.
[...]
Applied to 6.4/scsi-queue, thanks!
[1/1] scsi: target: core: remove unused prod_len variable
https://git.kernel.org/mkp/scsi/c/aa4d7812cf2c
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering