hwmon: (coretemp) Delete tjmax debug message
Subsystems (2)
PATCH v2 1/2 hwmon: (coretemp) Delete tjmax debug message
After commit c0c67f8761ce ("hwmon: (coretemp) Add support for dynamic tjmax"), tjmax value is retrieved from MSR every time the temperature is read.
This means that, with debug message enabled, the tjmax debug message is printed out for every single temperature read for any CPU. This spams the syslog.
Ideally, as tjmax is package scope unique, the debug message should show once when tjmax is changed for one package. But this requires inventing some new per-package data in the coretemp driver, and this is overkill.
To keep the code simple, delete the tjmax debug message.
--- drivers/hwmon/coretemp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/hwmon/coretemp.c +1 -3
@@ -286,10 +286,8 @@ static int get_tjmax(struct temp_data *tdata, struct device *dev)* If the TjMax is not plausible, an assumption * will be used */ -if (val) { -dev_dbg (dev,"TjMax is %d degrees C\n" , val); +if (val)return val *1000 ; - } }if (force_tjmax) {
Signature · 1 line
2.25.1
PATCH v2 2/2 hwmon: (coretemp) Delete an obsolete comment
The refinement of tjmax value retrieved from MSR_IA32_TEMPERATURE_TARGET has been changed for several times.
Now, the raw value from MSR is used without refinement. Thus remove the obsolete comment.
--- drivers/hwmon/coretemp.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/hwmon/coretemp.c +0 -4
@@ -282,10 +282,6 @@ static int get_tjmax(struct temp_data *tdata, struct device *dev)dev_warn (dev,"Unable to read TjMax from CPU %u\n" , tdata->cpu); }else { val = (eax >>16 ) &0xff ; -/* -* If the TjMax is not plausible, an assumption -* will be used -*/ if (val)return val *1000 ; }
Signature · 1 line
2.25.1
Re: [PATCH v2 2/2] hwmon: (coretemp) Delete an obsolete comment
Quoted 7 lines · Zhang Rui
The refinement of tjmax value retrieved from
MSR_IA32_TEMPERATURE_TARGEThas been changed for several times.Now, the raw value from MSR is used without refinement. Thus remove the obsolete comment.
Signed-off-by Zhang Rui <[email protected]>
Applied.
Thanks,
Guenter
Quoted 19 lines
--- drivers/hwmon/coretemp.c | 4 ---- 1 file changed, 4 deletions(-)drivers/hwmon/coretemp.c +0
-4@@ -282,10 +282,6 @@ static int get_tjmax(struct temp_data *tdata, struct device *dev)dev_warn (dev,"Unable to read TjMax from CPU %u\n" , tdata->cpu); }else { val = (eax >>16 ) &0xff ; -/* -* If the TjMax is not plausible, an assumption -* will be used -*/ if (val)return val *1000 ; }
Quoted 7 lines · Zhang Rui
After commit
c0c67f8761ce("hwmon: (coretemp) Add support for dynamic tjmax"), tjmax value is retrieved from MSR every time the temperature is read.
This means that, with debug message enabled, the tjmax debug message is printed out for every single temperature read for any CPU. This spams the syslog.
Quoted 7 lines
Ideally, as tjmax is package scope unique, the debug message should show once when tjmax is changed for one package. But this requires inventing some new per-package data in the coretemp driver, and this is overkill.
To keep the code simple, delete the tjmax debug message.
Signed-off-by Zhang Rui <[email protected]>
Applied.
Thanks,
Guenter
Quoted 20 lines
--- drivers/hwmon/coretemp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/hwmon/coretemp.c +1
-3@@ -286,10 +286,8 @@ static int get_tjmax(struct temp_data *tdata, struct device *dev)* If the TjMax is not plausible, an assumption * will be used */ -if (val) { -dev_dbg (dev,"TjMax is %d degrees C\n" , val); +if (val)return val *1000 ; - } }if (force_tjmax) {