Skip to contentSkip to conversation

reiserfs: remove unused iter variable

PATCH In review Tom Rix 2 participants 2 messages Mar 31, 2023

lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 reiserfs: remove unused iter variable

clang with W=1 reports
fs/reiserfs/stree.c:1265:6: error: variable
'iter' set but not used [-Werror,-Wunused-but-set-variable]

        int iter = 0;
            ^

This variable is not used so remove it.

---
 fs/reiserfs/stree.c | 2 --
 1 file changed, 2 deletions(-)
fs/reiserfs/stree.c +0 -2
index 84c12a1947b2..ce5003986789 100644
@@ -1262,7 +1262,6 @@ int reiserfs_delete_item(struct reiserfs_transaction_handle *th,
 
 #ifdef CONFIG_REISERFS_CHECK
 	char mode;
-	int iter = 0;
 #endif
 
 	BUG_ON(!th->t_trans_id);
@@ -1274,7 +1273,6 @@ int reiserfs_delete_item(struct reiserfs_transaction_handle *th,
 		removed = 0;
 
 #ifdef CONFIG_REISERFS_CHECK
-		iter++;
 		mode =
 #endif
 		    prepare_for_delete_or_cut(th, inode, path,
Signature · 1 line
2.27.0
#1 lore raw
Quoted 8 lines · Tom Rix

clang with W=1 reports
fs/reiserfs/stree.c:1265:6: error: variable
'iter' set but not used [-Werror,-Wunused-but-set-variable]

        int iter = 0;
            ^

This variable is not used so remove it.

Thanks. I've merged the patch to my tree.

Honza

Quoted 27 lines
---
 fs/reiserfs/stree.c | 2 --
 1 file changed, 2 deletions(-)
fs/reiserfs/stree.c +0 -2
index 84c12a1947b2..ce5003986789 100644
@@ -1262,7 +1262,6 @@ int reiserfs_delete_item(struct reiserfs_transaction_handle *th,
 
 #ifdef CONFIG_REISERFS_CHECK
 	char mode;
-	int iter = 0;
 #endif
 
 	BUG_ON(!th->t_trans_id);
@@ -1274,7 +1273,6 @@ int reiserfs_delete_item(struct reiserfs_transaction_handle *th,
 		removed = 0;
 
 #ifdef CONFIG_REISERFS_CHECK
-		iter++;
 		mode =
 #endif
 		    prepare_for_delete_or_cut(th, inode, path,
Signature · 1 line
2.27.0
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR