Skip to contentSkip to conversation

mb86a20s: remove unused active_layers variable

PATCH In review Tom Rix 2 participants 2 messages Apr 1, 2023 – Apr 7, 2023 Media (V4L/DVB)

lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 mb86a20s: remove unused active_layers variable

clang with W=1 reports drivers/media/dvb-frontends/mb86a20s.c:1572:6: error: variable
'active_layers' set but not used [-Werror,-Wunused-but-set-variable]

        int active_layers = 0, pre_ber_layers = 0, post_ber_layers = 0;
            ^

This variable is not used so remove it.

---
 drivers/media/dvb-frontends/mb86a20s.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/media/dvb-frontends/mb86a20s.c +1 -4
index b74b9afed9a2..125fed4891ba 100644
@@ -1569,7 +1569,7 @@ static int mb86a20s_get_stats(struct dvb_frontend *fe, int status_nr)
 	u32 t_post_bit_error = 0, t_post_bit_count = 0;
 	u32 block_error = 0, block_count = 0;
 	u32 t_block_error = 0, t_block_count = 0;
-	int active_layers = 0, pre_ber_layers = 0, post_ber_layers = 0;
+	int pre_ber_layers = 0, post_ber_layers = 0;
 	int per_layers = 0;
 
 	dev_dbg(&state->i2c->dev, "%s called.\n", __func__);
@@ -1589,9 +1589,6 @@ static int mb86a20s_get_stats(struct dvb_frontend *fe, int status_nr)
 
 	for (layer = 0; layer < NUM_LAYERS; layer++) {
 		if (c->isdbt_layer_enabled & (1 << layer)) {
-			/* Layer is active and has rc segments */
-			active_layers++;
-
 			/* Handle BER before vterbi */
 			rc = mb86a20s_get_pre_ber(fe, layer,
 						  &bit_error, &bit_count);
Signature · 1 line
2.27.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Tom Rix

clang with W=1 reports drivers/media/dvb-frontends/mb86a20s.c:1572:6: error: variable
'active_layers' set but not used [-Werror,-Wunused-but-set-variable]

        int active_layers = 0, pre_ber_layers = 0, post_ber_layers = 0;
            ^

This variable is not used so remove it.

Thanks for the patch!

Fixes 149d518ad0fd ("[media] mb86a20s: add BER measurement")
Quoted 30 lines
---
 drivers/media/dvb-frontends/mb86a20s.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/media/dvb-frontends/mb86a20s.c +1 -5
index b74b9afed9a2..125fed4891ba 100644
@@ -1569,7 +1569,7 @@ static int mb86a20s_get_stats(struct dvb_frontend *fe, int status_nr)
        u32 t_post_bit_error = 0, t_post_bit_count = 0;
        u32 block_error = 0, block_count = 0;
        u32 t_block_error = 0, t_block_count = 0;
-       int active_layers = 0, pre_ber_layers = 0, post_ber_layers = 0;
+       int pre_ber_layers = 0, post_ber_layers = 0;
        int per_layers = 0;
 
        dev_dbg(&state->i2c->dev, "%s called.\n", __func__);
@@ -1589,9 +1589,6 @@ static int mb86a20s_get_stats(struct dvb_frontend *fe, int status_nr)
 
        for (layer = 0; layer < NUM_LAYERS; layer++) {
                if (c->isdbt_layer_enabled & (1 << layer)) {
-                       /* Layer is active and has rc segments */
-                       active_layers++;
-
                        /* Handle BER before vterbi */
                        rc = mb86a20s_get_pre_ber(fe, layer,
                                                  &bit_error, &bit_count);
--

2.27.0

Signature · 2 lines
Thanks,
~Nick Desaulniers