Skip to contentSkip to conversation

ASoC: dt-bindings: wm8510: Convert to dtschema

PATCH Superseded Saalim Quadri 2 participants 3 messages Apr 2, 2023 – Apr 3, 2023

Subsystems (3)
Device tree bindings ASoC Wolfson microelectronics drivers

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Saalim Quadri

author
#0 lore raw

PATCH 1/1 ASoC: dt-bindings: wm8510: Convert to dtschema

Convert the WM8510 audio CODEC bindings to DT schema

Signed-off-by Saalim Quadri <[email protected]>
---
 .../devicetree/bindings/sound/wlf,wm8510.yaml | 39 +++++++++++++++++++
 .../devicetree/bindings/sound/wm8510.txt      | 18 ---------
 2 files changed, 39 insertions(+), 18 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8510.yaml
 delete mode 100644 Documentation/devicetree/bindings/sound/wm8510.txt
Documentation/devicetree/bindings/sound/wlf,wm8510.yaml new file +39 -0
new file mode 100644
index 000000000000..f45dad0fbef3
@@ -0,0 +1,39 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/wlf,wm8510.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: WM8510 audio CODEC
+
+description: |
+  These devices support both I2C and SPI (configured with pin strapping
+  on the board).
+
+maintainers:
+  - Mark Brown <[email protected]>
+
+properties:
+  compatible:
+    const: wlf,wm8510
+
+  reg:
+    description:
+      The I2C address of the device for I2C, the chip select number for SPI
+    maxItems: 1
+
+additionalProperties: false
+
+required:
+  - reg
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        codec@1a {
+            compatible = "wlf,wm8510";
+            reg = <0x1a>;
+        };
+    };
Documentation/devicetree/bindings/sound/wm8510.txt deleted +0 -18
deleted file mode 100644
index e6b6cc041f89..000000000000
@@ -1,18 +0,0 @@
-WM8510 audio CODEC
-
-This device supports both I2C and SPI (configured with pin strapping
-on the board).
-
-Required properties:
-
-  - compatible : "wlf,wm8510"
-
-  - reg : the I2C address of the device for I2C, the chip select
-          number for SPI.
-
-Example:
-
-wm8510: codec@1a {
-	compatible = "wlf,wm8510";
-	reg = <0x1a>;
-};
Signature · 1 line
2.34.1
#1 lore raw
Quoted 20 lines · Saalim Quadri

Convert the WM8510 audio CODEC bindings to DT schema

Signed-off-by Saalim Quadri <[email protected]>
---
 .../devicetree/bindings/sound/wlf,wm8510.yaml | 39 +++++++++++++++++++
 .../devicetree/bindings/sound/wm8510.txt      | 18 ---------
 2 files changed, 39 insertions(+), 18 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8510.yaml
 delete mode 100644 Documentation/devicetree/bindings/sound/wm8510.txt
Documentation/devicetree/bindings/sound/wlf,wm8510.yaml new file +4 -0
new file mode 100644
index 000000000000..f45dad0fbef3
@@ -0,0 +1,39 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/wlf,wm8510.yaml#

Documentation/devicetree/bindings/sound/wlf,wm8510.yaml line 14

Quoted 10 lines
Documentation/devicetree/bindings/sound/wlf,wm8510.yaml new file +10 -0
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: WM8510 audio CODEC
+
+description: |
+  These devices support both I2C and SPI (configured with pin strapping
+  on the board).
+
+maintainers:
+  - Mark Brown <[email protected]>

This should be rather someone from Cirrus or their regular contact - [email protected].

Also missing $ref to dai-common.yaml

Documentation/devicetree/bindings/sound/wlf,wm8510.yaml line 22

Quoted 8 lines
Documentation/devicetree/bindings/sound/wlf,wm8510.yaml new file +8 -0
+
+properties:
+  compatible:
+    const: wlf,wm8510
+
+  reg:
+    description:
+      The I2C address of the device for I2C, the chip select number for SPI

Drop description, it is obvious.

Documentation/devicetree/bindings/sound/wlf,wm8510.yaml line 23

Quoted 1 line
Documentation/devicetree/bindings/sound/wlf,wm8510.yaml new file +1 -0
+    maxItems: 1

sound-dai-cells with const:0

Documentation/devicetree/bindings/sound/wlf,wm8510.yaml line 25

Quoted 2 lines
Documentation/devicetree/bindings/sound/wlf,wm8510.yaml new file +2 -0
+
+additionalProperties: false

This goes after required. Look at example-schema. Anyway this should be
unevaluatedProperties: false, after adding the $ref.

Documentation/devicetree/bindings/sound/wlf,wm8510.yaml line 27

Quoted 2 lines
Documentation/devicetree/bindings/sound/wlf,wm8510.yaml new file +2 -0
+
+required:

Missing compatible.

Quoted 26 lines
Documentation/devicetree/bindings/sound/wlf,wm8510.yaml new file +12 -0
+  - reg
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        codec@1a {
+            compatible = "wlf,wm8510";
+            reg = <0x1a>;
+        };
+    };
Documentation/devicetree/bindings/sound/wm8510.txt deleted +0 -8
deleted file mode 100644
index e6b6cc041f89..000000000000
@@ -1,18 +0,0 @@
-WM8510 audio CODEC
-
-This device supports both I2C and SPI (configured with pin strapping
-on the board).
-
-Required properties:
-
-  - compatible : "wlf,wm8510"

Documentation/devicetree/bindings/sound/wm8510.txt line 18

Quoted 10 lines
Documentation/devicetree/bindings/sound/wm8510.txt deleted +0 -10
-
-  - reg : the I2C address of the device for I2C, the chip select
-          number for SPI.
-
-Example:
-
-wm8510: codec@1a {
-	compatible = "wlf,wm8510";
-	reg = <0x1a>;
-};

Best regards,
Krzysztof

author
#2 lore raw
Quoted 2 lines

This should be rather someone from Cirrus or their regular contact - [email protected].

Alright I will do so.

For I2C and SPI description, is it required to add it only once? or just not required at all?

Kind Regards,

Saalim