selftests/bpf: Add RESOLVE_BTFIDS dependency to bpf_testmod.ko
Subsystems (3)
PATCH 1/1 selftests/bpf: Add RESOLVE_BTFIDS dependency to bpf_testmod.ko
bpf_testmod.ko sometimes fails to build from a clean checkout:
BTF [M] linux/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.ko /bin/sh: 1: linux-build//tools/build/resolve_btfids/resolve_btfids: not found
The reason is that RESOLVE_BTFIDS may not yet be built. Fix by adding a dependency.
--- tools/testing/selftests/bpf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/Makefile +1 -1
@@ -201,7 +201,7 @@ $(OUTPUT)/sign-file: ../../../../scripts/sign-file.c $< -o $@ \ $(shell $(HOSTPKG_CONFIG) --libs libcrypto 2> /dev/null || echo -lcrypto) -$(OUTPUT)/bpf_testmod.ko: $(VMLINUX_BTF) $(wildcard bpf_testmod/Makefile bpf_testmod/*.[ch]) +$(OUTPUT)/bpf_testmod.ko: $(VMLINUX_BTF) $(RESOLVE_BTFIDS) $(wildcard bpf_testmod/Makefile bpf_testmod/*.[ch]) $(call msg,MOD,,$@) $(Q)$(RM) bpf_testmod/bpf_testmod.ko # force re-compilation $(Q)$(MAKE) $(submake_extras) RESOLVE_BTFIDS=$(RESOLVE_BTFIDS) -C bpf_testmod
Signature · 1 line
2.39.2
Quoted 9 lines · Ilya Leoshkevich
bpf_testmod.ko sometimes fails to build from a clean checkout:
BTF [M]
linux/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.ko/bin/sh: 1: linux-build//tools/build/resolve_btfids/resolve_btfids: not foundThe reason is that
RESOLVE_BTFIDSmay not yet be built. Fix by adding a dependency.Signed-off-by Ilya Leoshkevich <[email protected]>
jirka
Quoted 20 lines
--- tools/testing/selftests/bpf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/testing/selftests/bpf/Makefile +1
-1@@ -201,7 +201,7 @@ $(OUTPUT)/sign-file: ../../../../scripts/sign-file.c $< -o $@ \ $(shell $(HOSTPKG_CONFIG) --libs libcrypto 2> /dev/null || echo -lcrypto) -$(OUTPUT)/bpf_testmod.ko: $(VMLINUX_BTF) $(wildcard bpf_testmod/Makefile bpf_testmod/*.[ch]) +$(OUTPUT)/bpf_testmod.ko: $(VMLINUX_BTF) $(RESOLVE_BTFIDS) $(wildcard bpf_testmod/Makefile bpf_testmod/*.[ch]) $(call msg,MOD,,$@) $(Q)$(RM) bpf_testmod/bpf_testmod.ko # force re-compilation $(Q)$(MAKE) $(submake_extras) RESOLVE_BTFIDS=$(RESOLVE_BTFIDS) -C bpf_testmodSignature · 1 line
2.39.2
This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:
Hello:
This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:
Quoted 9 lines · On Mon, 3 Apr 2023 19:29:35 +0200 you wrote:
bpf_testmod.ko sometimes fails to build from a clean checkout:
BTF [M]
linux/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.ko/bin/sh: 1: linux-build//tools/build/resolve_btfids/resolve_btfids: not foundThe reason is that
RESOLVE_BTFIDSmay not yet be built. Fix by adding a dependency.[...]
Here is the summary with links:
- [bpf-next] selftests/bpf: Add RESOLVE_BTFIDS dependency to bpf_testmod.ko
https://git.kernel.org/bpf/bpf-next/c/8fc59c26d212
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html