Skip to contentSkip to conversation

cpufreq: amd-pstate: set varaiable mode_state_machine storage-class-specifier to static

PATCH Applied Tom Rix 4 participants 4 messages Apr 4, 2023 – Apr 11, 2023

Subsystems (2)
CPU frequency scaling framework AMD pstate driver
lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 cpufreq: amd-pstate: set varaiable mode_state_machine storage-class-specifier to static

smatch reports
drivers/cpufreq/amd-pstate.c:907:25: warning: symbol
'mode_state_machine' was not declared. Should it be static?

This variable is only used in one file so it should be static.

Signed-off-by Tom Rix <[email protected]>
---
 drivers/cpufreq/amd-pstate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpufreq/amd-pstate.c +1 -1
index 6f4b8040d46c..5a3d4aa0f45a 100644
@@ -904,7 +904,7 @@ static int amd_pstate_change_driver_mode(int mode)
 	return 0;
 }
 
-cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
+static cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
 	[AMD_PSTATE_DISABLE]         = {
 		[AMD_PSTATE_DISABLE]     = NULL,
 		[AMD_PSTATE_PASSIVE]     = amd_pstate_register_driver,
Signature · 1 line
2.27.0
Reviewed-by Tested-by on v1 1/1
#1 lore raw
Quoted 7 lines · Tom Rix

smatch reports
drivers/cpufreq/amd-pstate.c:907:25: warning: symbol
'mode_state_machine' was not declared. Should it be static?

This variable is only used in one file so it should be static.

Signed-off-by Tom Rix <[email protected]>
Reviewed-by Wyes Karny <[email protected]>
Tested-by Wyes Karny <[email protected]>
Quoted 20 lines
---
 drivers/cpufreq/amd-pstate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpufreq/amd-pstate.c +1 -1
index 6f4b8040d46c..5a3d4aa0f45a 100644
@@ -904,7 +904,7 @@ static int amd_pstate_change_driver_mode(int mode)
 	return 0;
 }
 
-cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
+static cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
 	[AMD_PSTATE_DISABLE]         = {
 		[AMD_PSTATE_DISABLE]     = NULL,
 		[AMD_PSTATE_PASSIVE]     = amd_pstate_register_driver,
Signature · 1 line
2.27.0
Reviewed-by on v1 1/1
#2 lore raw
In reply to Tom Rix
Quoted 8 lines · Tom Rix

smatch reports
drivers/cpufreq/amd-pstate.c:907:25: warning: symbol
'mode_state_machine' was not declared. Should it be static?

This variable is only used in one file so it should be static.

Signed-off-by Tom Rix <[email protected]>

---

You might want to use the Fixes: commit ("")
tag? It will help people to pick the patch while
back-porting fixes to older kernels.'

For example:
https://lore.kernel.org/all/[email protected]/

Fixes 0651a730924b ("gpio: davinci: Add support for system suspend/resume PM")

Otherwise,

Reviewed-by Dhruva Gole <[email protected]>
Quoted 16 lines
  drivers/cpufreq/amd-pstate.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpufreq/amd-pstate.c +1 -1
index 6f4b8040d46c..5a3d4aa0f45a 100644
@@ -904,7 +904,7 @@ static int amd_pstate_change_driver_mode(int mode)
  	return 0;
  }
 
-cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
+static cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
  	[AMD_PSTATE_DISABLE]         = {
  		[AMD_PSTATE_DISABLE]     = NULL,
  		[AMD_PSTATE_PASSIVE]     = amd_pstate_register_driver,
Signature · 2 lines
Thanks and Regards,
Dhruva Gole
maintainer Applied
#3 lore raw
In reply to Tom Rix
Quoted 17 lines · Tom Rix

smatch reports
drivers/cpufreq/amd-pstate.c:907:25: warning: symbol
'mode_state_machine' was not declared. Should it be static?

This variable is only used in one file so it should be static.

Signed-off-by Tom Rix <[email protected]>
---
 drivers/cpufreq/amd-pstate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpufreq/amd-pstate.c +0 -0
index 6f4b8040d46c..5a3d4aa0f45a 100644

drivers/cpufreq/amd-pstate.c static int amd_pstate_change_driver_mode(int mode)

Quoted 9 lines
drivers/cpufreq/amd-pstate.c +1 -2
@@ -904,7 +904,7 @@ static int amd_pstate_change_driver_mode(int mode)
        return 0;
 }
 
-cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
+static cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
        [AMD_PSTATE_DISABLE]         = {
                [AMD_PSTATE_DISABLE]     = NULL,
                [AMD_PSTATE_PASSIVE]     = amd_pstate_register_driver,
--

Applied as 6.4 material (under edited subject), thanks!