Skip to contentSkip to conversation

KVM: x86: set varaiable mitigate_smt_rsb storage-class-specifier to static

PATCH Applied Tom Rix 2 participants 2 messages Apr 4, 2023 – Apr 5, 2023

Subsystems (3)
lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 KVM: x86: set varaiable mitigate_smt_rsb storage-class-specifier to static

smatch reports
arch/x86/kvm/x86.c:199:20: warning: symbol
'mitigate_smt_rsb' was not declared. Should it be static?

This variable is only used in one file so it should be static.

---
 arch/x86/kvm/x86.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kvm/x86.c +1 -1
index 8bb8f226f51f..4ce3411d35f3 100644
@@ -196,7 +196,7 @@ bool __read_mostly eager_page_split = true;
 module_param(eager_page_split, bool, 0644);
 
 /* Enable/disable SMT_RSB bug mitigation */
-bool __read_mostly mitigate_smt_rsb;
+static bool __read_mostly mitigate_smt_rsb;
 module_param(mitigate_smt_rsb, bool, 0444);
 
 /*
Signature · 1 line
2.27.0
maintainer Applied
#1 lore raw

"varaiable" in the shortlog is mispelled, I just dropped it and wrapped the variable name itself in quotes.

Quoted 8 lines · Tom Rix

smatch reports
arch/x86/kvm/x86.c:199:20: warning: symbol
'mitigate_smt_rsb' was not declared. Should it be static?

This variable is only used in one file so it should be static.

[...]

Applied to kvm-x86 misc, thanks!

[1/1] KVM: x86: set "mitigate_smt_rsb" storage-class-specifier to static

      https://github.com/kvm-x86/linux/commit/944a8dad8b4e

--
https://github.com/kvm-x86/linux/tree/next
https://github.com/kvm-x86/linux/tree/fixes