iio: dac: set varaiable max5522_channels storage-class-specifier to static
PATCH 1/1 iio: dac: set varaiable max5522_channels storage-class-specifier to static
smatch reportsdrivers/iio/dac/max5522.c:55:28: warning: symbol
'max5522_channels' was not declared. Should it be static?
This variable is only used in one file so it should be static.
--- drivers/iio/dac/max5522.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/dac/max5522.c +1 -1
@@ -52,7 +52,7 @@ struct max5522_state { } \ } -const struct iio_chan_spec max5522_channels[] = { +static const struct iio_chan_spec max5522_channels[] = {MAX5522_CHANNEL (0 ),MAX5522_CHANNEL (1 ), };
Signature · 1 line
2.27.0
Quoted 8 lines · Tom Rix
smatch reports
drivers/iio/dac/max5522.c:55:28: warning: symbol 'max5522_channels' was not declared. Should it be static?This variable is only used in one file so it should be static.
Signed-off-by Tom Rix <[email protected]>---
Jonathan Cameron
maintainerQuoted 5 lines · On Tue, 04 Apr 2023 08:43:32 +0200 Nuno Sá <[email protected]> wrote:
Quoted 4 lines · Tom Rix
smatch reports
drivers/iio/dac/max5522.c:55:28: warning: symbol 'max5522_channels' was not declared. Should it be static?
Quoted 8 lines
Quoted 4 lines
This variable is only used in one file so it should be static.
Signed-off-by Tom Rix <[email protected]>---
Reviewed-by Nuno Sa <[email protected]>
Applied to the togreg branch of iio.git (pushed out initially as testing) with tweak in patch title to fix "variable"
Thanks,
Jonathan