Skip to contentSkip to conversation

ALSA: hda/sigmatel: add pin overrides for Intel DP45SG motherboard

PATCH Applied Oswald Buddenhagen 2 participants 3 messages Apr 5, 2023 – Apr 6, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ALSA: hda/sigmatel: add pin overrides for Intel DP45SG motherboard

Like the other boards from the D*45* series, this one sets up the outputs not quite correctly.

---
 Documentation/sound/hd-audio/models.rst | 2 +-
 sound/pci/hda/patch_sigmatel.c          | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)
Documentation/sound/hd-audio/models.rst +1 -1
index 9b52f50a6854..120430450014 100644
@@ -704,7 +704,7 @@ ref
 no-jd
     BIOS setup but without jack-detection
 intel
-    Intel DG45* mobos
+    Intel D*45* mobos
 dell-m6-amic
     Dell desktops/laptops with analog mics
 dell-m6-dmic
sound/pci/hda/patch_sigmatel.c +2 -0
index a794a01a68ca..64a97d8c1b03 100644
@@ -1955,6 +1955,8 @@ static const struct snd_pci_quirk stac92hd73xx_fixup_tbl[] = {
 				"DFI LanParty", STAC_92HD73XX_REF),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_DFI, 0x3101,
 				"DFI LanParty", STAC_92HD73XX_REF),
+	SND_PCI_QUIRK(PCI_VENDOR_ID_INTEL, 0x5001,
+				"Intel DP45SG", STAC_92HD73XX_INTEL),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_INTEL, 0x5002,
 				"Intel DG45ID", STAC_92HD73XX_INTEL),
 	SND_PCI_QUIRK(PCI_VENDOR_ID_INTEL, 0x5003,
Signature · 1 line
2.40.0.152.g15d061e6df
#1 lore raw

PATCH 2/2 ALSA: hda/sigmatel: fix S/PDIF out on Intel D*45* motherboards

The BIOS botches this one completely - it says the 2nd S/PDIF output is used, while in fact it's the 1st one. This is tested on DP45SG, but I'm assuming it's valid for the other boards in the series as well.

Also add some comments regarding the pins.
FWIW, the codec is apparently still sold by Tempo Semiconductor, Inc., where one can download the documentation.

---
 sound/pci/hda/patch_sigmatel.c | 8 ++++++++
 1 file changed, 8 insertions(+)
sound/pci/hda/patch_sigmatel.c +8 -0
index 64a97d8c1b03..61258b0aac8d 100644
@@ -1707,17 +1707,21 @@ static const struct snd_pci_quirk stac925x_fixup_tbl[] = {
 };
 
 static const struct hda_pintbl ref92hd73xx_pin_configs[] = {
+	// Port A-H
 	{ 0x0a, 0x02214030 },
 	{ 0x0b, 0x02a19040 },
 	{ 0x0c, 0x01a19020 },
 	{ 0x0d, 0x02214030 },
 	{ 0x0e, 0x0181302e },
 	{ 0x0f, 0x01014010 },
 	{ 0x10, 0x01014020 },
 	{ 0x11, 0x01014030 },
+	// CD in
 	{ 0x12, 0x02319040 },
+	// Digial Mic ins
 	{ 0x13, 0x90a000f0 },
 	{ 0x14, 0x90a000f0 },
+	// Digital outs
 	{ 0x22, 0x01452050 },
 	{ 0x23, 0x01452050 },
 	{}
@@ -1758,13 +1762,17 @@ static const struct hda_pintbl alienware_m17x_pin_configs[] = {
 };
 
 static const struct hda_pintbl intel_dg45id_pin_configs[] = {
+	// Analog outputs
 	{ 0x0a, 0x02214230 },
 	{ 0x0b, 0x02A19240 },
 	{ 0x0c, 0x01013214 },
 	{ 0x0d, 0x01014210 },
 	{ 0x0e, 0x01A19250 },
 	{ 0x0f, 0x01011212 },
 	{ 0x10, 0x01016211 },
+	// Digital output
+	{ 0x22, 0x01451380 },
+	{ 0x23, 0x40f000f0 },
 	{}
 };
 
Signature · 1 line
2.40.0.152.g15d061e6df