Skip to contentSkip to conversation

qemu: dfu: Correct memset call in set_dfu_alt_info

PATCH In review Tom Rini 3 participants 4 messages Apr 6, 2023 – Apr 26, 2023

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 qemu: dfu: Correct memset call in set_dfu_alt_info

When building with clang, we see:
board/emulation/common/qemu_dfu.c:51:24: warning: 'memset' call operates on objects of type 'char' while the size is based on a different type 'char *' [-Wsizeof-pointer-memaccess]

As we're calling memset with the length set to the size of the pointer and not the size of the buffer. Correct this with a call of the size of the buffer itself.

---
Cc: Tuomas Tynkkynen <[email protected]>
Cc: Sughosh Ganu <[email protected]>
Cc: Simon Glass <[email protected]>

---
 board/emulation/common/qemu_dfu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/emulation/common/qemu_dfu.c +1 -1
index 332d659c1f7c..7e7d84f6c00f 100644
@@ -48,7 +48,7 @@ void set_dfu_alt_info(char *interface, char *devstr)
 	    env_get("dfu_alt_info"))
 		return;
 
-	memset(buf, 0, sizeof(buf));
+	memset(buf, 0, DFU_ALT_BUF_LEN);
 
 	/*
 	 * Currently dfu_alt_info is needed on Qemu ARM64 for
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Tom Rini

When building with clang, we see:
board/emulation/common/qemu_dfu.c:51:24: warning: 'memset' call operates on objects of type 'char' while the size is based on a different type 'char *' [-Wsizeof-pointer-memaccess]

As we're calling memset with the length set to the size of the pointer and not the size of the buffer. Correct this with a call of the size of the buffer itself.

Quoted 8 lines

---
Cc: Tuomas Tynkkynen <[email protected]>
Cc: Sughosh Ganu <[email protected]>
Cc: Simon Glass <[email protected]>

---
 board/emulation/common/qemu_dfu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by on v1 1/1
#2 lore raw
In reply to Tom Rini
Quoted 10 lines · Tom Rini

When building with clang, we see:
board/emulation/common/qemu_dfu.c:51:24: warning: 'memset' call operates on objects of type 'char' while the size is based on a different type 'char *' [-Wsizeof-pointer-memaccess]

As we're calling memset with the length set to the size of the pointer and not the size of the buffer. Correct this with a call of the size of the buffer itself.

---

-sughosh

Quoted 23 lines
Cc Tuomas Tynkkynen <[email protected]>
Cc Sughosh Ganu <[email protected]>
Cc Simon Glass <[email protected]>
---
 board/emulation/common/qemu_dfu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/emulation/common/qemu_dfu.c +1 -2
index 332d659c1f7c..7e7d84f6c00f 100644
@@ -48,7 +48,7 @@ void set_dfu_alt_info(char *interface, char *devstr)
            env_get("dfu_alt_info"))
                return;
 
-       memset(buf, 0, sizeof(buf));
+       memset(buf, 0, DFU_ALT_BUF_LEN);
 
        /*
         * Currently dfu_alt_info is needed on Qemu ARM64 for
--

2.34.1

author
#3 lore raw
In reply to Tom Rini
Quoted 10 lines · Tom Rini

When building with clang, we see:
board/emulation/common/qemu_dfu.c:51:24: warning: 'memset' call operates on objects of type 'char' while the size is based on a different type 'char *' [-Wsizeof-pointer-memaccess]

As we're calling memset with the length set to the size of the pointer and not the size of the buffer. Correct this with a call of the size of the buffer itself.

Applied to u-boot/master, thanks!

Signature · 1 line
Tom