Skip to contentSkip to conversation

samples/hw_breakpoint: set variable sample_hbp storage-class-specifier to static

PATCH New Tom Rix 1 participant 1 message Apr 6, 2023

lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 samples/hw_breakpoint: set variable sample_hbp storage-class-specifier to static

smatch reports samples/hw_breakpoint/data_breakpoint.c:24:19: warning: symbol
'sample_hbp' was not declared. Should it be static?

This variable is only used in one file so should be static.

---
 samples/hw_breakpoint/data_breakpoint.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
samples/hw_breakpoint/data_breakpoint.c +1 -1
index 418c46fe5ffc..37c4f0ea8e53 100644
@@ -21,7 +21,7 @@
 #include <linux/perf_event.h>
 #include <linux/hw_breakpoint.h>
 
-struct perf_event * __percpu *sample_hbp;
+static struct perf_event * __percpu *sample_hbp;
 
 static char ksym_name[KSYM_NAME_LEN] = "jiffies";
 module_param_string(ksym, ksym_name, KSYM_NAME_LEN, S_IRUGO);
Signature · 1 line
2.27.0