staging: rtl8192e: Fix alignment to match open parenthesis

PATCH In review Sumitra Sharma 2 participants 3 messages Apr 8, 2023 – Apr 16, 2023 Staging

Share & tools

Sumitra Sharma

author

2023-04-08 16:51 UTC #0 lore raw

PATCH 1/1 staging: rtl8192e: Fix alignment to match open parenthesis

Fix alignment to match opening parenthesis as suggested by Linux kernel coding-style. This issue is reported by checkpatch.

CHECK: Alignment should match open parenthesis

Signed-off-by Sumitra Sharma <[email protected]>

---
 drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)

drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +9 ~~-12~~

index cde41111012a..d0b943145259 100644
@@ -564,11 +564,9 @@ static void _rtl92e_dm_tx_power_tracking_callback_tssi(struct net_device *dev)
 
 			for (k = 0; k < 5; k++) {
 				if (k != 4)
-					tmp_report[k] = rtl92e_readb(dev,
-							 Tssi_Report_Value1+k);
+					tmp_report[k] = rtl92e_readb(dev, Tssi_Report_Value1+k);
 				else
-					tmp_report[k] = rtl92e_readb(dev,
-							 Tssi_Report_Value2);
+					tmp_report[k] = rtl92e_readb(dev, Tssi_Report_Value2);
 
 				if (tmp_report[k] <= 20) {
 					viviflag = true;

@@ -1138,7 +1136,7 @@ static void _rtl92e_dm_ctrl_initgain_byrssi_false_alarm(struct net_device *dev)
 		return;
 	if (priv->undecorated_smoothed_pwdb <= dm_digtable.rssi_low_thresh) {
 		if (dm_digtable.dig_state == DM_STA_DIG_OFF &&
-			(priv->reset_count == reset_cnt))
+		    (priv->reset_count == reset_cnt))
 			return;
 		reset_cnt = priv->reset_count;

@@ -1216,7 +1214,7 @@ static void _rtl92e_dm_ctrl_initgain_byrssi_highpwr(struct net_device *dev)
 	if (priv->undecorated_smoothed_pwdb >=
 	    dm_digtable.rssi_high_power_highthresh) {
 		if (dm_digtable.dig_highpwr_state == DM_STA_DIG_ON &&
-			(priv->reset_count == reset_cnt_highpwr))
+		    (priv->reset_count == reset_cnt_highpwr))
 			return;
 		dm_digtable.dig_highpwr_state = DM_STA_DIG_ON;

@@ -1226,7 +1224,7 @@ static void _rtl92e_dm_ctrl_initgain_byrssi_highpwr(struct net_device *dev)
 			rtl92e_writeb(dev, rOFDM0_RxDetector1, 0x43);
 	} else {
 		if (dm_digtable.dig_highpwr_state == DM_STA_DIG_OFF &&
-			(priv->reset_count == reset_cnt_highpwr))
+		    (priv->reset_count == reset_cnt_highpwr))
 			return;
 		dm_digtable.dig_highpwr_state = DM_STA_DIG_OFF;

@@ -2111,9 +2109,8 @@ static void _rtl92e_dm_check_fsync(struct net_device *dev)
 				} else if (priv->undecorated_smoothed_pwdb >=
 					   (RegC38_TH+5)) {
 					if (reg_c38_State) {
-						rtl92e_writeb(dev,
-							rOFDM0_RxDetector3,
-							priv->framesync);
+						rtl92e_writeb(dev, rOFDM0_RxDetector3,
+							      priv->framesync);
 						reg_c38_State = RegC38_Default;
 					}
 				}

@@ -2129,14 +2126,14 @@ static void _rtl92e_dm_check_fsync(struct net_device *dev)
 	if (priv->frame_sync_monitor) {
 		if (priv->reset_count != reset_cnt) {
 			rtl92e_writeb(dev, rOFDM0_RxDetector3,
-				       priv->framesync);
+				      priv->framesync);
 			reg_c38_State = RegC38_Default;
 			reset_cnt = priv->reset_count;
 		}
 	} else {
 		if (reg_c38_State) {
 			rtl92e_writeb(dev, rOFDM0_RxDetector3,
-				       priv->framesync);
+				      priv->framesync);
 			reg_c38_State = RegC38_Default;
 		}
 	}

Signature · 1 line

2.25.1

Greg Kroah-Hartman

maintainer

2023-04-15 15:54 UTC #1 lore raw

Quoted 9 lines · Sumitra Sharma

Fix alignment to match opening parenthesis as suggested by Linux kernel coding-style. This issue is reported by checkpatch.
CHECK: Alignment should match open parenthesis
Signed-off-by Sumitra Sharma <[email protected]>
---
 drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)

You have sent a lot of different patches for the same driver, with the same subject line, but yet doing different things. I am totally confused as to what is, and is not, the latest versions, so I am dropping all of these from my review queue.

Please resend them all, as a numbered patch series, so that we have a clue as to what to review here.

thanks,

greg k-h

Sumitra Sharma

author

2023-04-16 03:50 UTC #2 lore raw

Quoted 11 lines · Greg Kroah-Hartman

Quoted 9 lines · Sumitra Sharma
Fix alignment to match opening parenthesis as suggested by Linux kernel coding-style. This issue is reported by checkpatch.
CHECK: Alignment should match open parenthesis
Signed-off-by Sumitra Sharma <[email protected]>
---
 drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)

Quoted 8 lines

You have sent a lot of different patches for the same driver, with the same subject line, but yet doing different things. I am totally confused as to what is, and is not, the latest versions, so I am dropping all of these from my review queue.
Please resend them all, as a numbered patch series, so that we have a clue as to what to review here.

Okay. Thank you.

Regards

Sumitra

Quoted 3 lines

thanks,
greg k-h