Skip to contentSkip to conversation

hwmon: (aquacomputer_d5next) Fix alignment of function call params

PATCH In review Aleksa Savic 2 participants 5 messages Apr 9, 2023 – Apr 12, 2023

Subsystems (2)
lore
Share & tools
lore

Aleksa Savic

author maintainer
#0 lore raw

PATCH 1/1 hwmon: (aquacomputer_d5next) Fix alignment of function call params

checkpatch warns that alignment of parameters of function call around line 869 is off. Indent them properly.

Fixes 6f5cdf9b9a86 ("hwmon: (aquacomputer_d5next) Add fan PWM control for Aquaero")
---
 drivers/hwmon/aquacomputer_d5next.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/hwmon/aquacomputer_d5next.c +2 -2
index 3bd35d833e69..7db7769fe044 100644
@@ -867,8 +867,8 @@ static int aqc_read(struct device *dev, enum hwmon_sensor_types type, u32 attr,
 		switch (priv->kind) {
 		case aquaero:
 			ret = aqc_get_ctrl_val(priv,
-				AQUAERO_CTRL_PRESET_START + channel * AQUAERO_CTRL_PRESET_SIZE,
-				val, AQC_BE16);
+					       AQUAERO_CTRL_PRESET_START +
+					       channel * AQUAERO_CTRL_PRESET_SIZE, val, AQC_BE16);
 			if (ret < 0)
 				return ret;
 			*val = aqc_percent_to_pwm(*val);
Signature · 1 line
2.39.2
maintainer
#1 lore raw
Quoted 14 lines · Aleksa Savic

checkpatch warns that alignment of parameters of function call around line 869 is off. Indent them properly.

Fixes 6f5cdf9b9a86 ("hwmon: (aquacomputer_d5next) Add fan PWM control for Aquaero")
---
 drivers/hwmon/aquacomputer_d5next.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/hwmon/aquacomputer_d5next.c +0 -0
index 3bd35d833e69..7db7769fe044 100644

drivers/hwmon/aquacomputer_d5next.c static int aqc_read(struct device *dev, enum hwmon_sensor_types type, u32 attr, · line 871

Quoted 7 lines
drivers/hwmon/aquacomputer_d5next.c +2 -2
@@ -867,8 +867,8 @@ static int aqc_read(struct device *dev, enum hwmon_sensor_types type, u32 attr,
 		switch (priv->kind) {
 		case aquaero:
 			ret = aqc_get_ctrl_val(priv,
-				AQUAERO_CTRL_PRESET_START + channel * AQUAERO_CTRL_PRESET_SIZE,
-				val, AQC_BE16);
+					       AQUAERO_CTRL_PRESET_START +
+					       channel * AQUAERO_CTRL_PRESET_SIZE, val, AQC_BE16);

I am not sure I understand how this would improve readability. It seems to accomplish the opposite. Sure, I know, checkpatch --strict complains, but that is still better than unreadable code just to make checkpatch happy.

Guenter

author maintainer
#2 lore raw
Quoted 7 lines · Guenter Roeck

I am not sure I understand how this would improve readability. It seems to accomplish the opposite. Sure, I know, checkpatch --strict complains, but that is still better than unreadable code just to make checkpatch happy.

Guenter

Both seemed fine to me, the idea was to fix the checkpatch warning. If it's OK for it to complain about this, plus the changes would make it harder to read, please ignore this patch.

Thanks,
Aleksa

maintainer
#3 lore raw
Quoted 7 lines · Aleksa Savic
Quoted 6 lines · Guenter Roeck

I am not sure I understand how this would improve readability. It seems to accomplish the opposite. Sure, I know, checkpatch --strict complains, but that is still better than unreadable code just to make checkpatch happy.

Quoted 6 lines
Quoted 1 line

Guenter

Both seemed fine to me, the idea was to fix the checkpatch warning. If it's OK for it to complain about this, plus the changes would make it harder to read, please ignore this patch.

checkpatch is useful, but not in situations where following its guidance results in code which is diffficult to read. I run checkpatch --strict when applying patches, so I do notice when it complains. If I want a report to be addressed, I'll say that (such as, for example, when people are overly generous with empty lines). If not, you can assume that I am ok with the report and find it more important to have readable code than being checkpatch-clean.

Guenter

author maintainer
#4 lore raw
Quoted 23 lines · Guenter Roeck
Quoted 7 lines · Aleksa Savic
Quoted 6 lines · Guenter Roeck

I am not sure I understand how this would improve readability. It seems to accomplish the opposite. Sure, I know, checkpatch --strict complains, but that is still better than unreadable code just to make checkpatch happy.

Quoted 6 lines
Quoted 1 line

Guenter

Both seemed fine to me, the idea was to fix the checkpatch warning. If it's OK for it to complain about this, plus the changes would make it harder to read, please ignore this patch.

checkpatch is useful, but not in situations where following its guidance results in code which is diffficult to read. I run checkpatch --strict when applying patches, so I do notice when it complains. If I want a report to be addressed, I'll say that (such as, for example, when people are overly generous with empty lines). If not, you can assume that I am ok with the report and find it more important to have readable code than being checkpatch-clean.

Quoted 1 line

Guenter

That clears it up, thanks!

Aleksa