f2fs: fix to keep consistent i_gc_rwsem lock order
Chao Yu
maintainerPATCH 1/1 f2fs: fix to keep consistent i_gc_rwsem lock order
i_gc_rwsem[WRITE] and i_gc_rwsem[READ] lock order is reversed in gc_data_segment() and f2fs_dio_write_iter(), fix to keep consistent lock order as below:
1. lock i_gc_rwsem[WRITE]
2. lock i_gc_rwsem[READ]
Signed-off-by Chao Yu <[email protected]>
--- fs/f2fs/gc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
fs/f2fs/gc.c +4 -4
@@ -1616,14 +1616,14 @@ static int gc_data_segment(struct f2fs_sb_info *sbi, struct f2fs_summary *sum,int err;if (S_ISREG (inode->i_mode)) { -if (!f2fs_down_write_trylock (&fi->i_gc_rwsem[READ ])) { +if (!f2fs_down_write_trylock (&fi->i_gc_rwsem[WRITE ])) { sbi->skipped_gc_rwsem++;continue ; }if (!f2fs_down_write_trylock ( - &fi->i_gc_rwsem[WRITE ])) { + &fi->i_gc_rwsem[READ ])) { sbi->skipped_gc_rwsem++; -f2fs_up_write (&fi->i_gc_rwsem[READ ]); +f2fs_up_write (&fi->i_gc_rwsem[WRITE ]);continue ; } locked = true;
@@ -1646,8 +1646,8 @@ static int gc_data_segment(struct f2fs_sb_info *sbi, struct f2fs_summary *sum, submitted++;if (locked) { -f2fs_up_write (&fi->i_gc_rwsem[WRITE ]);f2fs_up_write (&fi->i_gc_rwsem[READ ]); +f2fs_up_write (&fi->i_gc_rwsem[WRITE ]); }stat_inc_data_blk_count (sbi,1 , gc_type);
Signature · 1 line
2.25.1
This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <[email protected]>:
Hello:
This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:
Quoted 9 lines · On Mon, 10 Apr 2023 10:11:40 +0800 you wrote:
i_gc_rwsem[WRITE] and i_gc_rwsem[READ] lock order is reversed in
gc_data_segment()andf2fs_dio_write_iter(), fix to keep consistent lock order as below:
1. lock i_gc_rwsem[WRITE]
2. lock i_gc_rwsem[READ]Signed-off-by Chao Yu <[email protected]>[...]
Here is the summary with links:
- [f2fs-dev] f2fs: fix to keep consistent i_gc_rwsem lock order
https://git.kernel.org/jaegeuk/f2fs/c/db141b729bcc
You are awesome, thank you!
Signature · 10 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel