f2fs: use f2fs_hw_is_readonly() instead of bdev_read_only()
Chao Yu
maintainerPATCH 1/1 f2fs: use f2fs_hw_is_readonly() instead of bdev_read_only()
f2fs has supported multi-device feature, to check devices' rw status, it should use f2fs_hw_is_readonly() rather than bdev_read_only(), fix it.
Meanwhile, it removes f2fs_hw_is_readonly() check condition in:
- f2fs_write_checkpoint()
- f2fs_convert_inline_inode()
As it has checked f2fs_readonly() condition, and if f2fs' devices were readonly, f2fs_readonly() must be true.
--- fs/f2fs/checkpoint.c | 2 +- fs/f2fs/super.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
fs/f2fs/checkpoint.c +1 -1
@@ -721,7 +721,7 @@ int f2fs_recover_orphan_inodes(struct f2fs_sb_info *sbi)if (!is_set_ckpt_flags (sbi,CP_ORPHAN_PRESENT_FLAG ))return 0 ; -if (bdev_read_only (sbi->sb->s_bdev)) { +if (f2fs_hw_is_readonly (sbi)) {f2fs_info (sbi,"write access unavailable, skipping orphan cleanup" );return 0 ; }
fs/f2fs/super.c +2 -2
@@ -3358,7 +3358,7 @@ static inline bool sanity_check_area_boundary(struct f2fs_sb_info *sbi, raw_super->segment_count =cpu_to_le32 ((main_end_blkaddr - segment0_blkaddr) >> log_blocks_per_seg); -if (f2fs_readonly (sb) ||bdev_read_only (sb->s_bdev)) { +if (f2fs_readonly (sb) ||f2fs_hw_is_readonly (sbi)) {set_sbi_flag (sbi,SBI_NEED_SB_WRITE ); res ="internally" ; }else {
@@ -3934,7 +3934,7 @@ int f2fs_commit_super(struct f2fs_sb_info *sbi, bool recover)int err;if ((recover &&f2fs_readonly (sbi->sb)) || -bdev_read_only (sbi->sb->s_bdev)) { +f2fs_hw_is_readonly (sbi)) {set_sbi_flag (sbi,SBI_NEED_SB_WRITE );return -EROFS ; }
Signature · 1 line
2.25.1
This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <[email protected]>:
Hello:
This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:
Quoted 11 lines · On Mon, 10 Apr 2023 10:17:22 +0800 you wrote:
f2fs has supported multi-device feature, to check devices' rw status, it should use
f2fs_hw_is_readonly()rather thanbdev_read_only(), fix it.Meanwhile, it removes
f2fs_hw_is_readonly()check condition in:
-f2fs_write_checkpoint()
-f2fs_convert_inline_inode()
As it has checkedf2fs_readonly()condition, and if f2fs' devices were readonly,f2fs_readonly()must be true.[...]
Here is the summary with links:
- [f2fs-dev] f2fs: use f2fs_hw_is_readonly() instead of bdev_read_only()
https://git.kernel.org/jaegeuk/f2fs/c/68f0453dabdb
You are awesome, thank you!
Signature · 10 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel