f2fs: remove unneeded in-memory i_crtime copy
Chao Yu
maintainerPATCH 1/1 f2fs: remove unneeded in-memory i_crtime copy
i_crtime will never change after inode creation, so we don't need to copy it into f2fs_inode_info.i_disk_time[3], and monitor its change to decide whether updating inode page, remove related stuff.
Signed-off-by Chao Yu <[email protected]>
--- fs/f2fs/f2fs.h | 5 +---- fs/f2fs/inode.c | 1 - 2 files changed, 1 insertion(+), 5 deletions(-)
fs/f2fs/f2fs.h +1 -4
@@ -844,7 +844,7 @@ struct f2fs_inode_info {kprojid_t i_projid;/* id for project quota */ int i_inline_xattr_size;/* inline xattr size */ struct timespec64 i_crtime;/* inode creation time */ -struct timespec64 i_disk_time[4 ];/* inode disk times */ +struct timespec64 i_disk_time[3 ];/* inode disk times */ /* for file compress */ atomic_t i_compr_blocks;/* # of compressed blocks */
@@ -3290,9 +3290,6 @@ static inline bool f2fs_is_time_consistent(struct inode *inode)return false;if (!timespec64_equal (F2FS_I (inode)->i_disk_time +2 , &inode->i_mtime))return false; -if (!timespec64_equal (F2FS_I (inode)->i_disk_time +3 , - &F2FS_I (inode)->i_crtime)) -return false;return true; }
fs/f2fs/inode.c +0 -1
@@ -326,7 +326,6 @@ static void init_idisk_time(struct inode *inode) fi->i_disk_time[0 ] = inode->i_atime; fi->i_disk_time[1 ] = inode->i_ctime; fi->i_disk_time[2 ] = inode->i_mtime; - fi->i_disk_time[3 ] = fi->i_crtime; }static int do_read_inode (struct inode *inode)
Signature · 1 line
2.25.1
This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <[email protected]>:
Hello:
This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:
Quoted 9 lines · On Mon, 10 Apr 2023 10:20:12 +0800 you wrote:
i_crtimewill never change after inode creation, so we don't need to copy it into f2fs_inode_info.i_disk_time[3], and monitor its change to decide whether updating inode page, remove related stuff.Signed-off-by Chao Yu <[email protected]>--- fs/f2fs/f2fs.h | 5 +---- fs/f2fs/inode.c | 1 - 2 files changed, 1 insertion(+), 5 deletions(-)
Here is the summary with links:
- [f2fs-dev] f2fs: remove unneeded in-memory i_crtime copy
https://git.kernel.org/jaegeuk/f2fs/c/c277991d7cf0
You are awesome, thank you!
Signature · 10 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel