Skip to contentSkip to conversation

scsi: pm80xx: Log device registration

PATCH Applied Pranav Prasad 3 participants 3 messages Apr 11, 2023 – Apr 19, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: pm80xx: Log device registration

From: Akshat Jain <[email protected]>

Log combination of phy_id and device_id in device registration response.

---
 drivers/scsi/pm8001/pm8001_hwi.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/scsi/pm8001/pm8001_hwi.c +4 -3
index ec1a9ab61814..73cd25f30ca5 100644
@@ -3362,8 +3362,9 @@ int pm8001_mpi_reg_resp(struct pm8001_hba_info *pm8001_ha, void *piomb)
 	pm8001_dev = ccb->device;
 	status = le32_to_cpu(registerRespPayload->status);
 	device_id = le32_to_cpu(registerRespPayload->device_id);
-	pm8001_dbg(pm8001_ha, MSG, " register device is status = %d\n",
-		   status);
+	pm8001_dbg(pm8001_ha, INIT,
+		   "register device status %d phy_id 0x%x device_id %d\n",
+		   status, pm8001_dev->attached_phy, device_id);
 	switch (status) {
 	case DEVREG_SUCCESS:
 		pm8001_dbg(pm8001_ha, MSG, "DEVREG_SUCCESS\n");
@@ -4278,7 +4279,7 @@ int pm8001_chip_dereg_dev_req(struct pm8001_hba_info *pm8001_ha,
 	memset(&payload, 0, sizeof(payload));
 	payload.tag = cpu_to_le32(1);
 	payload.device_id = cpu_to_le32(device_id);
-	pm8001_dbg(pm8001_ha, MSG, "unregister device device_id = %d\n",
+	pm8001_dbg(pm8001_ha, INIT, "unregister device device_id %d\n",
 		   device_id);
 
 	return pm8001_mpi_build_cmd(pm8001_ha, 0, opc, &payload,
Signature · 1 line
2.40.0.577.gac1e443424-goog
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Pranav Prasad

From: Akshat Jain <[email protected]>

Log combination of phy_id and device_id in device registration response.

Quoted 32 lines
---
 drivers/scsi/pm8001/pm8001_hwi.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/scsi/pm8001/pm8001_hwi.c +4 -4
index ec1a9ab61814..73cd25f30ca5 100644
@@ -3362,8 +3362,9 @@ int pm8001_mpi_reg_resp(struct pm8001_hba_info *pm8001_ha, void *piomb)
        pm8001_dev = ccb->device;
        status = le32_to_cpu(registerRespPayload->status);
        device_id = le32_to_cpu(registerRespPayload->device_id);
-       pm8001_dbg(pm8001_ha, MSG, " register device is status = %d\n",
-                  status);
+       pm8001_dbg(pm8001_ha, INIT,
+                  "register device status %d phy_id 0x%x device_id %d\n",
+                  status, pm8001_dev->attached_phy, device_id);
        switch (status) {
        case DEVREG_SUCCESS:
                pm8001_dbg(pm8001_ha, MSG, "DEVREG_SUCCESS\n");
@@ -4278,7 +4279,7 @@ int pm8001_chip_dereg_dev_req(struct pm8001_hba_info *pm8001_ha,
        memset(&payload, 0, sizeof(payload));
        payload.tag = cpu_to_le32(1);
        payload.device_id = cpu_to_le32(device_id);
-       pm8001_dbg(pm8001_ha, MSG, "unregister device device_id = %d\n",
+       pm8001_dbg(pm8001_ha, INIT, "unregister device device_id %d\n",
                   device_id);
 
        return pm8001_mpi_build_cmd(pm8001_ha, 0, opc, &payload,
--

2.40.0.577.gac1e443424-goog

#2 lore raw
In reply to Pranav Prasad

Pranav,

Quoted 2 lines

Log combination of phy_id and device_id in device registration response.

Applied to 6.4/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering