hwmon: (pmbus/core) Request threaded interrupt with IRQF_ONESHOT
Guenter Roeck
maintainerPATCH 1/1 hwmon: (pmbus/core) Request threaded interrupt with IRQF_ONESHOT
0-day rightfully complains:
drivers/hwmon/pmbus/pmbus_core.c:3164:7-32: WARNING:
Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)
Without IRQF_ONESHOT, the primary interrupt may end up in a loop, and the threaded interrupt handler may never execute. Request interrupt with IRQF_ONESHOT and assume that the interrupt will cleared and re-enabled by clearing the fault condition in the threaded interrupt handler.
Reported-by kernel test robot <[email protected]>
Cc Patrick Rudolph <[email protected]>
Cc Naresh Solanki <[email protected]>
Signed-off-by Guenter Roeck <[email protected]>
---
Patrick, Naresh: please let me know if this is the correct fix, or suggest an alternative.
Thanks,
Guenter
drivers/hwmon/pmbus/pmbus_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/hwmon/pmbus/pmbus_core.c +2 -2
@@ -3246,8 +3246,8 @@ static int pmbus_irq_setup(struct i2c_client *client, struct pmbus_data *data) }/* Register notifiers */ - err =devm_request_threaded_irq (dev, client->irq,NULL , pmbus_fault_handler,0 , -"pmbus-irq" , data); + err =devm_request_threaded_irq (dev, client->irq,NULL , pmbus_fault_handler, +IRQF_ONESHOT ,"pmbus-irq" , data);if (err) {dev_err (dev,"failed to request an irq %d\n" , err);return err;
Signature · 1 line
2.39.2