Skip to contentSkip to conversation

Remove POWER10_CPU dependency and move PPC_MODULE_FEATURE_P10.

PATCH In review Danny Tsen 3 participants 7 messages Apr 13, 2023 – Apr 20, 2023

Subsystems (3)
lore
Share & tools
lore

Danny Tsen

author
#0 lore raw

v2 cover Remove POWER10_CPU dependency and move PPC_MODULE_FEATURE_P10.

Remove Power10 dependency in Kconfig and detect Power10 feature at runtime. Move PPC_MODULE_FEATURE_P10 definition to be in arch/powerpc/include/asm/cpufeature.h.

Danny Tsen (2):
Kconfig: Remove POWER10_CPU dependency.
aes-gcm-p10-glue.c, cpufeature.h: Move Power10 feature, PPC_MODULE_FEATURE_P10.

 arch/powerpc/crypto/Kconfig            | 2 +-
 arch/powerpc/crypto/aes-gcm-p10-glue.c | 1 -
 arch/powerpc/include/asm/cpufeature.h  | 1 +
 3 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.31.1
author
#4 lore raw

PATCH v2 2/2 Move Power10 feature, PPC_MODULE_FEATURE_P10.

Move Power10 feature, PPC_MODULE_FEATURE_P10, definition to be in arch/powerpc/include/asm/cpufeature.h.

---
 arch/powerpc/crypto/aes-gcm-p10-glue.c | 1 -
 arch/powerpc/include/asm/cpufeature.h  | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/crypto/aes-gcm-p10-glue.c +0 -1
index 1533c8cdd26f..bd3475f5348d 100644
@@ -22,7 +22,6 @@
 #include <linux/module.h>
 #include <linux/types.h>
 
-#define PPC_MODULE_FEATURE_P10	(32 + ilog2(PPC_FEATURE2_ARCH_3_1))
 #define	PPC_ALIGN		16
 #define GCM_IV_SIZE		12
 
arch/powerpc/include/asm/cpufeature.h +1 -0
index f6f790a90367..2dcc66225e7f 100644
@@ -22,6 +22,7 @@
  */
 
 #define PPC_MODULE_FEATURE_VEC_CRYPTO			(32 + ilog2(PPC_FEATURE2_VEC_CRYPTO))
+#define PPC_MODULE_FEATURE_P10				(32 + ilog2(PPC_FEATURE2_ARCH_3_1))
 
 #define cpu_feature(x)		(x)
 
Signature · 1 line
2.31.1
author
#1 lore raw

PATCH v2 1/2 Remove POWER10_CPU dependency.

In reply to Danny Tsen

Remove Power10 dependency in Kconfig and detect Power10 feature at runtime.

---
 arch/powerpc/crypto/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/crypto/Kconfig +1 -1
index 1f8f02b494e1..7113f9355165 100644
@@ -96,7 +96,7 @@ config CRYPTO_AES_PPC_SPE
 
 config CRYPTO_AES_GCM_P10
 	tristate "Stitched AES/GCM acceleration support on P10 or later CPU (PPC)"
-	depends on PPC64 && POWER10_CPU && CPU_LITTLE_ENDIAN
+	depends on PPC64 && CPU_LITTLE_ENDIAN
 	select CRYPTO_LIB_AES
 	select CRYPTO_ALGAPI
 	select CRYPTO_AEAD
Signature · 1 line
2.31.1
reviewer Acked-by on v2 1/2
#2 lore raw

Re: [PATCH v2 1/2] Remove POWER10_CPU dependency.

Quoted 1 line · Danny Tsen

Remove Power10 dependency in Kconfig and detect Power10 feature at runtime.

... using the existing call to module_cpu_feature_match() :)

Quoted 4 lines
---
 arch/powerpc/crypto/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

cheers

Quoted 15 lines
arch/powerpc/crypto/Kconfig +1 -1
index 1f8f02b494e1..7113f9355165 100644
@@ -96,7 +96,7 @@ config CRYPTO_AES_PPC_SPE
 
 config CRYPTO_AES_GCM_P10
 	tristate "Stitched AES/GCM acceleration support on P10 or later CPU (PPC)"
-	depends on PPC64 && POWER10_CPU && CPU_LITTLE_ENDIAN
+	depends on PPC64 && CPU_LITTLE_ENDIAN
 	select CRYPTO_LIB_AES
 	select CRYPTO_ALGAPI
 	select CRYPTO_AEAD
Signature · 1 line
2.31.1
reviewer Acked-by on v2 2/2
#5 lore raw

Re: [PATCH v2 2/2] Move Power10 feature, PPC_MODULE_FEATURE_P10.

In reply to Danny Tsen
Quoted 8 lines · Danny Tsen

Move Power10 feature, PPC_MODULE_FEATURE_P10, definition to be in arch/powerpc/include/asm/cpufeature.h.

---
 arch/powerpc/crypto/aes-gcm-p10-glue.c | 1 -
 arch/powerpc/include/asm/cpufeature.h  | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

cheers

Quoted 26 lines
arch/powerpc/crypto/aes-gcm-p10-glue.c +0 -1
index 1533c8cdd26f..bd3475f5348d 100644
@@ -22,7 +22,6 @@
 #include <linux/module.h>
 #include <linux/types.h>
 
-#define PPC_MODULE_FEATURE_P10	(32 + ilog2(PPC_FEATURE2_ARCH_3_1))
 #define	PPC_ALIGN		16
 #define GCM_IV_SIZE		12
 
arch/powerpc/include/asm/cpufeature.h +1 -0
index f6f790a90367..2dcc66225e7f 100644
@@ -22,6 +22,7 @@
  */
 
 #define PPC_MODULE_FEATURE_VEC_CRYPTO			(32 + ilog2(PPC_FEATURE2_VEC_CRYPTO))
+#define PPC_MODULE_FEATURE_P10				(32 + ilog2(PPC_FEATURE2_ARCH_3_1))
 
 #define cpu_feature(x)		(x)
 
Signature · 1 line
2.31.1
author
#3 lore raw

Re: [PATCH v2 1/2] Remove POWER10_CPU dependency.

In reply to Michael Ellerman

Thanks Michael.

-Danny

Quoted 27 lines · Michael Ellerman
Quoted 1 line · Danny Tsen

Remove Power10 dependency in Kconfig and detect Power10 feature at runtime.

... using the existing call to module_cpu_feature_match() :)

Quoted 4 lines
---
  arch/powerpc/crypto/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

cheers

Quoted 15 lines
arch/powerpc/crypto/Kconfig +1 -1
index 1f8f02b494e1..7113f9355165 100644
@@ -96,7 +96,7 @@ config CRYPTO_AES_PPC_SPE
 
  config CRYPTO_AES_GCM_P10
  	tristate "Stitched AES/GCM acceleration support on P10 or later CPU (PPC)"
-	depends on PPC64 && POWER10_CPU && CPU_LITTLE_ENDIAN
+	depends on PPC64 && CPU_LITTLE_ENDIAN
  	select CRYPTO_LIB_AES
  	select CRYPTO_ALGAPI
  	select CRYPTO_AEAD
Signature · 1 line
2.31.1
maintainer
#6 lore raw
In reply to Danny Tsen
Quoted 6 lines · Danny Tsen

Remove Power10 dependency in Kconfig and detect Power10 feature at runtime. Move PPC_MODULE_FEATURE_P10 definition to be in arch/powerpc/include/asm/cpufeature.h.

Quoted 11 lines

Danny Tsen (2):
Kconfig: Remove POWER10_CPU dependency.
aes-gcm-p10-glue.c, cpufeature.h: Move Power10 feature, PPC_MODULE_FEATURE_P10.

 arch/powerpc/crypto/Kconfig            | 2 +-
 arch/powerpc/crypto/aes-gcm-p10-glue.c | 1 -
 arch/powerpc/include/asm/cpufeature.h  | 1 +
 3 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.31.1

All applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt