Skip to contentSkip to conversation

lib: sbi: Add debug print when sbi_pmu_init fails

PATCH New Tan En De 2 participants 2 messages Apr 14, 2023 – Apr 19, 2023

lore
Share & tools
lore

Tan En De

author
#0 lore raw

PATCH 1/1 lib: sbi: Add debug print when sbi_pmu_init fails

Since sbi_pmu_init is called after sbi_console_init, the sbi_printf can be called when sbi_pmu_init fails.

---
 lib/sbi/sbi_init.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
lib/sbi/sbi_init.c +4 -1
index a031336..5db8e7f 100644
@@ -290,8 +290,11 @@ static void __noreturn init_coldboot(struct sbi_scratch *scratch, u32 hartid)
 		sbi_hart_hang();
 
 	rc = sbi_pmu_init(scratch, true);
-	if (rc)
+	if (rc) {
+		sbi_printf("%s: pmu init failed (error %d)\n",
+			   __func__, rc);
 		sbi_hart_hang();
+	}
 
 	sbi_boot_print_banner(scratch);
 
Signature · 1 line
2.34.1
#1 lore raw

PATCH 1/1 lib: sbi: Add debug print when sbi_pmu_init fails

Quoted 30 lines · On Fri, Apr 14, 2023 at 10:45?AM Tan En De <[email protected]> wrote:

Since sbi_pmu_init is called after sbi_console_init, the sbi_printf can be called when sbi_pmu_init fails.

---
 lib/sbi/sbi_init.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
lib/sbi/sbi_init.c +4 -2
index a031336..5db8e7f 100644
@@ -290,8 +290,11 @@ static void __noreturn init_coldboot(struct sbi_scratch *scratch, u32 hartid)
                sbi_hart_hang();
 
        rc = sbi_pmu_init(scratch, true);
-       if (rc)
+       if (rc) {
+               sbi_printf("%s: pmu init failed (error %d)\n",
+                          __func__, rc);
                sbi_hart_hang();
+       }
 
        sbi_boot_print_banner(scratch);
 
--

2.34.1

Quoted 4 lines

--
opensbi mailing list
opensbi at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi

Signature · 2 lines
Regards,
Atish