Skip to contentSkip to conversation

khronos-cts: Replace wayland feature dependancy with vulkan

PATCH In review Linus Jacobson 2 participants 2 messages Apr 14, 2023 – Apr 18, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 khronos-cts: Replace wayland feature dependancy with vulkan

Khronos-cts.inc is used for building vulkan-cts or opengl-es-cts. Even though vulkan-cts depends on vulkan-loader, which automatically requires vulkan distro feature, it is more explicitly stated if written here next to opengl.

Some systems do not support a windowing service (like wayland) but still might use standard khronos GPU libraries. For these cases, wayland dependancy is invalid.

Patch replaces the invalid wayland distro feature dependancy with vulkan for clarity.

---
 meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc +1 -1
index f9074556f..1fda43521 100644
@@ -20,7 +20,7 @@ S = "${WORKDIR}/git"
 
 inherit pkgconfig cmake features_check python3native qemu
 
-ANY_OF_DISTRO_FEATURES += "opengl wayland"
+ANY_OF_DISTRO_FEATURES += "opengl vulkan"
 
 DEPENDS += "python3-lxml-native libpng zlib virtual/libgles2 qemu-native"
 
Signature · 1 line
2.20.1
#1 lore raw

Can this be backported to Mickledore?

//Peter

Quoted 37 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Linus Jacobson
Sent: den 14 april 2023 08:36
To: [email protected]
Cc: Linus Jacobson <[email protected]>
Subject: [oe] [meta-oe][PATCH] khronos-cts: Replace wayland feature dependancy with vulkan

Khronos-cts.inc is used for building vulkan-cts or opengl-es-cts. Even though vulkan-cts depends on vulkan-loader, which automatically requires vulkan distro feature, it is more explicitly stated if written here next to opengl.

Some systems do not support a windowing service (like wayland) but still might use standard khronos GPU libraries. For these cases, wayland dependancy is invalid.

Patch replaces the invalid wayland distro feature dependancy with vulkan for clarity.

---
 meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc +1 -2
index f9074556f..1fda43521 100644
@@ -20,7 +20,7 @@ S = "${WORKDIR}/git"
 
 inherit pkgconfig cmake features_check python3native qemu
 
-ANY_OF_DISTRO_FEATURES += "opengl wayland"
+ANY_OF_DISTRO_FEATURES += "opengl vulkan"
 
 DEPENDS += "python3-lxml-native libpng zlib virtual/libgles2 qemu-native"
 
--

2.20.1